--- Log opened Fri Sep 01 00:00:46 2023 02:28 < michaelfolkson> darosior: Was there a reason you didn't include a sortedmulti_a fragment in #27255? Just leaving for a later PR? 02:28 < darosior> sortedmulti isn't part of Miniscript 02:30 < darosior> Thanks for your interest in reviewing #27255 btw, i'll reply to your comment. Just very busy with cutting a release of Liana at the moment. 02:31 < michaelfolkson> Ah ok. multi is both a descriptor and a Miniscript fragment but sortedmulti is only a descriptor, gotcha 02:33 < michaelfolkson> No worries, there will no doubt be some stupid questions but bear with me :) 04:18 < michaelfolkson> darosior: When the multi_a descriptor was added in #24043 the PR description included "I expect that this functionality will later be *replaced* with a Miniscript based implementation". 04:19 < michaelfolkson> Just lax wording right? This is just extending rather than replacing as far as I can work out, not sure what needed replacing 04:51 < darosior> I think we could replace some of the descriptors with the Miniscript logic. I actually looked into it for multi_a, but iirc it needed some amount of refactoring and i think it's better to do all at once in a followup. 04:52 <@sipa> michaelfolkson: in the codebase we have a clear distinction between miniscript (and the descriptor fragments it enables) and the rest of the descriptor logic 04:52 <@sipa> but to the user, thete is 04:53 <@sipa> really no distinction, there are just some descriptors features that are supported 04:54 <@sipa> what that phrasing refers to, i think, is the belief that we can probably at some point get rid of multi_a in the descriptors proper code, and use the miniscript code to provide the multi_a feature (when it's not used inside other miniscript fragments) 04:54 <@sipa> but that wouldn't be noticable to the user 04:59 < michaelfolkson> Ok cool, thanks both. Yeah I was starting to think about possible refactors based on that comment but sounds like sipa is happy with not doing them in this PR 07:18 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined ##miniscript 07:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 246 seconds] 09:41 -!- achow101 [~achow101@user/achow101] has quit [Remote host closed the connection] 09:58 -!- achow101 [~achow101@user/achow101] has joined ##miniscript 11:20 -!- harding [quassel@newmail.dtrt.org] has quit [Server closed connection] 11:20 -!- harding [quassel@newmail.dtrt.org] has joined ##miniscript 12:42 -!- gnusha [~gnusha@user/gnusha] has quit [Server closed connection] --- Log closed Fri Sep 01 13:06:32 2023 --- Log opened Fri Sep 01 13:07:11 2023 13:07 -!- gnusha [~gnusha@user/gnusha] has joined ##miniscript 13:07 -!- Irssi: ##miniscript: Total of 31 nicks [1 ops, 0 halfops, 0 voices, 30 normal] 13:08 -!- Channel ##miniscript created Thu May 20 00:29:16 2021 13:10 -!- Irssi: Join to ##miniscript was synced in 179 secs 13:54 -!- kalle [~quassel@user/kallewoof] has quit [Server closed connection] 13:55 -!- kalle [~quassel@user/kallewoof] has joined ##miniscript 16:14 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 245 seconds] 16:26 -!- jon_atack [~jonatack@user/jonatack] has joined ##miniscript 16:52 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined ##miniscript 17:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined ##miniscript 17:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 17:32 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined ##miniscript 20:28 -!- MatrixBot1234561 [~matrixbot@2001:bc8:1824:bc3::1] has quit [Server closed connection] 20:29 -!- MatrixBot1234561 [~matrixbot@2001:bc8:1824:bc3::1] has joined ##miniscript --- Log closed Sat Sep 02 00:00:12 2023