--- Log opened Tue Mar 12 00:00:25 2024 00:02 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has joined ##miniscript 00:07 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has quit [Ping timeout: 260 seconds] 00:36 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has joined ##miniscript 00:43 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has quit [Ping timeout: 264 seconds] 00:56 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has joined ##miniscript 01:01 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has quit [Ping timeout: 256 seconds] 01:13 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has joined ##miniscript 01:19 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has quit [Ping timeout: 268 seconds] 01:42 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has joined ##miniscript 01:47 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:1c99:d2dc:2038:c286] has quit [Ping timeout: 246 seconds] 02:03 -!- brunoerg [~brunoerg@187.183.43.117] has joined ##miniscript 05:47 -!- brunoerg [~brunoerg@187.183.43.117] has quit [Remote host closed the connection] 06:45 < andytoshi> sanket1729: i'm looking at this test https://github.com/rust-bitcoin/rust-miniscript/blob/master/src/policy/compiler.rs#L1504 which says that for k/n from 1 to 20 the optimal compilation for a threshold is a multi() 06:45 < andytoshi> but actually, for a 1-of-1 and 2-of-2, it is more efficient to use vc:pk and and_v(vc:pk, vc:pk) 06:45 < andytoshi> for 3-of-3 it's equal 06:46 < andytoshi> so, currently there is a bug/inefficiency in the compiler that causes it not to even try and_v when multi is available, so this test passes 06:46 < andytoshi> but if i fix the inefficiency then the test fails 06:47 < andytoshi> oh, the test fixes n == 3 .. i'll just change the test to use n == 4 06:49 < andytoshi> for taproot the situation is even worse ... for n-of-n it is _always_ more efficient to use and_v than to use CSA. but our code will always use CSA 07:02 < andytoshi> oh, neat, also i found a crashing bug in the compiler 07:10 < andytoshi> anyway, i'm working on a PR that introduces a Threshold type which can't be constructed unless 0 < k <= n, and unless n is below whatever the maximum is for the type (if any) (e.g. 20 for CHECKMULTISIG). but threading this though the compiller has revealed a bit of weirdness in how we handle multi/multi_a 07:10 < andytoshi> i was hoping to do this PR without any logic changes but i think i'll need to 07:46 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:0:4d3b] has joined ##miniscript 07:50 < andytoshi> ok, actually i can fix these things independent of my Threshold change. i'll do that an PR 08:01 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 264 seconds] 08:29 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:0:4d3b] has quit [Remote host closed the connection] 08:44 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:0:4d3b] has joined ##miniscript 08:50 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:0:4d3b] has quit [Ping timeout: 246 seconds] 08:52 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:0:4d3b] has joined ##miniscript 10:45 -!- brunoerg [~brunoerg@2001:12d0:2080:2800:172:26:0:4d3b] has quit [Remote host closed the connection] 15:32 -!- jonatack [~jonatack@user/jonatack] has joined ##miniscript 16:23 -!- brunoerg_ [~brunoerg@2804:14c:3bfb:11d:8caf:f8d7:25d9:2151] has joined ##miniscript 16:25 -!- brunoerg_ [~brunoerg@2804:14c:3bfb:11d:8caf:f8d7:25d9:2151] has quit [Remote host closed the connection] 16:26 -!- brunoerg [~brunoerg@2804:14c:3bfb:11d:8caf:f8d7:25d9:2151] has joined ##miniscript 23:10 -!- lbia [~lbia@user/lbia] has quit [Ping timeout: 268 seconds] 23:11 -!- lbia [~lbia@user/lbia] has joined ##miniscript --- Log closed Wed Mar 13 00:00:25 2024