--- Day changed Thu Aug 23 2018
00:11 -!- itaseski [~itaseski@213.135.176.241] has joined #rust-bitcoin
00:53 -!- itaseski [~itaseski@213.135.176.241] has quit [Ping timeout: 240 seconds]
06:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds]
07:52 -!- itaseski [~itaseski@213.135.176.250] has joined #rust-bitcoin
08:20 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-aycqdrvsqzqrvjcg] has joined #rust-bitcoin
10:33 -!- itaseski [~itaseski@213.135.176.250] has quit [Quit: Leaving]
15:32 -!- TamasBlummer [~Thunderbi@2003:e3:8f0d:6d35:b497:e690:9585:b5eb] has joined #rust-bitcoin
15:35 < TamasBlummer> @BlueMatt: ChainWatchInterface still contains a registration to watch for an outpoint. How is this supposed to work in a light client that uses bip157 filters?
15:36 < BlueMatt> i thought i fixed that
15:36 < BlueMatt> hmm, no, you can comply with the new interface for bip 157
15:36 < BlueMatt> it registers a watch outpoint but tells you the scriptpubKey
15:36 < BlueMatt> which I thought bip 157 used?
15:37 < BlueMatt> so you can just match the scriptPubKey
15:37 < TamasBlummer> yes, there is no filter for outpoint. can only match script
15:37 < BlueMatt> yea, but thats fine, the interface gives you both
15:37 < BlueMatt> you can ignore the outpoint if you're matching the script
15:37 < TamasBlummer> ok, thanks
15:37 < BlueMatt> giving exxtra transactions isnt a problem
19:02 < BlueMatt> sgeisler: yo
19:02 < BlueMatt> do you mind if I just remove the amount_si(amount, si_prefix) thing in InvoiceBuilder
19:02 < BlueMatt> cause that would let you create a pico-btc-overflowing Invoice, which I think we'd prefer to simply disallow?
19:03 < sgeisler> Not too much, the easiest workaround besides removing the function would be to add a CreationError for this case
19:04 < BlueMatt> yea, I mean it kinda sucks to add a CreationError there that gets returned later, I mean could have amount_si() return a Result<Self, CreationError>, but that also sucks
19:04 < BlueMatt> and not a ton of reason to want an amount_si()
19:06 < sgeisler> since the builder is for standard/simple use cases I don't see a reason to have the amount_si() function too, but then you really want to make amount_pico_btc() more intelligent to choose the right SI prefix
19:07 < BlueMatt> yea, one thing at a time, though :)
19:07 < BlueMatt> not a high priority :p
19:08 < sgeisler> will you fix the compile bugs in your PR? otherwise I just added your repo as remote to fix them myself
19:12 < BlueMatt> I think I just did?
19:13 < BlueMatt> oh god damn it
19:15 < sgeisler> no problem, it's some functional map_or foo, I can dig into it if you have more important stuff to do, since it only happened because of my nit
19:15 < BlueMatt> no, I already got it
19:16 < sgeisler> ok, did you push?
19:16 < BlueMatt> fixed
19:19 < sgeisler> Thx, I will merge it as soon as travis is finished
19:25 < sgeisler> Will anybody of you be at the Lightning Hackday in Berlin?
19:27 < BlueMatt> I wont, sadly :/
19:28 -!- TamasBlummer [~Thunderbi@2003:e3:8f0d:6d35:b497:e690:9585:b5eb] has quit [Quit: TamasBlummer]
20:49 -!- ariard [~ariard@167.99.46.220] has joined #rust-bitcoin
20:49 -!- Topic for #rust-bitcoin: Rust-Bitcoin Libraries Discussion. Artisinal Bitcoin for the rest of us. Do NOT have private conversations on the FreeNode network! See https://github.com/rust-bitcoin If you created a repo, and I forgot to make you admin on it (stupid github defaults), ping BlueMatt
20:49 -!- Topic set by BlueMatt [~BlueMatt@unaffiliated/bluematt] [Sun Aug  5 09:06:05 2018]
20:49 [Users #rust-bitcoin]
20:49 [ andytoshi] [ BlueMatt] [ nickler] [ sgeisler ] [ windsok] 
20:49 [ ariard   ] [ dongcarl] [ savil  ] [ treyzania] 
20:49 -!- Irssi: #rust-bitcoin: Total of 9 nicks [0 ops, 0 halfops, 0 voices, 9 normal]
20:49 -!- Channel #rust-bitcoin created Fri Mar  9 17:46:56 2018
20:49 -!- Irssi: Join to #rust-bitcoin was synced in 6 secs