--- Day changed Thu Aug 30 2018
01:49 < ariard> ah sorry, I add get_chain_txo, ChainError and get_spendable_outpoint on #134
01:49 < ariard> but it's unfinished because I think we need to rely on blokchain store stuff to go further
01:52 < BlueMatt> ariard: wait, but if we have get_chain_txo why do we need get_spendable_outpoint or get_network?
01:54 < ariard> ah yeah get_network is useless, you reverse the test and see with the ChainError 
01:55 < ariard> and get_txo tell us if it's a valid tx:outpoint on this chain not if it's still in the UTXO right ?
01:56 < BlueMatt> just rename it get_chain_utxo and problem solved :p
01:56 < BlueMatt> point was - do we have a reason to need the distinction?
01:56 < ariard> hmmm, are we interesed at some point in lightning by old funding tx? 
01:57 < BlueMatt> i mean if the channel has been closed its unlikely to route :p
01:57 < BlueMatt> plus loss of some potentially-routable channels isnt the end of the world
01:57 < ariard> ok right :)
01:58 < ariard> we'll do the changes tomorrow
01:58 < ariard> and need to add some test against all supported chain
01:58 < ariard> a macro or other
02:01 < BlueMatt> huh? why need a macro
02:01 < BlueMatt> we only care in channel_announcement
02:03 < ariard> something like testing against supported chains for ChainError:UnknownChain
02:03 < BlueMatt> isnt that up to the client to do? not our problem
02:03 < BlueMatt> client as in the library client that has to implement get_chain_utxo
02:06 < ariard> but we need to implement at least get_chain_utxo for ChainWatchInterfaceUtil, should be only for test?
02:11 < BlueMatt> hmm, I mean for now just stub it in with a DontImplement return value? Need to rethink the whole thing anyway re https://github.com/rust-bitcoin/rust-lightning/issues/80
02:15 < ariard> noted, yes it's sometimes hard to get right what need to get into the interface, and what should be let to the client
06:45 -!- Blackwolfsa [sid307900@gateway/web/irccloud.com/x-lmvzimeogikvzwmt] has joined #rust-bitcoin
06:46 < cjs77> BlueMatt: FluffyPony has already chatted to you afaik, but we've got some devs here at Tari that are raring to get involved with rust-lightning. Is this the best channel to discuss RLN? And can you recommend some first issues to pick up?
08:10 -!- nickler_ [~nickler@185.12.46.130] has joined #rust-bitcoin
08:10 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 268 seconds]
10:58 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kpymbpbxmetzmxnp] has joined #rust-bitcoin
12:23 -!- mikethetike [sid308076@gateway/web/irccloud.com/x-frnzyclamnsuddfo] has joined #rust-bitcoin
14:07 -!- simian_za [sid314183@gateway/web/irccloud.com/x-qfvgmwwzokrjdzjw] has joined #rust-bitcoin
15:59 < BlueMatt> cjs77: yup, this is the place!
16:00 < BlueMatt> cjs77: let me go through and tag 0.1-milestone things and y'all can interpret that as 'priority'
16:10 < BlueMatt> cjs77: ok, so I tagged 0.1 milestone as things which are required for things to be really practically-useful
16:10 < BlueMatt> like could-actually-use rust-lightning
16:10 < BlueMatt> at https://github.com/rust-bitcoin/rust-lightning/issues
16:11 < BlueMatt> I dunno what your usual approach is to getting into new projects, working through #129 stuff is kinda aggressive but certainly would work for the "dive in over your head and try desperately to tread water until you figure out whats up" approach
16:11 < BlueMatt> Blackwolfsa: said they were taking a look at that stuff for BOLT 2
16:12 < BlueMatt> I'm getting there on bolt 7 after https://github.com/rust-bitcoin/rust-lightning/pull/134 we may be almost good on bolt 7
16:14 < BlueMatt> if you haven't already done so, you may want to play with https://github.com/TheBlueMatt/rust-lightning-bitcoinrpc with some testnet btc and open/close channels/send/receive payments just to see the thing working
16:14 < BlueMatt> and so you can see the intended-user-story for rust-lightning
16:15 < BlueMatt> another approach I know some people like when getting into projects is writing tests....we have some basic integration tests in ChannelManager, but they could use some love and certainly use some error-handling-correctness test additions
16:15 < BlueMatt> and generally writing tests with the ChannelManager stuff should be very doable
16:16 < BlueMatt> alternatively you can go down the insane-hacky-test route and add tests in full_stack_target which run the entire library in a harness and make fuzz-test initialization examples https://github.com/rust-bitcoin/rust-lightning/blob/master/fuzz/fuzz_targets/full_stack_target.rs#L707
19:50 < cjs77> Awesome, thanks BlueMatt. I think there's plenty here to get started on
19:57 < cjs77> Blackwolfsa: will be the main dev working on this for now; and another will join the effort in about  4 weeks after his initial Rust skill-up period, and another guy 2 weeks after that. They're all somewhat new to Rust and OSS developement, but are very smart and talented engineers and they'll start crushing it soon.
20:03 < BlueMatt> awesome! looking forward to it
20:08 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kpymbpbxmetzmxnp] has quit [Quit: Connection closed for inactivity]
20:21 < Blackwolfsa> Thanks, I will dive into those rather then. I do agree #129 is very aggressive. So far I have only added the small error handling improvements. But I will make a PR for those before I move over to some of the other stuff.
20:24 < BlueMatt> heh, I mean up to your approach, I tend to like to get into projects by getting overly aggressive and learning by being wrong repeatedly
20:24 < BlueMatt> the more you're wrong the more you're learning :p
22:08 < ariard> Bluematt: hey, looking on 134-proposed-changes!
22:31 < ariard> fixed a typo, just rebased your stuff on #134, seems fine apart from the comment on ChainError::NotSupported