--- Day changed Tue Oct 09 2018
10:24 < stevenroose> dongcarl: you're doing refactoring around the PrivateKey stuff, right? So I better not touch it?
10:25 < dongcarl> What’s the change? I’d be happy to rebase if not too complicated
10:29 < stevenroose> Just thinking about this discussion: https://github.com/rust-bitcoin/rust-bitcoin/issues/164#issuecomment-428041569
10:30 < stevenroose> It's a good point that printing a raw private key in Display can leak information.
13:58 < dongcarl> I tend to agree with stevenroose, andytoshi we can talk in detail about this tmr
22:13 < andytoshi> yeah, we can drop Display for PrivateKey
22:14 < andytoshi> though Display is never auto-derived
22:14 < andytoshi> actually .. no, that will make it impossible to get the WIF format without allocating
22:38 < dongcarl> andytoshi: How so? We can just make `to_wif` return `Result<String, fmt::Error>`
22:38 < dongcarl> a.k.a. `Ok(check_encode_slice(blah blah))`
22:43 < andytoshi> that allocates a String..
22:44 < dongcarl> The current `Display` for `PrivKey` also does that, no?
22:44 < andytoshi> yes, but that's a bug
22:44 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/issues/145
22:45 < dongcarl> Hmmm... we can do `format_wif(&self, fmt: &mut Formatter) -> fmt::Result`?
22:46 < andytoshi> yes, but at that point we're being deliberately undiscoverable
22:46 < andytoshi> and unergonomic
22:47 < dongcarl> I thought the point was to be deliberately undiscoverable so people can't footgun?
22:47 < andytoshi> i don't buy that somebody would "accidentally" call Display::fmt on a private key
22:47 < andytoshi> you have to do it explicitly and it is much harder if we mkae things incompatible with format_args! and friends
22:49 < dongcarl> Okay, I don't really care either way, and BTW it's hilarious that the Bitcoin wiki can be so wrong...
22:49 < andytoshi> it was pay-to-play forever, there was no way it was ever going to be correct
22:49 < andytoshi> anyway serde::Serialize is way easier to accidentally use than Display
22:49 < dongcarl> wait how was Bitcoin wiki pay-to-play??
22:50 < andytoshi> theymos required 0.15 BTC to sign up from the time it was created until 2014 or so
22:50 < andytoshi> which went from "well under a penny" to "tens of dollars" in the time it existed
22:51 < dongcarl> oof
22:51 < andytoshi> i have never edited the wiki for this reason, it was an insulting pointless barrier ... much like renaming Display::fmt would be
22:52 < dongcarl> lol glad we brought it around to the real issue
22:52 < andytoshi> :P