--- Day changed Mon Oct 29 2018
12:26 < stevenroose> andytoshi: you mind if I create a direct getter for the BE bytes of a Sha256dHash? The .into_be().to_bytes() returns [u64; 4]..
12:29 < stevenroose> Hmm, I could to to_bytes() and then .reverse() it.. Think I finally found why the Trezor isn't working :|
14:38 < stevenroose> how do I unmut a variable? I have an &mut [xx] and I have a from that is only defined on the not-mut-ref so it refuses..
14:40 < stevenroose> got it: &*variable
15:07 < stevenroose> dongcarl: how is work on the psbt PR going? If you want, I can make PRs against your branch..
15:08 < stevenroose> for the changes I suggested
15:12 < andytoshi> stevenroose: i think to_bytes().reverse() is the best way to do this
15:12 < andytoshi> honestly i think .into_be() is just wrong, a hash has no notion of "endianness", we shouldn't be doing any reversal except in the Display/Serialize impl
15:13 < andytoshi> and if you need it for some Trezor application, it's best to be explicit about it (and for it to be explicitly weird) than to have a dedicated method
15:20 < stevenroose> Yeah just created to helper methods.  And I agree it shouldn't really be endian-based. More "reversed and not-reversed" :p And yeah it doesn't make much sense to have a "to_reversed_bytes()" getter
15:32 < stevenroose> Nice. I can finally sign txs with a Trezor :)
15:32 < andytoshi> nice :)
15:43 < Blackwolfsa> @BlueMatt: I will probably fix 169 tomorrow, merge conflicts broken that one quite bad. Wanted to get something on 202 first for feedback
15:44 < BlueMatt> Blackwolfsa: oops, sorry about that, I figured it would be a big list of conflicts but they'd all just be like re-adding an argument for changed function defs
19:50 < wraithm> Does rust-bitcoin have BIP-174 (PSBT) implemented? Just looking on github, I don't see it. Just curious.
19:51 < BlueMatt> dongcarl was working on one
19:51 < BlueMatt> ah, https://github.com/rust-bitcoin/rust-bitcoin/pull/103
19:52 < wraithm> Cool! Thanks :)
22:39 < stevenroose> wraithm: I've been using it for a while and made some suggestions that might increase usability a lot. So if there's any other improvements you see, shoot.
23:03 < dongcarl> stevenroose: that would be good... I'm getting on my PublicKey things
23:31 < dongcarl> andytoshi: Right now for the `rust-bitcoin` `PublicKey`, I'm trying to write a `serialize` method that would either call `serialize()` or `serialize_uncompressed` based on the `compressed` field of `PublicKey`
23:32 < dongcarl> It would seem that I am unable to return a slice, but would have to copy it into a `Vec` to be returned
23:32 < dongcarl> This is most unfortunate