--- Log opened Tue Nov 27 00:00:35 2018 00:24 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 260 seconds] 00:33 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #rust-bitcoin 06:06 < ariard> BlueMatt: ah yes thanks well was something like that, just didn't spotted first because it was only stucked past a given block height 06:08 < ariard> and duplicate_hash test shows that my current onchain-2-offchain is currently broken on same hash because I'm unable to associate a given HTLCSource for a resolving htlc tx 06:09 < ariard> may need to add more data in HTLCSource but seems to me you can't guess htlc_id from an onchain htlc tx? So that lets open detection by amount ? (but not reliable too) 06:10 < ariard> or by commitment tx index? But no guarantee there are the same on both local/remote commitment tx right? 07:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 07:23 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 07:47 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 07:59 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin 08:06 -!- TamasBlummer1 [~Thunderbi@p200300DD67286B60C09D22D3048757B8.dip0.t-ipconnect.de] has joined #rust-bitcoin 08:08 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 08:08 -!- TamasBlummer [~Thunderbi@p200300DD67286B96C09D22D3048757B8.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 08:08 -!- TamasBlummer1 is now known as TamasBlummer 08:54 < BlueMatt> ariard: wait, huh, why is 198 reviewable? 08:56 < BlueMatt> ariard: https://github.com/rust-bitcoin/rust-lightning/pull/198#discussion_r236755131 09:52 <@andytoshi> BlueMatt: oh, nice, i'll steal the LTO trick. i expect it won't be nearly as big a deal for rust-bitcoin as it will be for rust-lightning 09:52 <@andytoshi> stevenroose: dongcarl: i've been fairly unavailable for the last couple weeks. do you guys have things blocked on me that I should look at now? 09:52 < BlueMatt> yea, probably not, but it made a huge difference for us 09:53 <@andytoshi> we have fuzz-tests for the blockstream functionaries now, i expect a huge speedup there too 09:53 <@andytoshi> maybe we already have lto on actually .. would need to check.. 09:53 < BlueMatt> yea, iiuc if the top-level crate sets it it gets turned on for all deps 09:54 < BlueMatt> but, yea, rust-lightning isnt exactly laid out well to be optimized well, so lto can beat a bunch of shit into submission 09:59 < dongcarl> andytoshi: if we can finalize this, I can rebase PSBT: https://github.com/rust-bitcoin/rust-bitcoin/pull/183 10:05 < stevenroose> andytoshi: I don't. Just the jsonrpc thing, but that's not officially urgent in any way :) 10:54 -!- savil [savilmatri@gateway/shell/matrix.org/x-kyrtzcpvncfzzuvp] has quit [Remote host closed the connection] 10:54 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-vfcjsnvrobtshpds] has quit [Remote host closed the connection] 11:13 -!- savil [savilmatri@gateway/shell/matrix.org/x-cjaivhtkwrdmvzcq] has joined #rust-bitcoin 11:32 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-crsbevvekudxwnis] has joined #rust-bitcoin 11:56 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-crsbevvekudxwnis] has quit [Remote host closed the connection] 11:56 -!- savil [savilmatri@gateway/shell/matrix.org/x-cjaivhtkwrdmvzcq] has quit [Remote host closed the connection] 12:04 -!- savil [savilmatri@gateway/shell/matrix.org/x-kufjikynytnaszvp] has joined #rust-bitcoin 12:22 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-tljeyaydpblciksd] has joined #rust-bitcoin 13:27 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 250 seconds] 13:52 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 15:29 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:49 < ariard> BlueMatt: last evening I thought 198 was reviewable but then this morning writing the test I realized it wasn't handling well the duplicate hash case 15:50 < ariard> currently on your last volley of comments 15:50 < ariard> BlueMatt: unsolved problem is how to link best HTLCSource in case of duplicate hash on same channel ? Only difference is htlc_id, but no way to derive it from onchain tx 17:50 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 245 seconds] 18:55 -!- _cryptodesktop_i [~John@91.245.77.21] has joined #rust-bitcoin 19:29 -!- _cryptodesktop_i [~John@91.245.77.21] has quit [Ping timeout: 250 seconds] 19:54 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin 20:43 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 20:45 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 268 seconds] 21:15 -!- grubles_ is now known as grubles 22:38 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection] 22:38 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 22:38 -!- grubles [~grubles@unaffiliated/grubles] has quit [Client Quit] 23:03 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin --- Log closed Wed Nov 28 00:00:36 2018