--- Log opened Mon Dec 10 00:00:48 2018 09:52 -!- gnusha [~gnusha@unaffiliated/kanzure/bot/gnusha] has joined #rust-bitcoin 09:52 -!- Topic for #rust-bitcoin: Rust-Bitcoin Libraries Discussion. Artisinal Bitcoin for the rest of us. Do NOT have private conversations on the FreeNode network! | https://github.com/rust-bitcoin | Logs at http://gnusha.org/rust-bitcoin/ 09:52 -!- Topic set by andytoshi [~apoelstra@unaffiliated/andytoshi] [Sat Nov 17 10:14:18 2018] 09:52 [Users #rust-bitcoin] 09:52 [ andytoshi ] [ dpc ] [ grubles ] [ michaelsdunn1 ] [ savil ] [ stevenroose ] 09:52 [ ariard ] [ e4xit ] [ gwillen ] [ midnightmagic ] [ schmidty ] [ TamasBlummer] 09:52 [ belcher ] [ elichai2 ] [ harding ] [ mikethetike ] [ scoobybejesus] [ warren ] 09:52 [ Blackwolfsa] [ esotericnonsense] [ havik ] [ molz ] [ sdaftuar ] [ windsok ] 09:52 [ BlueMatt ] [ gmaxwell ] [ instagibbs] [ neonknight ] [ sgeisler ] [ wraithm ] 09:52 [ cjs77 ] [ gnusha ] [ jamesob ] [ nickler ] [ simian_za ] [ wumpus ] 09:52 [ dongcarl ] [ gribble ] [ kanzure ] [ real_or_random] [ sipa ] 09:52 -!- Irssi: #rust-bitcoin: Total of 41 nicks [0 ops, 0 halfops, 0 voices, 41 normal] 09:52 -!- Channel #rust-bitcoin created Fri Mar 9 09:46:56 2018 09:52 -!- Irssi: Join to #rust-bitcoin was synced in 54 secs 09:54 -!- gnusha [~gnusha@unaffiliated/kanzure/bot/gnusha] has joined #rust-bitcoin 09:54 -!- Topic for #rust-bitcoin: Rust-Bitcoin Libraries Discussion. Artisinal Bitcoin for the rest of us. Do NOT have private conversations on the FreeNode network! | https://github.com/rust-bitcoin | Logs at http://gnusha.org/rust-bitcoin/ 09:54 -!- Topic set by andytoshi [~apoelstra@unaffiliated/andytoshi] [Sat Nov 17 10:14:18 2018] 09:54 [Users #rust-bitcoin] 09:54 [ andytoshi ] [ dpc ] [ grubles ] [ michaelsdunn1 ] [ savil ] [ stevenroose ] 09:54 [ ariard ] [ e4xit ] [ gwillen ] [ midnightmagic ] [ schmidty ] [ TamasBlummer] 09:54 [ belcher ] [ elichai2 ] [ harding ] [ mikethetike ] [ scoobybejesus] [ warren ] 09:54 [ Blackwolfsa] [ esotericnonsense] [ havik ] [ molz ] [ sdaftuar ] [ windsok ] 09:54 [ BlueMatt ] [ gmaxwell ] [ instagibbs] [ neonknight ] [ sgeisler ] [ wraithm ] 09:54 [ cjs77 ] [ gnusha ] [ jamesob ] [ nickler ] [ simian_za ] [ wumpus ] 09:54 [ dongcarl ] [ gribble ] [ kanzure ] [ real_or_random] [ sipa ] 09:54 -!- Irssi: #rust-bitcoin: Total of 41 nicks [0 ops, 0 halfops, 0 voices, 41 normal] 09:54 -!- Channel #rust-bitcoin created Fri Mar 9 09:46:56 2018 09:55 -!- Irssi: Join to #rust-bitcoin was synced in 54 secs 11:03 < sgeisler> andytoshi: I generally think our workflow could use some more structure and the org/project thing was the least intrusive way to try to achieve this. I was also thinking about using tags for priorities and assign people to tasks they are working on so it's easier to find the issues that are most important to solve. 11:07 < sgeisler> BlueMatt: I'm working on integrating bitcoin-constants into rust-bitcoin right now, but I guess it will take at least a week to get it to a point where one would think about publishing (I also need to integrate bitcoin_hashes along the way). 11:08 < BlueMatt> sgeisler: yea, totally, just noting that I'm excited for it cause currently have to do constant conversion in rust-lightning-bitcoinrpc whichi s annoying 11:08 < BlueMatt> not that I really do much with rust-lightning-bitcoinrpc except use it as a testing harness right now 11:08 < BlueMatt> but if the rest of y'all havent used it, its a (mostly) working lightning client with a simple cli that uses bitcoin core's wallet/rpc for sync and such :) 11:08 < BlueMatt> check it out :p 11:10 < sgeisler> Oh, that's amazing! Maybe I'll be able to migrate my candy dispenser to rust ^^ 11:10 < sgeisler> rust-lightning-bitcoinrpc 11:10 < BlueMatt> errr, dont expect it to not lose money, yet, unless you want to fill out a few TODOs in it :p 11:10 < sgeisler> sorry, c/p on the wrong screen 11:11 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 11:11 < BlueMatt> https://github.com/TheBlueMatt/rust-lightning-bitcoinrpc 11:12 < sgeisler> Well, I'm currently only connecting to my own node, so in the worst case I can just steal my own money back :D 11:12 < BlueMatt> specifically https://github.com/TheBlueMatt/rust-lightning-bitcoinrpc/blob/master/src/main.rs#L174 and the one two lines down solve a few issues, and probably want to take https://github.com/rust-bitcoin/rust-lightning/pull/263 though I plan on merging that today, so upstream/master may be good enough 11:12 < BlueMatt> 263 solves a case of closure not actually working properly 11:12 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 11:12 < BlueMatt> though the channel closure spec right now is like 150% busted af and impossible to implement right 11:13 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 11:13 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 11:52 < sgeisler> andytoshi: BlueMatt: I just noticed that the constants repo hasn't travis enabled, could one of you have a look at that please? (I don't have the rights for that) 11:53 < BlueMatt> fixed 11:53 < sgeisler> thx :) 11:53 < BlueMatt> it should run on the next push, I think 11:54 < BlueMatt> also custom run https://travis-ci.org/rust-bitcoin/constants/builds/466168870 11:57 < andytoshi> i guess someone could PR to add the "build passing" icons to the README and that'd trigger a run as well 11:57 < andytoshi> i may be able to do that in an huor 11:58 < andytoshi> oh, or we could merge #4 11:58 < BlueMatt> are we in some rush to get a little green checkmark? :p 12:01 < andytoshi> lol, no, just in a rush to do this before i totally forget about it :P 12:01 < andytoshi> but i guess it's all set in motion now 12:02 < BlueMatt> yea, its done 12:11 < sgeisler> andytoshi: due to the same lack of rights (I guess) I cant merge your constants pr #4 12:11 < sgeisler> But I'd say we should merge it due to the broken build on master 12:12 < sgeisler> (casued by not pinning to a git hash) 12:12 < andytoshi> kk, i'll merge it 12:12 < BlueMatt> ugh, well lets fix the access.... 12:13 < andytoshi> sure, one sec, i need to find my keys 12:13 < BlueMatt> I've got it 12:13 < BlueMatt> sec 12:13 < andytoshi> thx 12:13 < BlueMatt> just making sure I'm doing the right thing 12:13 < BlueMatt> sgeisler: should work now? 12:14 < andytoshi> i already merged it, sorry 12:14 < BlueMatt> lol 12:14 < sgeisler> Yes, it shows me merge buttons 12:14 < sgeisler> (for other PRs that need a rebase now) 12:15 < BlueMatt> someone should do a pass over all the new repos to make sure the master branch is review-protected 12:15 < BlueMatt> i guess i can do that 12:15 < BlueMatt> just need it for constants/bitcoin_hashes/rust-bitcoin/rust-secp, right? do we want it on bech32/bech32-bitcoin? 12:15 < BlueMatt> I guess should ask clark if he wants it 12:17 < BlueMatt> oh, hashes has it 12:17 < BlueMatt> ok, tell me if I broke constants 12:18 < BlueMatt> I think travis may need kicking 12:20 < andytoshi> looks all green at https://travis-ci.org/rust-bitcoin/constants 12:28 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-buvwyebybtwqpxez] has quit [Quit: Connection closed for inactivity] 12:39 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 12:43 -!- michaels_ [~michaelsd@38.126.31.226] has joined #rust-bitcoin 14:16 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds] 14:20 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #rust-bitcoin 14:49 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection] 15:55 < ariard> BlueMatt: back, will go through 263 comments in few minutes 16:29 < BlueMatt> ariard: cool, thanks, I've got most of 198 rebased on everything and I've added some tests and tweaked a bunch of things...I'll open a pr with the full diff on 0bin or so in a bit 16:30 < BlueMatt> may be like an hour or two, though 17:27 -!- _cryptosignal_me [~John@91.245.74.33] has joined #rust-bitcoin 17:30 < ariard> BlueMatt: ok done with 263, it seems good to me, maybe just clarify one comment or two 17:31 < ariard> will play a bit with rust-lightning-bitcooinrpc, so should be there in the two coming hours 18:01 -!- _cryptosignal_me [~John@91.245.74.33] has quit [Ping timeout: 240 seconds] 18:33 < BlueMatt> ariard: just a random musing, I've noted that I rarely find our trace-level loggings to include enough info when tests fail, so I'm gonna try myself to just add more log_trace!() when I need more logging, which I think is good 18:34 < BlueMatt> log_trace!() after all, implies that you will get a TON of log, so we should make the reality match that expectation :p 19:00 < ariard> Yes I usually add some to debug, but never commit them because I'm often feel bad to annoy with maybe not pertinent from every PoVs log_trace!() 19:15 < ariard> BlueMatt: gonna take some sleep so will review the whole tomorrow :) 19:15 < BlueMatt> k, have a good sleep! :) 19:16 < BlueMatt> when I see an application that has a --debug=trace option, I usually expect to need to use grep to read it :p 21:06 < BlueMatt> ariard: grrrrr, I couldnt quite whip the test suite into shape in time, gotta get some sleep 21:06 < BlueMatt> will finish tomorrow, but I think I've got things to a good-enough-to-merge state 21:06 < BlueMatt> ariard: you can see the commit tree at https://github.com/TheBlueMatt/rust-lightning/commits/2018-12-198-review 21:07 < BlueMatt> there's some reasonable-sized changes there, and a bunch of papercuts, mostly I thought things were fine then started writing tests then found things that I thought were papercuts but actually needed some level of fixing :/ 21:07 < BlueMatt> I'll revisit tomorrow --- Log closed Tue Dec 11 00:00:48 2018