--- Log opened Thu Dec 20 00:00:57 2018
00:42 < dongcarl> BlueMatt: If you can't wait for wasm: https://github.com/dongcarl/rust-bitcoin/tree/2018-12-draft-integrate-bitcoin-hashes
03:05 -!- TamasBlummer [~Thunderbi@p200300DD67243B93C033DFEDDAC597B1.dip0.t-ipconnect.de] has joined #rust-bitcoin
08:01 < BlueMatt> dongcarl: heh, no, I have a few other projects cooking I can work on
08:31 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin
09:19 < BlueMatt> holy shit, rustup uses trunk versions of llvm on "stable" rustc?
09:19 < BlueMatt> no wonder I dont use fucking rustup, thats crazy
09:37 < dpc> BlueMatt: For what exactly? You mean the `rustup` binary was compiled with trunk llvm (nightly Rust?)?
10:16 < BlueMatt> dpc: the "official" rustc binaries that ships via rustup are built static-linked against trump llvm
10:16 < BlueMatt> release rustc, not nightly rustc
10:30 < BlueMatt> ariard: did you have anything you wanted me to change before taking 275? I'm happy to try to split up the tests into more files or name them differently, but I dont really want to hold it on something like adding more comments to all the tests I'm just moving
11:28 < ariard> BlueMatt: well go ahead, personnally I'm fine with how 275 is, splitting/renaming tests could ease review by other contributors so your call
11:28 < ariard> I will add more comments on my already written tests as part of bolt 5 review
11:28 < BlueMatt> ariard: what do you mean splitting/renaming tests?
11:28 < ariard> channel_monitor_test, channel_manager_test ?
11:28 < ariard> is net_test really meaningful ?
11:29 < BlueMatt> well I can rename it integration_tests
11:29 < BlueMatt> which I guess is more accurate
11:29 < BlueMatt> or functional_tests
11:29 < ariard> I m not sure we have tests covering others things than channel_manager and channel_monitor
11:29 < ariard> sounds good
11:29 < BlueMatt> but splitting more seems like splitting hairs
11:29 < BlueMatt> like, all the manager tests *also* test some monitor stuff
11:29 < ariard> yes, not worth to doing it now
11:29 < BlueMatt> and vica-versa
11:30 < ariard> yes, it's really tied
11:31 < ariard> BlueMatt: it's fine how it is merge it if you're ready
11:31 < BlueMatt> k, I'll rename the file and merge
11:33 < BlueMatt> ariard: fyi I'm currently working on the last check_spend_remote_transaction TODO (the non-revoked-tx-broadcast-full-fail-backwards one)
12:49 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin
18:14 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 244 seconds]
19:35 < ariard> BlueMatt: cool noted, I'm taking some time to get honggfuzz and our current fuzzing framework
19:55 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
19:55 < BlueMatt> ariard: you want HFUZZ_BUILD_ARGS="--features honggfuzz_fuzz" HFUZZ_RUN_ARGS="-n1 --exit_upon_crash" cargo hfuzz run router_target
19:55 < BlueMatt> :p
19:57 < BlueMatt> ariard: and then take any crashing tests and shove them into the test function in the router_target.rs file and run cargo test
21:19 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds]
21:20 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin
23:58 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin
--- Log closed Fri Dec 21 00:00:57 2018