--- Log opened Thu Jan 24 00:00:29 2019
01:44 -!- nothingmuch [~user@62.102.148.160] has joined #rust-bitcoin
04:44 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A381DD9E3AD639E1A96.dip0.t-ipconnect.de] has joined #rust-bitcoin
04:46 -!- TamasBlummer [~Thunderbi@p200300DD672D1A28E151A5C27DD8979D.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
04:46 -!- TamasBlummer1 is now known as TamasBlummer
07:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-mmjnqyiqadqdryrv] has joined #rust-bitcoin
07:27 < andytoshi> TamasBlummer: sure, i'm happy to change the copyright headers to give a more accurate list of authors
07:27 < andytoshi> or remove the headers entirely
07:30 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
07:31 -!- michaels_ [~michaelsd@38.126.31.226] has joined #rust-bitcoin
07:34 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 240 seconds]
09:24 < TamasBlummer> andytoshi: BlueMatt is right git log is a good enough record.
09:44 < TamasBlummer> BlueMatt: would you please publish a lightning with bitcoin 0.16 to crates.io
09:44 < BlueMatt> TamasBlummer: see 0.0.8 tagged things on rust-lightning, I'm trying to get it done in the coming day or three
09:45 < dongcarl> Carl's review beg of the day: https://github.com/rust-bitcoin/rust-bitcoin/pull/215
09:45 < dongcarl> This PR removes our dependency on rust-crypto and remves the fuzz_util module in favor of integrating fully with bitcoin_hashes. (+182 −784) (net: -602)
10:17 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
10:19 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Ping timeout: 240 seconds]
10:33 < stevenroose> btw, gwillen hal can do psbt editing since last weekend. Can basically set any field. So one small last thing that I noticed is missing is creating a PSBT from an unsigned(/partially signed?) tx so that you can use `hal tx encode` to craft a tx from JS, then `hal psbt create` to create the PSBT and then hand out pieces, and `hal psbt merge` them together
11:05 -!- michaels_ [~michaelsd@38.126.31.226] has joined #rust-bitcoin
11:09 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 245 seconds]
11:11 < dongcarl> `hal`?
11:21 < sgeisler> https://github.com/stevenroose/hal/
11:22 < sgeisler> Named after Hal Finney as I found out, not "I'm sorry, Dave. I'm afraid I can't do that."
11:25 < sgeisler> stevenroose: thinking about it, that should be the default error message if a user uses wrong arguments ^^
11:31 < dongcarl> sick!
11:31 < dongcarl> I like it
11:32 < instagibbs> the hal hd derivation stuff works, at least, I can attest :P
11:35 < stevenroose> hmm, had a brief internet outage and my bouncers only redumps other ppls messages, so I can't tell if mine actually arrived.. I said something about not using structopt to keep commands modularized (sgeisler) and about exploiting the hal name collision for humorous purposes to be a fun idea
11:37 < dongcarl> stevenroose: This `hal` thing is really making me want to get PSBT thru
11:38 < dongcarl> I've had a read over your key PRs and I could see why you'd want to do it that way
11:39 < dongcarl> What do you say to this: let's merge my changes first since it's had quite a bit of review
11:39 < dongcarl> This way I can get back to working on PSBT
11:40 < dongcarl> Then we can look at the changes you want (and thanks for breaking it out into a few different PRs), and discuss/review those
11:40 < dongcarl> stevenroose: Does that sound like a deal?
12:23 < BlueMatt> dongcarl: https://travis-ci.org/TheBlueMatt/rust-secp256k1/jobs/484059044 !
12:23 < BlueMatt> (scroll to bottom)
12:37 < dongcarl> Noice
13:18 < BlueMatt> dongcarl: 215 looks good, but you aren't "deprecating" something if you're removing it.....
13:19 < dongcarl> Yes yes fine
13:29 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 252 seconds]
13:57 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-mmjnqyiqadqdryrv] has quit [Quit: Connection closed for inactivity]
14:46 -!- molz [~molly@unaffiliated/molly] has joined #rust-bitcoin
15:17 < stevenroose> dongcarl: in all fairness, the util::key PR and the only-secp-keys PR are quite orthogonal to each other :p
15:17 < stevenroose> and I'd be very glad to just port the PSBT stuff over to secp keys, I don't think that's much work
15:17 < stevenroose> But yeah anything that gets PSBT merged, really
15:18 < stevenroose> I have a ton of things depending on that all using my own devel branch of rust-bitcoin
15:27 < stevenroose> dongcarl: it looks like PSBT is using just secp keys anyway..
15:27 < dongcarl> Yeah I have yet to rebase on my key module
15:27 < dongcarl> It needs my key module so that it encapsulates compresses was
15:27 < dongcarl> Compressed-ness
15:28 < dongcarl> andytoshi found that roundtripping didn’t work for PSBT because we didn’t encapsulate compressedness
15:28 < stevenroose> hmm, makes sense
15:29 < dongcarl> I’ll rebase my PSBT over keys tomorrow
15:29 < stevenroose> cool
15:30 < dongcarl> Lmk if I’m still missing any PSBT functionality you’ve fixed in ur revel branch
15:30 < dongcarl> Devel*
15:31 < stevenroose> yeah the compressedness issue is bothering me a lot :D but it seems we can't ignore it
15:31 < dongcarl> Sadly no lol
15:31 < stevenroose> so yeah get keys merged and then we can celebrate PSBT after > 6 months :)
15:31 < dongcarl> Hahahahaha
15:32 < dongcarl> Ikr
15:32 < dongcarl> Fingers crossed I don’t come across some other issues while rebasing tmr lol
15:33 < stevenroose> dongcarl: off to bed myself, just checked, diff between your psbt and my devel branch is only formatting
15:34 < dongcarl> stevenroose: Thanks for checking :-)
16:03 < andytoshi> unfortunately tomorrow and saturday look like they'll be crypto days; i'll try to switch back to rust on sunday but i'll be travelling and need to prepare a grincon talk for monday. (though i'm speaking in the morning so probably i'll have the rest of the day to code). I'm also excited to get PSBT in
17:03 < BlueMatt> sgeisler: do you want to cut a release of rust-lightning-invoice with secp0.12?
17:05 < sgeisler> I can do that if you want.
17:06 < BlueMatt> yea, no rush, was just going to look at bumping things for new rust-lightning that I plan on cutting tomorrow and realized I had differing secp versions between rust-lightning:master and -invoice
17:09 < sgeisler> do you depend on bitcoin_hashes?
17:09 < sgeisler> If so I could include the 0.1.0 -> 0.3.0 bump if needed.
17:13 < BlueMatt> yea, I do now
17:13 < BlueMatt> oh we have an 0.3?
17:13 < BlueMatt> oh, right, for rust-bitcoin
17:13 < BlueMatt> yea, I need to bump to 0.3 too
17:16 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection]
17:51 < sgeisler> BlueMatt: just released 0.2.0 with bitcoin_hashes 0.3 and secp 0.12
17:52 < BlueMatt> thanks!
18:07 < BlueMatt> ariard: I'm confused, whats your point at https://github.com/rust-bitcoin/rust-lightning/pull/295#issuecomment-457425993 ?
18:20 < ariard> BlueMatt: don't get first reference to "holding cells" currently we never refuse to add thing to holding_cell_htlc_updates
18:21 < ariard> L3185 channel.rs, the TODO is about having a limit for holding_cell_htlc_updates ?
18:21 < BlueMatt> what does the line say? I have a different line
18:22 < ariard>  Check the limits *including* other pending holding cell HTLCs!
18:22 < ariard> im on 9e31403
18:24 < BlueMatt> oh, right, can remove that =D
18:24 < BlueMatt> ariard: ok, wait, and whats wrong with the error message?
18:24 < BlueMatt> looks right to me?
18:25 < BlueMatt> (my comment applied to reserves/value in flight/etc, not just one)
18:25 < ariard> for me its "their max HTLC value in flight"
18:26 < ariard> because there we respect policy impose to us by peer
18:26 < ariard> at least if I get bolt2 right
18:26 < BlueMatt> yea, but its the part of the HTLCs that we control :p
18:26 < BlueMatt> I mean all the naming shit is confused af
18:27 < BlueMatt> how about I just drop "our"
18:27 < BlueMatt> then its right :p
18:27 < BlueMatt> (and its clear cause it says "Send")
18:27 < ariard> wait just opening bolt2
18:28 < ariard> if a sending node adds more than its max_accepted_htlcs HTLCs to its local commitment transaction, OR adds more than its max_htlc_value_in_flight_msat worth of offered HTLCs to its local commitment transaction:
18:28 < ariard> SHOULD fail the channel
18:28 < ariard> its design sending or receiceving there ?
18:29 < BlueMatt> I find the BOLT terminology confusing af too, fwiw
18:29 < ariard> so just drop the our for now and will open an issue on rfcs
18:30 < ariard> (have a nit on bolt3 to do btw)
18:31 < BlueMatt> alright, I dropped the "our" and added the extra log you asked for
18:31 < BlueMatt> can I merge 295? :p
18:31 < ariard> yes go ahead
18:32 < ariard> what is remaining on 0.0.8 stuff ?
18:32 < BlueMatt> =D
18:32 < BlueMatt> just 297 and 290
18:32 < BlueMatt> and I want to bump bitcoin_hashes but that should be 0 effort
18:34 < ariard> cool, day by day we're getting closer to 0.1 :)
18:37 < BlueMatt> getting there
18:37 < BlueMatt> :)
19:30 < BlueMatt> ariard: let me know about 290
19:30 < BlueMatt> then 0.0.8 should be good :)
23:02 < sgeisler> I accidentally pointed rust-lightning-bitcoinrpc to a bitcoin mainnet node: thread 'main' panicked at 'LOL, you're insane', src/main.rs:352:3 :D
--- Log closed Fri Jan 25 00:00:30 2019