--- Log opened Fri Jan 25 00:00:30 2019
01:42 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Remote host closed the connection]
04:41 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A30C972B83164E3E989.dip0.t-ipconnect.de] has joined #rust-bitcoin
04:41 < stevenroose> sgeisler: "accidentally" ;)
04:43 -!- TamasBlummer [~Thunderbi@p200300DD672D1A381DD9E3AD639E1A96.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
04:43 -!- TamasBlummer1 is now known as TamasBlummer
05:44 < ariard> BlueMatt: answered back on 290! good to me
07:45 < dongcarl> andytoshi: Good luck! Seems like you've got a lot on your plate :-)
07:48 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
09:00 < BlueMatt> sgeisler: damn good thing I added that panic :p
09:07 < BlueMatt> dongcarl: (or ariard) if one of y'all is around to ack https://github.com/rust-bitcoin/rust-lightning/pull/303 I'll take that before bumping the version, otherwise I'll just bump
09:08 < dongcarl> BlueMatt: Ah! I know how logging works at least! :p
10:06 < dongcarl> Hi all, please make sure that you use `write_all` when you mean to write the entire buffer. I've seen this mistake too many times across repos.
10:06 < BlueMatt> yea, I'm increasingly concerned that we may have screwed up requiring that in bitcoin_hashes
10:06 < BlueMatt> easy to blame the user, but I think we may want to consider reverting that
10:06 < BlueMatt> before it bites us in the ass
10:08 < dongcarl> BlueMatt: I'm not as concerned about that... `cargo clippy` will tell the user about mistakes like this, I just want to make sure we use it right internally
10:08 < dongcarl> In fact, this is an error in `cargo clippy`, not a warning
10:09 < BlueMatt> clippy warns you when you call write() every time? that seems...like weird behavior
10:09 < BlueMatt> sometimes you want write
10:09 < dongcarl> BlueMatt: It errors when you use `write()` but don't use the resulting usize
10:10 < dongcarl> cuz `write()` tells you how many bytes were written
10:10 < dongcarl> I think that's pretty reasonable :p
10:10 < BlueMatt> ah, ok, right
10:10 < BlueMatt> I mean not everyone runs clippy
10:10 < BlueMatt> and there is ~0 cost to us just always writing all in write()
10:11 < BlueMatt> if anything it removes some in-loop error checking that write_all() has to do, which could improve perf, though I'd be somewhat surprised
10:12 < dongcarl> I'm gunna leave it be until someone complains, feel free to PR tho
10:13 < BlueMatt> heh, I'll get to it in 6 months
10:23 < BlueMatt> TamasBlummer: uploading rust-lightning 0.0.8 now with bitcoin_hashes 0.3, secp 0.12 and bitcoin 0.16 :)
10:23 < BlueMatt> and there it is :) https://crates.io/crates/lightning
11:11 < dongcarl> Carl's review beg of the day: https://github.com/rust-bitcoin/rust-bitcoin/pull/183
14:09 < BlueMatt> pushed a bump of rust-lightning-bitcoinrpc so folks can try the latest rust-lightning from today :)
15:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
18:35 < ariard> BlueMatt: rebased and updated a good chunk on 292 (msgs serialization tests), currently somewhere 65% msgs covered, hope to finish this we, would welcome a high-level review on hardening
18:54 < BlueMatt> ariard: looks super thourough, thanks! dont think it needs to be as thourough as you're making it, but definitely looks good
18:54 < BlueMatt> ariard: if I had one request it'd be to replace the vec![bytes] syntax with a hex::decode("...").unwrap()[..]
18:54 < BlueMatt> so that its more readable
18:55  * BlueMatt is gonna be travelling for probably the next two weeks, so things will be intermittent, but I should be available to answer questions and do review passes, just at rather random times
--- Log closed Sat Jan 26 00:00:31 2019