--- Log opened Thu Feb 14 00:00:50 2019 02:47 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tkiubtfzhrrrgiqm] has joined #rust-bitcoin 03:30 < stevenroose> dongcarl: you working on rebasing PSBT? 03:30 < stevenroose> I could do it for you if you want, I'm quite familiar with the impl tbh 03:37 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin 04:12 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A9269E448033513F08F.dip0.t-ipconnect.de] has joined #rust-bitcoin 04:14 -!- TamasBlummer [~Thunderbi@p200300DD672D1A90006BD2EB55C6DDDC.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 04:14 -!- TamasBlummer1 is now known as TamasBlummer 05:05 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tkiubtfzhrrrgiqm] has quit [] 05:39 < stevenroose> sgeisler and others: is there a reason why rust-lighting-invoice doesn't depend on rust-bitcoin? 05:40 < stevenroose> I really don't like the awkward Fallback enum type that is basically a bitcoin::Address::Payload clone 05:40 < stevenroose> Wanted to implement either an Into
for the type, or just use the Address type instead 05:50 < stevenroose> Also: why are the bech32::u5 and bitcoin_bech32::u5 not convertable? 05:50 < andytoshi> oops, one should re-export the other probably 05:51 < andytoshi> i know i wasn't familiar with re-exporting types several months ago, maybe clark wasn't either 05:51 < stevenroose> Ah it's a pub use.. Then I must have conflicting versions going on. 05:54 < stevenroose> bitcoin_bech32 uses bech32 0.5.0 and lightning_invoice uses bech32 0.6.0 :/ 05:57 < stevenroose> And lightning-invoice fails a unit test when using 0.5.0 05:57 < stevenroose> Can I update the bech32 version of bitcoin_bech32 then to 0.6.0? 05:59 < andytoshi> if you also bump the major version of bitcoin_bech32 05:59 < stevenroose> https://github.com/rust-bitcoin/rust-bech32-bitcoin/pull/20 05:59 < andytoshi> unbreaking lightning is a breaking change :) 06:12 < stevenroose> I wrote an ugly manual converter now :/ 06:18 < stevenroose> sgeisler: so this is what I'd like to avoid with having Address support in lightning-invoice: https://github.com/stevenroose/hal/blob/master/src/lightning.rs#L69-L92 06:19 < stevenroose> FWIW: hal supports decoding lightning invoices! 06:47 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #rust-bitcoin 09:27 < sgeisler> stevenroose: the conversion between rust-bitcoin's payload/address type should be included in lighting-invoice, feel free to PR 09:27 < sgeisler> The feature isn't really used so it wasn't a priority for me 09:30 < sgeisler> Unfortunately the payload type supports more variants than the lighting spec, so using it instead would have meant more error cases etc. 09:32 < sgeisler> But lighting to bitcoin conversion should always work 09:33 < sgeisler> At least the lighting p2sh byte arrays should be replaced with hash types 10:49 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Remote host closed the connection] 10:55 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 10:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection] 10:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 14:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer] 14:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 14:45 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection] 15:22 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 15:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds] 16:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 16:20 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds] 16:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 16:40 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin 16:44 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds] 16:44 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 16:44 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Read error: Connection reset by peer] 16:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: No route to host] 16:49 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 16:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 258 seconds] 16:55 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 16:57 < ariard> BlueMatt: will be afk for a week, #305 is ready (just need to fix full_stack_target), after that I think BOLT 5 is done. Will focus on reviewing its specs when back 17:00 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds] 18:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 19:03 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds] 21:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 21:51 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 258 seconds] 23:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin --- Log closed Fri Feb 15 00:00:50 2019