--- Log opened Mon Feb 25 00:00:59 2019
00:21 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hrwoilqvmdjlfdfw] has joined #rust-bitcoin
01:11 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 258 seconds]
01:13 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin
01:20 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 246 seconds]
01:22 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin
03:55 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A841DAA84F3733E24A2.dip0.t-ipconnect.de] has joined #rust-bitcoin
03:57 -!- TamasBlummer [~Thunderbi@p200300DD672D1A93F88A16421C2963D1.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
03:57 -!- TamasBlummer1 is now known as TamasBlummer
03:58 -!- nothingmuch [~user@5.22.134.188] has joined #rust-bitcoin
04:05 -!- nothingmuch [~user@5.22.134.188] has quit [Read error: Connection reset by peer]
04:11 -!- nothingmuch [~user@5.22.134.188] has joined #rust-bitcoin
04:13 -!- nothingmuch [~user@5.22.134.188] has quit [Read error: Connection reset by peer]
04:16 -!- nothingmuch [~user@5.22.134.188] has joined #rust-bitcoin
06:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
06:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
07:38 -!- icota [~igor@141-136-128-148.dsl.iskon.hr] has quit [Quit: Konversation terminated!]
07:38 -!- icota [~igor@141-136-128-148.dsl.iskon.hr] has joined #rust-bitcoin
07:59 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 250 seconds]
08:07 < stevenroose> sgeisler: somehow the lightning_invoice types are quite hard to use for the c-lightning api
08:26 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #rust-bitcoin
08:32 -!- nothingmuch [~user@5.22.134.188] has quit [Read error: Connection reset by peer]
08:49 < stevenroose> so apparently the bitcoin create doesn't have hex parsing functionality anymore
08:49 < stevenroose> and bitcoin_hashes implemented it's own hex stuff
08:49 < stevenroose> :/
08:50 < stevenroose> Personally I don't see what's wrong with relaying on the hex crate for that. So that at least we have the same implementation in all crates. Which also means the same error values etc.
08:51 < stevenroose> I'm adding serde serializatoin for PublicKey (it's used in Lightning RPC messages), but I'd have to add a hex parses again.
08:55 < stevenroose> And I think (since it's using the Serializer::serialize_bytes method), secp256k1's serde implementation will serialize as base64..
08:57 < andytoshi> stevenroose: i am PO'd at the rust developers for refusing to include hex parsing in the stdlib for years
08:57 < andytoshi> and am not going to respond to it by adding yet another dependency for 10-15 lines of code
08:57 < andytoshi> it's much easier to maintain that code ourselves directly
08:58 < andytoshi> i'm happy to hear that rust-bitcoin no longer has hex parsing ... at one point it had like 4 separate implementations. i figured it was better to move this to the hashes crate since that's where hex is most often needed
08:59 < andytoshi> if we want the same implementation across crates we can use the one in bitcoin_hashes; that's why it's there
09:00 < stevenroose> andytoshi: hmm, so we should use that one?
09:00 < andytoshi> yeah
09:01 < stevenroose> Yeah I never got why the fmt::ToLowerHex and fmt::ToUpperHex are not defined on Vec<u8>. It's kinda the only type it makes sense to have it for
09:01 < andytoshi> i think rust-lightning will need to depend on bitcoin_hashes anyway
09:01 < stevenroose> well, or &[u8] for that matter
09:01 < andytoshi> yeah, right??
09:01 < andytoshi> it's because the rust developers are out of touch elites
09:01 < stevenroose> and maybe a convert::FromHex or something and it's done.
09:01 < andytoshi> "dealing with bytestrings is a niche application" they told me
09:01 < stevenroose> Have there been PRs to do that?
09:01 < andytoshi> my understanding is that they don't use computers
09:02 < andytoshi> i made a few in 2014
09:02 < andytoshi> then gave up
09:02 < stevenroose> > my understanding is that they don't use computers
09:02 < stevenroose> :'D
09:04 < andytoshi> :P
10:35 < dongcarl> stevenroose: Confused about ur comment here: https://github.com/rust-bitcoin/rust-bitcoin/pull/103#discussion_r259956857
10:37 < stevenroose> dongcarl: yeah segwit confuses me too, I may be wrong
10:38 < stevenroose> But because the output you're spending doesn't use segwit, doesn't mean that the tx itself doesn't have witnesses that may for some reason be relevant. Was the point.
10:39 < stevenroose> I can't think of why they would be relevant. AFAIK, that non_witness_utxo is only used to calculate the previous txid (which doesn't need witnesses) and check the output value
10:40 < stevenroose> But imagine if someone is ever interested in the wtxid of that tx, they wouldn't be able to calculate it
10:41 < dongcarl> So... We want manual for the Global unsigned, but normal for this one?
10:43 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
10:45 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
10:50 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
10:57 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
11:09 < dongcarl> Anyone know why `Hash` isn't implemented for SecretKey but is implemented for PublicKey in rust-secp256k1? andytoshi? real_or_random?
12:10 < andytoshi> dongcarl: probably just an oversight
12:11 < andytoshi> and correct, manual for Global unsigned, normal for the non_witness_utxo field - and stevenroose is correct that this is kinda silly
12:11 < andytoshi> on the plane from FC19 I went back and forth on this several times before i figured it out
12:29 < dongcarl> Sounds good
12:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
12:55 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
13:00 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds]
13:01 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
13:01 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
13:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
13:03 < dongcarl> andytoshi: Are you seeing the convo on #bitcoin-core-dev?
13:17 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hrwoilqvmdjlfdfw] has quit [Quit: Connection closed for inactivity]
13:45 < gwillen> win goto #bitcoin-core-dev
13:45 < gwillen> (oops)
13:58 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
13:58 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
13:59 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
14:04 < BlueMatt> andytoshi: Jan@slushpool was asking about schnorr in libsecp-rust
14:16 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
14:21 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
14:42 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:02 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
15:07 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
15:12 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
15:25 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
15:59 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
16:04 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
16:53 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
16:57 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
16:58 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
17:02 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 255 seconds]
17:12 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
18:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
18:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
18:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
18:59 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
19:37 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
19:42 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds]
21:03 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
21:07 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds]
21:32 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
21:37 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
23:33 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
23:38 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds]
--- Log closed Tue Feb 26 00:00:01 2019