--- Log opened Thu Feb 28 00:00:02 2019
01:31 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
01:36 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
01:44 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
01:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds]
02:32 -!- john__ [72549fbd@gateway/web/freenode/ip.114.84.159.189] has quit [Ping timeout: 256 seconds]
03:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
04:32 < stevenroose> oh, missed this, checking
04:37 < stevenroose> k, done, minor diff
04:41 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ucrjjqhpwoltfjco] has joined #rust-bitcoin
06:38 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
06:38 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
06:38 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
06:50 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
06:51 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
06:51 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
06:51 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
06:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds]
07:27 < andytoshi> dope. merged
07:41 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
07:41 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
07:42 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
07:42 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
07:42 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
08:02 < dongcarl> andytoshi stevenroose : ping https://github.com/rust-bitcoin/rust-bitcoin/pull/103#issuecomment-468328723
08:07 < andytoshi> dongcarl: sgtm
08:17 < andytoshi> dongcarl: looks like one of the if statements you suggested to remove is still there?
08:17 < andytoshi> oh, all of them actually in the input `get_pairs` function
08:17 < dongcarl> just pushed
08:17 < dongcarl> was testing locally
08:20 < andytoshi> nice
08:20 < andytoshi> got it
08:45 < andytoshi> haha omg .. our key-parsing code interprets hybrid keys as uncompressed ones
08:45 < andytoshi> and fails to reserialize them
08:45 < andytoshi> well, doesn't fail, it just changes them from hybrid into uncompressed
08:47 < andytoshi> dongcarl: ack from me
08:48 < dongcarl> woo hoo
08:50 < andytoshi> this public key thing is really annoying..
08:50 < andytoshi> public keys can be hybrid but private keys cannot
08:50 < andytoshi> yet another insane/arbitrary difference in these types we can thank satoshi for..
09:04 < dongcarl> *in the tone of "thanks obama"* THANKS SATOSHI
09:05 < dongcarl> So it looks like PSBT is ready to merge after the nightly job finishes
09:20 < andytoshi> merged.
09:21 < andytoshi> thank you for your first contribution to rust-bitcoin. we hope to see you around in future
10:01 < dongcarl> rofl
10:02 < andytoshi> later today i'll make a PR to release a new major version
10:02 < andytoshi> of rust-bitcoin
10:02 < andytoshi> is there anything else that we ought to do before then?
10:14 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ucrjjqhpwoltfjco] has quit [Quit: Connection closed for inactivity]
11:06 -!- harding [~quassel@li1258-130.members.linode.com] has quit [Ping timeout: 240 seconds]
11:08 -!- harding [~quassel@li1258-130.members.linode.com] has joined #rust-bitcoin
12:24 < dongcarl> andytoshi: I don't think so...
12:36 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
13:11 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
13:51 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
13:51 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
13:51 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
13:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
14:02 < andytoshi> whew, there is actually a lot in this release..
14:03 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/239
14:16 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
14:21 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds]
14:22 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 245 seconds]
14:44 < andytoshi> hmm i'm surprised that dongcarl is not an "approving reviewer" for rust-bitcoin
14:44 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
14:44 < andytoshi> you're part of the org..
14:44 < andytoshi> you have "write" access to the repo
14:45 < andytoshi> oh, no, i'm just confused about github's interface
14:45 < andytoshi> it says "you need 2 reviewers" even if you've already got one
14:49 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
14:49 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #rust-bitcoin
15:26 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
15:30 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
15:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
16:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
16:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
16:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
16:24 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
16:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
16:47 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
17:05 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 245 seconds]
17:07 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin
17:12 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
18:42 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
18:47 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
18:53 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
20:28 -!- TamasBlummer1 [~Thunderbi@p200300DD674483892C22937C5DBDC41B.dip0.t-ipconnect.de] has joined #rust-bitcoin
20:30 -!- TamasBlummer [~Thunderbi@p200300DD67448307003A01CB3B913E74.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20:30 -!- TamasBlummer1 is now known as TamasBlummer
20:43 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
20:49 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
22:44 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
22:49 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
--- Log closed Fri Mar 01 00:00:03 2019