--- Log opened Sun Mar 03 00:00:06 2019 01:38 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 01:43 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds] 02:14 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 02:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds] 02:50 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nphnwowqzmznrhwd] has joined #rust-bitcoin 03:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 03:25 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 04:15 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin 04:15 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host] 04:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 04:19 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds] 04:21 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 04:25 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds] 05:42 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 05:42 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:27 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 272 seconds] 06:51 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 08:05 < elichai2> Just saying, When we'll be able to support Rust version from 1.32 and up `bitcoin_hashes` would truly be dependency less :) (because of https://github.com/rust-lang/rust/issues/52963 ) 09:19 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 245 seconds] 09:21 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nphnwowqzmznrhwd] has quit [] 09:40 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 09:53 -!- elichai2_ [uid212594@gateway/web/irccloud.com/x-emxwamhxnmrymyow] has joined #rust-bitcoin 09:56 -!- elichai2_ is now known as elichai2 09:58 < elichai2> Looking for something in rust-bitcoin/secp etc. I can work on :) 10:37 -!- ariard_ [~ariard@167.99.46.220] has joined #rust-bitcoin 10:39 -!- ariard_ [~ariard@167.99.46.220] has quit [Quit: Lost terminal] 10:39 -!- ariard [~ariard@167.99.46.220] has quit [Quit: Lost terminal] 10:41 -!- ariard [~ariard@167.99.46.220] has joined #rust-bitcoin 10:52 < andytoshi> elichai2: nice :) 10:52 < andytoshi> dongcarl: the bip143 module has a segwit signature hash 10:53 < andytoshi> and yes, my fix is essentially the same as what you did for #29, except that i'm doing the non-human-readable version of it 11:09 < elichai2> andytoshi: maybe I'll implement cleanup for secrets using Drop and write_volatile? (to clear the memory when they're dropped) 11:48 < andytoshi> elichai2: secrets are Copy 11:48 < andytoshi> if you impl Drop they'll stop being Copy .. which I -think- would be really annoying 11:48 < andytoshi> maybe not, maybe that's what we want to do 11:49 < andytoshi> but also, it won't be much of a protection because the actual bytes will still get copied in a ton of places 11:49 < elichai2> Yeah, why is that? You think it's necessary for them to be copy? I think it's bad practice for them to be copied around everywhere 11:50 < elichai2> Hmm you're right about that. But as long as rust-secp library accept secrets only by reference then if the user will do the same too it won't be moved and hence won't be copied around in memory 11:50 < andytoshi> heh "if the user will do the same" 11:51 < andytoshi> it's probably faster to do a 32-byte copy than to do a pointer dereferenc 11:51 < elichai2> That's until I can figure out the correct use of Pin lol (although it would take some time until this library will support this rust version) 11:51 < andytoshi> i don't think Pin will work for us, i spent a while on #rust asking about this 11:51 < andytoshi> but maybe i'm wrong 11:51 < elichai2> Yeah I get what you're saying, the other option is boxing which isn't possible without std 11:51 < andytoshi> right 11:51 < andytoshi> i think actually you can't Pin things that are supposed to live on the stack 11:51 < elichai2> Hmm yeah I'm still trying to figure out Pin and if it can help somehow 11:53 < elichai2> I have my own crypto api that wraps right now around ring libsexp256k1-rs which I want to replace with this lib after it will be no-std compatible 11:54 < elichai2> So it seems that both options require the users of the lib to use them correctly and smartly so I'm not sure my PR is any help 11:55 < elichai2> I can write_volatile on drop the structs on my end and box them to try and prevent moving 12:14 < gwillen> how critical is performance at the user-library boundary 12:14 < gwillen> you could always keep the secrets in a hashmap and hang out UUID handles or something. 12:15 < gwillen> then nothing fancy is required to have control over copying :-) 12:33 < elichai2> gwillen: if you're using a hasmmap you need to at least have liballoc to allocate memory, and if that's the case then you can Box it 12:57 < andytoshi> stevenroose: so, my plan for PSBT+miniscript is to add a PSBT combiner, finalizer and extractor to rust-miniscript 12:57 < andytoshi> maybe not a combiner, there's already one in rust-bitcoin (through carl's `merge` function), but i might experiment with the API 12:57 < andytoshi> in parallel i'll change the functionary code in liquid to use it, and use that to guide my API decisions 12:57 < andytoshi> and once that's done we can reassess how/how much we want to pull from there into rust-bitcoin 16:56 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 17:07 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/241 needed for miniscript compatibility 17:30 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-emxwamhxnmrymyow] has quit [Quit: Connection closed for inactivity] 18:34 < ariard> andytoshi: had a look on rust-miniscript, I wrote a really basic ivy frontend sometimes ago, was mostly to learn rust 18:35 < ariard> was wandering if it would make sense to have an ivy compiler, using miniscript ast and output PSBT 18:37 < ariard> because, as far as I understand, Policy is also a higher-level language, but doesn't seems to me really human-friendly and more for machine-to-machine communication 19:16 -!- kallewoof_ is now known as kallewoof 20:24 -!- TamasBlummer1 [~Thunderbi@p200300DD6744836125C327E25BCC31D9.dip0.t-ipconnect.de] has joined #rust-bitcoin 20:27 -!- TamasBlummer [~Thunderbi@p200300DD67448369294D75658BC2D653.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 20:27 -!- TamasBlummer1 is now known as TamasBlummer 22:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Mon Mar 04 00:00:06 2019