--- Log opened Wed Mar 27 00:00:27 2019 01:52 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D106506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin 01:54 -!- TamasBlummer [~Thunderbi@p200300DD670F9D186506B7C4D522E0CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 01:54 -!- TamasBlummer1 is now known as TamasBlummer 02:01 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 02:05 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 268 seconds] 03:23 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 03:54 < stevenroose> sgeisler, andytoshi: updated the strason PR 04:26 < stevenroose> k travis fuzzing seems to have an issue, on it 06:03 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 06:07 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 245 seconds] 06:56 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:27 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:27 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 07:32 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 245 seconds] 07:48 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:48 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:49 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:53 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds] 08:28 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 08:29 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 08:29 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:24 -!- albert [47c698aa@gateway/web/freenode/ip.71.198.152.170] has joined #rust-bitcoin 10:29 -!- albert [47c698aa@gateway/web/freenode/ip.71.198.152.170] has quit [Client Quit] 10:30 -!- mlerner [uid356390@gateway/web/irccloud.com/x-psgveavixrrydegn] has joined #rust-bitcoin 10:33 < mlerner> hey all. I am interested in contributing to rust bitcoin, but unclear where to start / what would be the most helpful. I'm happy to help with test coverage if that would be useful 10:43 < sgeisler> Hi, welcome to rust-bitcoin :) if you want to get to know the library a bit better @stevenroose's hal tool might be a good starting point. https://github.com/stevenroose/hal/ 10:44 < sgeisler> It exposes rust-bitcoin functionality as a CLI app and is quite easy to understand. 10:45 < sgeisler> Since it's still missing some functionality that might be a good start: identify missing functions, look how to implement them using rust-bitcoin, propose fixes for usability issues/missing functionality. 10:46 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 10:50 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:51 < sgeisler> Another interesting project would be implementing output selection and supporting functionality around the already existing PSBT data structures. @dongcarl can probably tell you more about that. 10:57 < dongcarl> Yeah coin selection would be excellent 10:57 < dongcarl> mlerner: Here's some good background http://diyhpl.us/wiki/transcripts/scalingbitcoin/tokyo-2018/edgedevplusplus/coin-selection/ 10:58 < sgeisler> murch also wrote his master thesis about it: http://murch.one/wp-content/uploads/2016/11/erhardt2016coinselection.pdf 11:19 < sgeisler> andytoshi, stevenroose: could this function directly return an `ExtendedPrivKey` instead of a `Result<_, _>` https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/bip32.rs#L428 ? 11:20 < sgeisler> The possible errors seem to be of the "after addition of 32 byte value we don't have a valid key anymore" kind 11:21 < sgeisler> which as we decided in https://github.com/rust-bitcoin/rust-bitcoin/pull/247 is improbable enough to ignore 11:34 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:34 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:35 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:36 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:38 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:52 < andytoshi> sgeisler: yep looks like it 11:52 < andytoshi> i think i used a result to avoid having to write unwrap() 11:52 < andytoshi> but i probably should've 12:00 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 12:04 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds] 12:12 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 12:17 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 12:51 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 13:26 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:42 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:43 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:57 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:59 < stevenroose> andytoshi: yeah Results are so ergonomical both as a producer of a method and as a consumer that it's often convenient to just always use them :D 15:00 < stevenroose> I don't know about `add_assign` myself, the `from_slice` call should be safe, yes. 15:01 < stevenroose> I was thinking today that it'd be quite nice to have `impl ToHex for E` that serializes and hexes :D though I think rust-bitcoin still exposes the serialize_hex global function in the encode module 15:51 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:52 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 15:59 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 16:03 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 16:22 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 16:34 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 16:45 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 16:49 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds] 16:51 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 17:23 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 17:24 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 17:28 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 17:28 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 17:34 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 17:35 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 17:35 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 17:36 -!- willpier_ [~willpiers@38.75.231.30] has joined #rust-bitcoin 18:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 18:17 -!- willpier_ [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 18:53 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 19:11 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 19:12 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 19:16 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 245 seconds] 19:16 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 250 seconds] 19:27 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 19:34 < ariard> BlueMatt: still wip but should get you an idea of claim tx tracking : https://github.com/ariard/rust-lightning/compare/2018-12-track-in-flight-preconfirmed-tx...ariard:2019-03-track-htlc-spending-tx 19:44 < BlueMatt> ariard: nice! I didnt do a review, but the data structure looks good 19:44 < BlueMatt> ariard: looking forward to it! 20:04 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 20:04 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 20:08 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds] 20:14 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 21:03 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 21:03 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 21:07 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds] 21:08 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:12 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 22:43 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:48 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 268 seconds] --- Log closed Thu Mar 28 00:00:30 2019