--- Log opened Mon Apr 29 00:00:58 2019
01:05 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D126506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin
01:07 -!- TamasBlummer [~Thunderbi@p200300DD670F9D156506B7C4D522E0CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
01:07 -!- TamasBlummer1 is now known as TamasBlummer
01:08 < stevenroose> K I fixed a compilation issue with fuzztarget. Both PRs should be good to go now.
01:23 < stevenroose> andytoshi: the only error case for fast_merkle_root is when the input slices are not length 32. This propagates to all the AssetId functions returning Result<T, bitcoin_hashes::Error>. I'm a little tempted to have fast_merkle_root panic on non-length-32 input.
01:48 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kmuwegoznfdvdxth] has joined #rust-bitcoin
02:55 -!- ccdle12 [~ccdle12@p116127-ipngn200301takamatu.kagawa.ocn.ne.jp] has quit [Remote host closed the connection]
03:55 -!- ccdle12 [~ccdle12@p116127-ipngn200301takamatu.kagawa.ocn.ne.jp] has joined #rust-bitcoin
05:31 < andytoshi> stevenroose: yeah i think that's acceptable
05:32 < andytoshi> well
05:32 < andytoshi> can it take sha256d::Hash as input rather than byte slices? or [u8; 32] ?
05:41 -!- ccdle12 [~ccdle12@p116127-ipngn200301takamatu.kagawa.ocn.ne.jp] has quit [Remote host closed the connection]
05:47 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
05:51 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin
05:52 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 246 seconds]
05:54 -!- ccdle12 [~ccdle12@p116127-ipngn200301takamatu.kagawa.ocn.ne.jp] has joined #rust-bitcoin
06:36 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 258 seconds]
06:37 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #rust-bitcoin
06:46 < stevenroose> Well, it's a merkle root. One would argue that a merkle root should take as inputs the same types that it outputs. So then it would be Midstate. Which I could live with. [u8; 32] is really too unergonomic for general purpose users. sha256d::Hash is random.
06:47 < stevenroose> I just realize something. Does sha256d::Hash::from_hex("0x00...01") give you the same as sha256d::Hash::from_inner([0,0...,1])? Or is from_slice not reversed?
06:51 -!- mauz555 [~mauz555@80.215.85.196] has joined #rust-bitcoin
07:04 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
07:32 -!- mauz555 [~mauz555@80.215.85.196] has quit []
07:46 -!- neonknight646 is now known as neonknight64
07:47 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
07:53 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin
08:10 < andytoshi> [u8; 32] comes from `.to_inner` on every usable hash type and Midstate..
08:10 < andytoshi> and general purpose users should not be using midstates!
08:11 < andytoshi> i wouldn't mind it taking midstate as input though
08:11 < andytoshi> from_slice is definitely not reversed
08:11 < andytoshi> the only thing that is ever reversed is hex encoding
08:23 -!- ccdle12 [~ccdle12@p116127-ipngn200301takamatu.kagawa.ocn.ne.jp] has quit [Remote host closed the connection]
08:26 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
09:13 < stevenroose> Hmm, the entropy -> asset/token_id method works, the entropy calculation doesn't, for some reason. I added unit tests will push once I get them to work.
09:25 < stevenroose> andytoshi: pushed an update to the AssetId PR
09:25 < stevenroose> Now has a unit test example that succeeds, yay!
09:41 < andytoshi> nice
09:41 < andytoshi> where did you get the unit test example?
09:41 < andytoshi> can you pull them from the liquid blockchain and comment a txid? i can get you some transactions if you don't have easy access
09:41 < andytoshi> it makes it easier for me to review
09:47 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
09:55 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
10:52 < stevenroose> ah, I added prints to the functional test
10:52 < stevenroose> I can take a real tx as well, one sec.
10:52 < andytoshi> it's not a huge deal
10:52 < andytoshi> i trust that your unit test data is correct :)
10:54 < stevenroose> Ah k, easier. I thought I had some examples of issuances and pegouts as bookmarks, but can't find them back. Only the page that shows pegouts.
10:57 < andytoshi> no worries
11:49 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
11:53 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 250 seconds]
12:21 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
13:17 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
13:29 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
13:29 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
13:32 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
13:45 < sgeisler> stevenroose: I think the `Amount` PR is ready to be merged, maybe dongcarl can have a look at it too since it's quite big. What's the current plan for the merge order? Should serde_json or Amount come first?
13:55 < stevenroose> Yeah not sure, andytoshi gave conflicting indications about that :p
13:56 < stevenroose> Can go either way IMO. I think I rebased Amount so that it no longer relies on no-strason.
13:56 < stevenroose> So perhaps first Amount and then I rebase no-strason into no-strason-and-decimal
13:59 < andytoshi> i think that makes sense
14:04 -!- molz [~molly@unaffiliated/molly] has quit [Remote host closed the connection]
14:04 -!- molz [~molly@unaffiliated/molly] has joined #rust-bitcoin
15:10 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
15:16 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
15:33 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
15:33 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
15:37 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds]
16:09 -!- ccdle12 [~ccdle12@p116127-ipngn200301takamatu.kagawa.ocn.ne.jp] has joined #rust-bitcoin
16:15 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kmuwegoznfdvdxth] has quit [Quit: Connection closed for inactivity]
16:35 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
17:08 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
17:11 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin
17:13 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
17:18 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 246 seconds]
17:31 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Read error: Connection reset by peer]
17:32 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin
17:36 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
17:44 -!- BlueMatt_ [~BlueMatt@ircb.bluematt.me] has joined #rust-bitcoin
17:45 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 276 seconds]
17:56 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
17:59 -!- willpier_ [~willpiers@38.75.231.30] has joined #rust-bitcoin
18:01 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin
18:01 -!- BlueMatt_ [~BlueMatt@ircb.bluematt.me] has quit [Read error: Connection reset by peer]
18:44 -!- willpier_ [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
18:52 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
18:56 -!- ccdle12 [~ccdle12@p116127-ipngn200301takamatu.kagawa.ocn.ne.jp] has quit [Remote host closed the connection]
18:56 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
19:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
19:48 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
20:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
20:46 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
20:51 -!- willpier_ [~willpiers@38.75.231.30] has joined #rust-bitcoin
21:07 -!- willpier_ [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
21:13 -!- ccdle12 [~ccdle12@103.5.142.121] has joined #rust-bitcoin
21:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
21:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
21:47 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
21:50 -!- ccdle12 [~ccdle12@103.5.142.121] has quit [Remote host closed the connection]
21:52 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds]
22:06 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
22:59 -!- ccdle12 [~ccdle12@i210-161-167-204.s30.a048.ap.plala.or.jp] has joined #rust-bitcoin
23:14 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
23:44 -!- ccdle12 [~ccdle12@i210-161-167-204.s30.a048.ap.plala.or.jp] has quit [Read error: Connection reset by peer]
23:49 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
23:54 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds]
--- Log closed Tue Apr 30 00:00:59 2019