--- Log opened Wed May 01 00:00:01 2019
00:59 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D996506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin
01:01 -!- TamasBlummer [~Thunderbi@p200300DD670F9D336506B7C4D522E0CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
01:01 -!- TamasBlummer1 is now known as TamasBlummer
01:08 -!- TamasBlummer [~Thunderbi@p200300DD670F9D996506B7C4D522E0CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
01:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
02:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
02:25 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
02:30 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 268 seconds]
03:44 -!- TamasBlummer [~Thunderbi@p200300DD67196B336506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin
04:03 < stevenroose> andytoshi: it means that 3rd party types implementing FromHex need to implement from_byte_iter..
04:04 < stevenroose> Ah in fact that's fine. I was worried about newtypes that just forward the fromhex impl, but forwarding from_hex or from_byte_iter is the same :D
04:05 < stevenroose> > The second half of the tuple that is returned is an Option<usize>. A None here means that either there is no known upper bound, or the upper bound is larger than usize.
04:06 < stevenroose> An iterator of finite length that exceeds usize.. That would break a lot of things.. Like enumerate(), to name one.
06:11 < andytoshi> stevenroose: that's why there's an ExactSizeIterator bound
06:16 < stevenroose> Yeah, I was just surprised by that line in the Rust docs, not really relevant for our impl. I saw the ExactSizeIterator too. I like trait implementations that don't require any methods :)
06:17 < stevenroose> Perhaps ask sgeisler or nickler to review it real quick, I went over it and looked good. It's basically Iterator with hi and lo swapped.
06:26 < andytoshi> stevenroose: lol i just noticed https://github.com/rust-bitcoin/bitcoin_hashes/pull/20 where dongcarl gave us a `from_inner` method
06:26 < andytoshi> i'm going to merge that, can you rebase your PR on it?
06:26 < stevenroose> andytoshi: ah yeah sure
06:27 < stevenroose> tell me when it's merged
06:27 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
06:28 < andytoshi> merged
06:29 < sgeisler> I'm reviewing bitcoin_hashes#40 right now, I assume the only change to it will be removing the `from_inner` method?
06:30 < andytoshi> sgeisler: yeah
06:30 < andytoshi> if you can think of how to do this withotu breaking the `FromHex` trait that'd be awesome
06:31 < andytoshi> stevenroose: is https://github.com/ElementsProject/rust-elements/pull/16 ready?
06:31 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 245 seconds]
06:37 < stevenroose> andytoshi: I pushed it
06:37 < stevenroose> It's really just your commit left though :D
06:37 < andytoshi> stevenroose: lol!
06:37 < stevenroose> I rebase -i'd and took the from_inner PR out and didn't have conflicts. Quite satisfying.
06:38 < andytoshi> gonna head out for a couple hours. will leave it to sgeisler to ack/nak. if he doesn't complain i'll merge when i get home
06:38 < andytoshi> (but i'm half hoping he complains and has a non-breaking way to handle this so that we don't have to push a new major version of everything in the ecosystem)
06:39 < andytoshi> Oh, actually we can use the semver trick for this
06:39 < andytoshi> https://github.com/dtolnay/semver-trick
06:40 < andytoshi> oh, lol, no, actually adding a trait method is one of the things you can't use this for
06:41 < andytoshi> haha actually yes we can ... we can implement the new trait in terms of the old one
06:42 < andytoshi> no, i'm wrong again. damn. ecosystem-wide upgrade it is.
06:44 < andytoshi> oh! but we can implement the _old_ trait in terms of the _new_ one which is what we need to do
06:45 < sgeisler> yes, we could split it into two traits
06:45 < sgeisler> the from_byte_iter trait would auto impl the old `FromHex`
06:46 < sgeisler> `impl<T: TryFromIter> FromHex for T {`
06:46 < andytoshi> that does reduce the number of things FromHex is impl'd on though
06:47 < andytoshi> which I think is still a breaking change
06:47 < andytoshi> we currently have impl<T:Hash> FromHex for T
06:49 < sgeisler> and then we would have `impl<T: Hash> TryFromIter for T` which would impl `FromHex` transitively, wouldn't that get us to a state where we only added traits but not anything backwards incompatible?
06:50 < andytoshi> i don't see how we could impl that
06:50 < sgeisler> `TryFromIter` would be _our_ trait btw
06:50 < andytoshi> understood
06:50 < andytoshi> i'm saying that you can't impl it in terms of methods on Hash
06:51 < andytoshi> oh wait lol, i literally do this in the PR
06:51 < andytoshi> oh, no, i don't..
06:51 < andytoshi> i depend on the macro
06:51 < andytoshi> that impls it for a bunch of specific types
06:51 < andytoshi> you could do it if you added a Midstate:TryFromIter bound to `Hash`, but that's also a breaking change
06:51  * andytoshi gym
06:52 < sgeisler> I'll keep thinking about it, have fun :)
07:21 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
07:44 < stevenroose> I don't really see why we can't have the new method in a new trait, and then have the auto impl sgeisler mentioned
07:44 < stevenroose> sgeisler: can you push to my branch there?
07:44 < stevenroose> I'm not sure why andytoshi could, if he's rust-bitcoin contributor or because I once gave him write perm to my bitcoin_hashes fork, I think the former. So perhaps you can too.
07:46 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
07:46 < sgeisler> stevenroose: Yes I can push to the PR branch, you probably allowed maintainers or some other group to make changes, there is a check box that is checked by default when creating a PR
07:47 < sgeisler> My approach doesn't work because it would require the `Inner` types to impl `TryFromIter` too and that would be an additional constraint on the `Hash` trait
07:49 < sgeisler> stevenroose: I actually added a fixup commit, do you think I should squash it?
08:13 < stevenroose> yeah squash it :)
08:13 < stevenroose> I'm catching up Elements with Core, 1800+ commits, don't want to get distracted :D
08:39 < andytoshi> sgeisler: i'm back. what happened while i was gone? you think you can do the auto-impl?
08:39 < sgeisler> no, you were right :(
08:40 < andytoshi> damn
08:40 < sgeisler> I'd say we should just merge it as is
08:40 < andytoshi> ok, well, i'm fairly confident i can do the semver trick
08:40 < andytoshi> sounds good
08:40 < sgeisler> but don't release a new version yet
08:40 < andytoshi> kk
08:41 < sgeisler> I want to give HexIter a constructor to avoid the even length check on every `next()` call
08:42 < sgeisler> that's kinda silly and I don't see a reason for not having a constructor for `HexIter` that returns a result
08:45 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
08:50 < andytoshi> +1
08:51 < andytoshi> merged 40
09:02 < andytoshi> stevenroose: am i OK to merge rust-elmenets #16 (address type)
09:06 < andytoshi> pls respond
09:07 < stevenroose> on the issue? looking
09:07 < stevenroose> andytoshi: I think yes, I don't think anything came up
09:08 < andytoshi> according to the PR it's good to go
09:08 < andytoshi> cool
09:08 < andytoshi> merged
09:08 < stevenroose> andytoshi: have you ever experimented with rust-bitcoin compiled to wasm? I think it'd make a compelling alternative to bitcoinjs
09:09 < stevenroose> andytoshi: this one is related to rust-elements address: https://github.com/rust-bitcoin/rust-bitcoin/pull/254
09:11 < andytoshi> stevenroose: no, i avoid javascript like the plague
09:11 < andytoshi> also, IIRC somebody opened an issue on rust-secp claiming that he couldn't compile it to wasm because of the ffi bindings
09:12 < stevenroose> hmm
09:12 < andytoshi> er, it was on rust-bitcoin, trying to disable rust-secp
09:12 < stevenroose> ah yeah I saw that, to make secp optional. did that get in eventually?
09:13 < andytoshi> and then we kinda led him on for a while saying "sure we'll feature-gate rust-secp" and then eventually decided no, let's not add like 100 #[cfg(feature = "secp")] for something we don't even care about
09:13 < stevenroose> andytoshi: yeah well having rust-bitcoin-wasm is a way to avoid JS
09:13 < andytoshi> no
09:13 < andytoshi> the library is really not useful with out rust-secp IMO
09:13 < stevenroose> true
09:14 < stevenroose> I guess a better way to avoid JS is to write your entire app in Rust and then compile to WASM instead of JS with rust-bitcoin-wasm as a lib.
09:14 < andytoshi> yse, and an even better way is to skip the part where you compile to wasm
09:14 < andytoshi> ;)
09:28 < stevenroose> In fact I was looking into GUI frameworks that have Rust bindings.
09:29 < stevenroose> Slim pickin's.
09:29 < stevenroose> I was thinking how nice it would be to have a desktop app that can keep track on all your open PRs, assigned issues, task lists on different repos.
09:29 < stevenroose> s/track on/track of/
09:48 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]
10:19 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer]
10:19 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
10:29 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds]
10:31 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
10:44 < nickler> Imo compiling to WASM would be interesting. But that that doesn't work right now because of ffi bindings should be fixed eventually right? There's nothing fundamentally preventing that.
10:46 < andytoshi> isn't there? i have no idea
12:00 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
12:11 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
12:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
13:01 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
13:10 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #rust-bitcoin
13:17 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
15:56 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
15:56 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
15:56 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
15:57 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin
15:58 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer]
18:04 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Ping timeout: 245 seconds]
18:26 -!- takinbo [sid19838@gateway/web/irccloud.com/x-sqtjjzxmavccqcrs] has quit [Ping timeout: 276 seconds]
18:33 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-fwejofvhhdiimmzo] has quit [Ping timeout: 240 seconds]
18:47 -!- takinbo [sid19838@gateway/web/irccloud.com/x-bbdxkhryyriohwyk] has joined #rust-bitcoin
18:48 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
18:49 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-gbamafeahzudexdd] has joined #rust-bitcoin
18:52 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 246 seconds]
20:24 -!- takinbo_ [sid19838@gateway/web/irccloud.com/x-lwfcknxyojbcakco] has joined #rust-bitcoin
20:25 -!- takinbo [sid19838@gateway/web/irccloud.com/x-bbdxkhryyriohwyk] has quit [Ping timeout: 258 seconds]
20:25 -!- takinbo_ is now known as takinbo
20:52 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
21:21 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
21:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:32 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
22:39 -!- willpier_ [~willpiers@38.75.231.30] has joined #rust-bitcoin
22:39 -!- willpiers [~willpiers@38.75.231.30] has quit [Read error: Connection reset by peer]
22:55 -!- willpier_ [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
23:06 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin
23:16 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection]
--- Log closed Thu May 02 00:00:01 2019