--- Log opened Wed Jul 03 00:01:00 2019
00:11 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
05:01 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
06:40 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nueclfyykucknpyf] has joined #rust-bitcoin
07:11 < ariard> BlueMatt: what's proposal needs a lightning spec ? The Carve-Out has already been specified, or you were speaking about the emergency RBF yesterday?
07:50 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
09:25 -!- brett-soric [~brett@ppp203-122-220-93.static.internode.on.net] has joined #rust-bitcoin
10:12 < andytoshi> stevenroose: can i have an ack on https://github.com/rust-bitcoin/rust-bitcoin/pull/286 ?
10:12 -!- brett-soric [~brett@ppp203-122-220-93.static.internode.on.net] has left #rust-bitcoin []
10:13 < andytoshi> also can somebody add an ack to https://github.com/rust-bitcoin/rust-bitcoin/pull/271
10:19 < andytoshi> stevenroose: also an ack on https://github.com/rust-bitcoin/bitcoin_hashes/pull/51
10:34 < andytoshi> can someone add an ack to https://github.com/rust-bitcoin/rust-bitcoin/pull/277#pullrequestreview-257639645
12:09 < elichai2> andytoshi: I found the problem that caused docs.rs to stop working for secp256k1
12:11 < elichai2> oh. I see now that it was fixed on master already lol
12:12  * elichai2 facepalm
12:15 < andytoshi> elichai2: :)
12:15 < andytoshi> i guess i should release a new version with that fix..
12:16 < elichai2> yeah, It's pretty frustrating not having access to the docs.rs
12:16 < andytoshi> yeah, sorry .. the reason is that we have a major version to release next
12:16 < andytoshi> and i wanted to get some of the prealloc stuff in first
12:16 < elichai2> oh ok, that's fine
12:17 < elichai2> we can wait a bit more (I have a local api)
12:25 < andytoshi> re the conversation on https://github.com/rust-bitcoin/rust-secp256k1/pull/115
12:26 < andytoshi> this is fucking stupid that we would need to license code to deal with C's ambiguity about the signedness of char
12:26 < andytoshi> let's just assume it's i8
12:26 < andytoshi> and deal with the bug reports from all zero systems that have ever existed which will have a problem with that, given that these functions are only ever called with ASCII strings anyway
12:26 < elichai2> I would argue that this is obvious code and we can remove the "This is an exact copy of" statements
12:27 < andytoshi> sure, and the moz folks aren't going to come after us anyway
12:27 < elichai2> maybe we can make a cfg that panics on any system that isn't like that
12:27 < andytoshi> i don't even know how we could detect the difference
12:27 < elichai2> (or any target in the official stuff that `c_char = u8`)
12:27 < andytoshi> unless we were adding c_chars
12:27 < andytoshi> and overflowing them
12:29 < andytoshi> alternately let's PR to upstream adding a "signed" qualifier to the function definiion
12:32 < elichai2> couldn't we underflow in C, check if less than 0, return some bool and assert in rust? (once in creation to make sure those weird systems will crash) or is that too much haha?
12:33 < elichai2> yeah adding `signed` should solve it
13:03 < sgeisler> andytoshi: added an ACK to https://github.com/rust-bitcoin/bitcoin_hashes/pull/51 and https://github.com/rust-bitcoin/rust-bitcoin/pull/277#pullrequestreview-257639645
13:03 < sgeisler> still reading  https://github.com/rust-bitcoin/rust-bitcoin/pull/271
13:38 < andytoshi> nice. ready for bitcoin_hashes 0.5 i guess
13:42 < andytoshi> published
13:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
14:41 < andytoshi> sgeisler: can you also ack https://github.com/rust-bitcoin/rust-bitcoin/pull/286 ? i thought you had but apparently you just said "would be nice to know the motivation"
14:42 < andytoshi> i dunno why I thought that meant "ACK"..
14:44 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
14:46 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
14:47 < sgeisler> andytoshi: done. I initially ACKed, then felt embarrassed for not seeing the problem with pushing arbitrary data, finally your push to fix the problem removed my ACK (as it should since the code was changed again)
14:50 < andytoshi> ah right
14:50 < andytoshi> yeah, that was an embarassing bug :) idk how i didn't catch it either
15:09 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
15:11 < elichai2> What do people think about adding cache to travis to speed up builds?
15:12 < andytoshi> i think most of the time is spent fuzzing, no?
15:16 < elichai2> nvm it seems like it already uses cache
15:17 < elichai2> (rust-secp has at least 9 different builds so I assumed just that can take at least a few minutes)
15:28 < sgeisler> what we could do is parallelizing the fuzzing stage
15:29 < sgeisler> a bit like https://travis-ci.org/rust-bitcoin/rust-lightning-invoice but having multiple containers for build&fuzz, running every fuzz test in its own env
15:44 < nothingmuch> win 15
18:30 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
18:53 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nueclfyykucknpyf] has quit [Quit: Connection closed for inactivity]
18:58 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-idfegfmwnvineexl] has joined #rust-bitcoin
19:03 -!- TamasBlummer1 [~Thunderbi@p200300DD6712644450D21AD5103DB1B1.dip0.t-ipconnect.de] has joined #rust-bitcoin
19:05 -!- TamasBlummer [~Thunderbi@p200300DD6712646791748C8CD0CE491A.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
19:05 -!- TamasBlummer1 is now known as TamasBlummer
19:45 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
19:48 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
20:50 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
20:51 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
21:13 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-idfegfmwnvineexl] has quit [Quit: Connection closed for inactivity]
21:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-beynyrpyhaamyxfm] has joined #rust-bitcoin
23:26 -!- neonknight64 [~neonknigh@195.159.29.126] has quit [Quit: Leaving]
23:26 -!- CjS77 [~caylemeis@195.159.29.126] has quit [Quit: Leaving]
23:26 -!- stanimal [~stanimal@195.159.29.126] has quit [Quit: Leaving]
23:26 -!- simian_za [~simian_za@195.159.29.126] has quit [Quit: Leaving]
23:26 -!- Blackwolfsa [~Blackwolf@195.159.29.126] has quit [Quit: Leaving]
23:32 -!- simian_za [~simian_za@195.159.29.126] has joined #rust-bitcoin
23:32 -!- CjS77 [~caylemeis@195.159.29.126] has joined #rust-bitcoin
23:32 -!- stanimal [~stanimal@195.159.29.126] has joined #rust-bitcoin
23:32 -!- Blackwolfsa [~Blackwolf@195.159.29.126] has joined #rust-bitcoin
23:32 -!- neonknight64 [~neonknigh@195.159.29.126] has joined #rust-bitcoin
--- Log closed Thu Jul 04 00:00:00 2019