--- Log opened Wed Jul 10 00:00:06 2019
00:04 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
00:09 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
00:21 -!- reallll is now known as belcher
00:22 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
01:03 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
01:04 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
02:14 < stevenroose> Anyone had a chance to review https://github.com/rust-bitcoin/rust-bitcoin/pull/281 ? (bip158 block filters)
02:14 < stevenroose> andytoshi: dongcarl sgeisler
02:16 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit []
02:55 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
03:30 -!- windsok [~windsok@unaffiliated/windsok] has quit [Ping timeout: 276 seconds]
03:32 -!- windsok [~windsok@rarepepe.cash] has joined #rust-bitcoin
03:32 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host]
03:32 -!- windsok [~windsok@unaffiliated/windsok] has joined #rust-bitcoin
05:47 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
07:02 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-dwhojiikwxmoybms] has joined #rust-bitcoin
07:40 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
07:46 < dongcarl> stevenroose: I don't have enough context around BIP158 to sufficiently review correctness, any other PRs that doesn't require much context?
07:59 -!- esotericnonsens_ [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection]
08:06 -!- e4xit [~davidblai@95.211.225.220] has quit [Remote host closed the connection]
08:06 -!- davidblaine [~e4xit@95.211.225.220] has joined #rust-bitcoin
08:09 -!- davidblaine [~e4xit@95.211.225.220] has quit [Client Quit]
08:24 -!- e4xit [~e4xit@95.211.225.220] has joined #rust-bitcoin
08:34 < andytoshi> i'm not reviewing anything until my PRs get in
09:37 < dongcarl> andytoshi: Which ones need attention?
09:41 < andytoshi> dongcarl: i need sgeisler to ack https://github.com/rust-bitcoin/bitcoin_hashes/pull/52
09:41 < andytoshi> i need https://github.com/rust-bitcoin/rust-bitcoin/pull/265
09:42 < andytoshi> i think i need a stevenroose ack, but there are new comments apparently i should read
09:42 < andytoshi> i'd like to get https://github.com/rust-bitcoin/rust-bitcoin/pull/271 in
09:42 < andytoshi> then I need another PR to update bitcoin_hashes version
09:43  * dongcarl looking
09:46 < andytoshi> actually on #265 i need to think about what i'm doing
09:47 < andytoshi> BlueMatt: your tone "very very broken" etc is increasingly frustrating. sealing these traits really is a big inconvenience for rust-elements, testing projects like utreexo, liquid, etc, which i was willing to do more-or-less as a favor to you because i agree with the philosophy that rust-bitcoin's consensus serialization should only be used for rust-bitcoin consensus types
09:47 < andytoshi> but it's not "the obvious thing" to try to use it
09:48 < andytoshi> and you haven't mentioned any issues that a single unit test wouldn't catch, or that anybody but you has ever encountered, or that aren't present in serde to a greater degree
09:48 < andytoshi> and no, you can't use a patched version of rust-bitcoin in anything you want to publish to crates.io
09:49 < andytoshi> dongcarl: removing the sealing and putting a "deprecated" warning seems fine to me
09:49 < dongcarl> andytoshi: Great!
09:49 < andytoshi> but maybe i want to do neither :(. this PR has been held up for almost 2 months now because of this and i'm not happy about it.
09:50 < dongcarl> I think we have agreement on "deprecated"
09:50 < andytoshi> ok. i'll do that later today when i'm less annoyed
09:50 < dongcarl> Sounds good, I'll take a look at the PRs you've listed above
09:55 < BlueMatt> andytoshi: right, I dont think any testing projects like utreexo need to be published to crates (ie could do patches?). sorry if you find the "this is broken" tone annoying, its mostly a response to my annoyance at what appear to be philosophical disagreements here - I just dont (really) get why stevenroose wants rust-elements to use rust-bitcoin's serialization traits. Its a bit easier to write, sure, but it seems to be conflicting
09:55 < BlueMatt> maintinence - ie rust-bitcoin serialization changes dont get review for whether the serialization format of something that isn't used in rust-bitcoin changes (which could impact users)
09:57 < andytoshi> rust-bitcoin serialization has never changed in the history of the project, except when we removed the generic impls, and that was a breaking change that required a major versin bump
09:57 < andytoshi> i don't understand how this is different from any other major version bump
09:57 < andytoshi> and this still would have been breaking, even with sealed traits
10:54 < dongcarl> andytoshi: Left my reviews, lmk if there are any questions
10:56 < andytoshi> dongcarl: thanks!!
11:56 < dongcarl> andytoshi: Merged no_std.
12:01 < andytoshi> thanks!
12:02 < andytoshi> published
12:02 < dongcarl> andytoshi: There are a couple of things in `bitcoin_hashes` that have become inconsistent across the individual hashes as people tend to forget to change for all individual hashes...
12:03 < dongcarl> I'll look into how best to architect to have single source of truth and avoid this, if you think that's an okay idea
12:03 < andytoshi> yeah
12:03 < andytoshi> the `Hash` trait is supposed to do this..
15:43 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
18:53 -!- TamasBlummer1 [~Thunderbi@p200300DD6712648598C737EBE5B46EE8.dip0.t-ipconnect.de] has joined #rust-bitcoin
18:55 -!- TamasBlummer [~Thunderbi@p200300DD67126453ECFEDF08BCDBEBFF.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
18:55 -!- TamasBlummer1 is now known as TamasBlummer
19:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
19:44 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-dwhojiikwxmoybms] has quit [Quit: Connection closed for inactivity]
19:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
19:48 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
--- Log closed Thu Jul 11 00:00:07 2019