--- Log opened Thu Jul 11 00:00:07 2019 00:02 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 02:26 < stevenroose> dongcarl: what do you mean with this? 02:26 < stevenroose> > There are a couple of things in `bitcoin_hashes` that have become inconsistent across the individual hashes as people tend to forget to change for all individual hashes 02:41 < stevenroose> I found a bip39 implementation in rust-bitcoin/rust-wallet. It seems quite ok quality. Anyone objections if I PR it into rust-bitcoin under util::bip39? 05:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 06:02 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 07:18 < andytoshi> is bip39 the wordlist thing? i really don't like it 07:20 < andytoshi> no checksumming (ok, i guess it has 3/4 of a word of checksum), no support for splitting, claims that the words are unique when truncated to 4 letters but (a) has very simialr words (rock/racket); (b) has a ton of 3-letter words 07:20 < andytoshi> or was in rack/rocket? 07:49 < instagibbs> bip39 doesn't technically specify a wordlist, just guidelines on choosing the wordlist 07:50 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 08:04 < Varunram> slip 39 is the most standard one? https://github.com/satoshilabs/slips/blob/master/slip-0039/wordlist.txt 08:05 < Varunram> can't see rock / racket though, dunno which implementation has that 08:36 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-fpeqzqhseurfgimq] has joined #rust-bitcoin 08:43 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 08:56 < andytoshi> lol https://github.com/bitcoin/bips/blob/master/bip-0039/english.txt has it 08:56 < Varunram> oh lol, my bad 08:57 < andytoshi> further evidence that "nack" on bip 39, if the "most standard" wordlists are not even its wordlists 08:58 < instagibbs> they admit it was a mistake, I believe slip39 says no non-english lists, and prescribes a list 08:58 < Varunram> well, I think SLIP is used since trezor updates it 08:58 < andytoshi> ledger uses the BIP39 words fwiw 08:58 < instagibbs> OTOH I think you can only hold off supporting the most popular backup method so long 08:59 < andytoshi> we've been holding off for 5 years so far.. 08:59 < instagibbs> well, of course you can not adopt it and then people will just run other libs. I don't implement bip39 in any of my repos either ;P 09:00 < instagibbs> anyways not a contributor, so ignore me 09:00 < andytoshi> i'm fine with people needing other libs to get bip39 support 09:00 < instagibbs> is there a guideline for what it would support? "must be beautiful?" not trolling 09:01 < instagibbs> was reading https://github.com/satoshilabs/slips/issues/103 this morning 09:02 < Varunram> from 17 wow 09:03 < Varunram> thx for the link 09:03 < andytoshi> "must not be actively broken and have harmed the space" is necessary, but not sufficient 09:04 < andytoshi> well, at least "must not have actually caused problems with andrew's personal backups" 09:05 < andytoshi> which rock/racket did (well, would've had I not done a couple test cycles before putting any coins into this ridiculous scheme) 09:05 < Varunram> you were using slip to? 09:05 < instagibbs> ehhh people should always do a test cycle :P 09:05 < Varunram> too* 09:05 < andytoshi> Varunram: no, there was no such thing as a SLIP back then 09:05 < Varunram> OH, this was long ago 09:05 < Varunram> right 09:05 < instagibbs> I'd argue the additional passphrase stuff is the real damage of the scheme 09:06 < instagibbs> takes the checksum power to 0 09:06 < andytoshi> instagibbs: ok, but if your test cycle shows that you would have lost coins due to poor design decisions, i think that's a reasonable criteria to not allow something in the libraries you maintain :) 09:07 < instagibbs> your prerogative :) 12:04 < dongcarl> stevenroose: I meant things like this: https://github.com/rust-bitcoin/bitcoin_hashes/pull/56 12:47 < dongcarl> seeking concept ack: https://github.com/rust-bitcoin/bitcoin_hashes/pull/57 15:11 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 19:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-fpeqzqhseurfgimq] has quit [Quit: Connection closed for inactivity] 19:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:28 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:34 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 22:37 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Fri Jul 12 00:00:09 2019