--- Log opened Mon Jul 15 00:00:11 2019 00:16 -!- Netsplit over, joins: sgeisler 00:16 -!- esotericnonsense is now known as 17SAA1TBX 00:16 -!- Netsplit over, joins: wumpus, windsok, dpc, dmkathayat_ 00:21 -!- 17SAA1TBX is now known as esotericnonsens_ 01:26 -!- Netsplit *.net <-> *.split quits: sgeisler 01:27 -!- Netsplit *.net <-> *.split quits: dpc, windsok, dmkathayat_, wumpus 01:27 -!- esotericnonsens_ is now known as esotericnonsense 01:35 -!- windsok [~windsok@rarepepe.cash] has joined #rust-bitcoin 01:35 -!- dmkathayat [~quassel@ec2-13-233-97-253.ap-south-1.compute.amazonaws.com] has joined #rust-bitcoin 01:35 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host] 01:35 -!- windsok [~windsok@unaffiliated/windsok] has joined #rust-bitcoin 01:36 -!- sgeisler [sid356034@gateway/web/irccloud.com/x-mmoirmuoqxfsoqwg] has joined #rust-bitcoin 01:36 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #rust-bitcoin 01:39 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-gpvkxclfnybxbuns] has joined #rust-bitcoin 01:44 -!- Fern48Mann [~Fern48Man@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 05:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 05:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 07:30 -!- reallll is now known as belcher 07:40 < stevenroose> andytoshi: is it possible that I'm getting a "Non-canonical DER signature" error (from OP_CHECKSIG) when using secp::sign().serialize_der()? 07:47 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 08:11 < stevenroose> Ah it looks like it's missing the sighash byte. 08:11 < stevenroose> Does rust-bitcoin have code to add that? 09:46 < andytoshi> no, i've always done it by hand 09:46 < andytoshi> arguably we should have a bitcoin::Signature type 09:46 < andytoshi> similar to bitcoin::PublicKey 10:29 < stevenroose> Yeah I did it by hand. 10:30 < stevenroose> andytoshi: something else: all the methods in the bitcoin_hashes::hex module return a bitcoin_hashes::error::Error as the error type. But all the variants in bitcoin_hashes::error::Error seem to be related to hex stuff (except one length error for from_slice). It's a bit sad there is no hex::Error. 10:31 < stevenroose> It feels a bit strange to return a Result for a trait called FromHex.. 10:31 < stevenroose> No biggie and sadly a breaking change which we probably don't want to do. 10:34 -!- Fern48Mann [~Fern48Man@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 245 seconds] 10:36 < andytoshi> hmm, yeah, makes sense 10:36 < andytoshi> if you want to PR we can do another breaking change 10:36 < andytoshi> conveniently none of the downstream deps have updated since the last breaking change 10:37 < andytoshi> so we can just release a new major version now 10:44 < stevenroose> So we're ok with a single bitcoin_hashes::Error variant then? I think it's really just the InvalidLength for from_slice. 10:50 < elichai2> Just a cool trick I found online to check sizes at compile time: `mem::transmute::(0);` (this won't compile if they're not the same size) 11:05 < stevenroose> I added bip32::Fingerprint and bip32::ChainCode to https://github.com/rust-bitcoin/rust-bitcoin/pull/271 11:16 < stevenroose> andytoshi: https://github.com/rust-bitcoin/bitcoin_hashes/pull/58 11:16 < stevenroose> anything that is blocked for you to progress with rust-bitcoin release? 11:16 < stevenroose> Anything I can help with that you're blocked on*? 11:27 < elichai2> stevenroose: you planing to update the rust-secp256k1 dependency for the new release? 12:02 < stevenroose> elichai2: andytoshi is the planner :D But I guess we will update the secp dep. But there was something with it. I think we were gonna update first without secp and then with, because when we update secp, all other packages using secp also need to be updated 12:03 < elichai2> stevenroose: yeah haha, you were just talking about a new release so I wondered :), about that thing if that's the rust-bitcoinconsensus I hopefully fixed it :) 14:17 < elichai2> Does rust-bitcoin support descriptors? 14:25 < nickler> rust-bitcoinconsensus still needs a release for this to be fully fixed such that secp can be updated in rust-bitcoin 14:26 < elichai2> 👍 15:29 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:46 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:c4e8:2342:8797:2770] has joined #rust-bitcoin 15:54 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:c4e8:2342:8797:2770] has quit [] 20:13 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-cjjfjoslipobgvvu] has quit [Quit: Connection closed for inactivity] 20:15 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 22:52 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:53 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 22:55 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 22:56 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Tue Jul 16 00:00:11 2019