--- Log opened Fri Jul 19 00:00:15 2019 02:03 < stevenroose> Anyone willing to take on review TamasBlummer's BIP158 impl? I approved it. https://github.com/rust-bitcoin/rust-bitcoin/pull/281 03:05 < stevenroose> andytoshi: addressed https://github.com/rust-bitcoin/rust-bitcoin/pull/255#discussion_r305279818 04:32 -!- jtimon [~quassel@73.58.132.37.dynamic.jazztel.es] has joined #rust-bitcoin 04:33 -!- jtimon [~quassel@73.58.132.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 05:48 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 05:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 08:05 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hlsjfvnbaqmaiepj] has joined #rust-bitcoin 08:10 < stevenroose> andytoshi: any change you can release the bitcoin_hashes with the hex error? 08:16 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 09:32 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 09:35 < andytoshi> stevenroose: yeah, i'll try to do it in the next hour 10:23 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 12:06 < BlueMatt> ariard: thanks for changing the constant names, but can you make GRACE_PERIOD_BLOCKS a bit more descriptive 12:06 < BlueMatt> like NETWORK_SYNC_GRACE_PERIOD_BLOCKS? 12:10 < BlueMatt> ariard: also, dunno what editor you're using, but if you do git show or some other git diff tool it should highlight any trailing spaces you add, which I see a bunch of :p 13:29 < ariard> BlueMatt: vim as everyone, but updated my git hooks to avoid committing them sorry for that! 14:41 -!- reallll is now known as belcher 15:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 18:40 -!- TamasBlummer1 [~Thunderbi@p200300DD6712642781AE11FD7F53850A.dip0.t-ipconnect.de] has joined #rust-bitcoin 18:42 -!- TamasBlummer [~Thunderbi@p200300DD6712641270AEBA811EFB3AD0.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 18:42 -!- TamasBlummer1 is now known as TamasBlummer 21:13 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hlsjfvnbaqmaiepj] has quit [Quit: Connection closed for inactivity] --- Log closed Sat Jul 20 00:00:17 2019