--- Log opened Thu Jul 25 00:00:20 2019 00:49 < stevenroose> re-acked the bip158 pr (#281) 03:12 < stevenroose> rebased address refactor PR 07:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 07:18 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-szbygdoiahsufyby] has joined #rust-bitcoin 07:22 < elichai2> I see that Jonas wants to bump secp256k1 version already. what's still missing in #132 so I can get it ready to also be included in the next release? 07:28 < elichai2> nickler andytoshi 07:29 < nickler> did anyone test it on a machine without gmp? 07:32 < elichai2> travis did afaik 07:34 < elichai2> I'm pretty sure these steps are redundant because we compile to a static library so I don't think the linker is involved yet and we should just emit the right flags for the rust compiler so it could link, but i'm not sure about this https://github.com/rust-bitcoin/rust-secp256k1/pull/132/files#diff-a7b0a2dee0126cddf994326e705a91eaR94 07:52 < andytoshi> 281 needs to be tested on a non-gmp machine by a human ... but also it doesn't need a major release 07:52 < andytoshi> s/281/132/ 07:56 < elichai2> k, I might set up a small VM for this later and give it a look 07:57 < andytoshi> i might also uninstall gmp from my machine and give it a whirl, but i don't have a ton of time today 07:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 08:32 < BlueMatt> ariard: looks like travis failed on it? 09:07 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [] 09:25 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #rust-bitcoin 09:25 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host] 09:25 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 11:00 < TamasBlummer> stevenroose: re-ack 281 again please 11:01 < TamasBlummer> covered some edge cases like search in empty filter or search with empty query 11:02 < ariard> BlueMatt: rust beta failed due to some gpg error on package servers 11:02 < ariard> all others jobs passed 11:02 < ariard> restarted 11:02 < BlueMatt> kool, will look then 11:04 < TamasBlummer> 281 is not touching any existing functionality, just let it in please. 11:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 11:05 < TamasBlummer> andytoshi: ^ 11:08 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer] 11:12 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined #rust-bitcoin 11:17 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 11:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 11:27 < andytoshi> sure 11:28 < andytoshi> acked, but i think we need to wait for stevenroose to come back 11:41 -!- reallll is now known as belcher 12:12 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 12:26 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 12:27 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 12:37 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 13:35 < TamasBlummer> thanks 14:29 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 14:34 < BlueMatt> ariard: plz rebase prs so we can get codecov comparisons =D 14:34 < BlueMatt> well, also fix comments 15:00 < elichai2> So i've found a problem with detecting gmp the way I did :/ 16:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 16:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 18:33 -!- TamasBlummer1 [~Thunderbi@p200300DD67126497CD76CC54AE545468.dip0.t-ipconnect.de] has joined #rust-bitcoin 18:36 -!- TamasBlummer [~Thunderbi@p200300DD6712644089830B1D8358BB90.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 18:36 -!- TamasBlummer1 is now known as TamasBlummer 22:57 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-szbygdoiahsufyby] has quit [Quit: Connection closed for inactivity] --- Log closed Fri Jul 26 00:00:21 2019