--- Log opened Thu Aug 15 00:00:40 2019
01:24 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has joined #rust-bitcoin
01:27 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has quit [Read error: Connection reset by peer]
01:35 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has quit [Ping timeout: 248 seconds]
01:36 -!- harding [~harding@cpe-66-91-121-125.hawaii.res.rr.com] has joined #rust-bitcoin
03:45 < stevenroose> andytoshi: they are considering raising the minimum required Rust version for base64 to 1.34: https://github.com/marshallpierce/rust-base64/pull/110
03:47 < stevenroose> andytoshi: is it possible to have a feature f.e. "compat" that supports compilation with old Rust versions? I know there is no way to add code conditionals based on rustc version, but with a feature it might work.
05:37 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-chkqjvgluvzddzsc] has joined #rust-bitcoin
05:44 -!- Aleru [~ryan@c-73-102-128-238.hsd1.in.comcast.net] has joined #rust-bitcoin
08:03 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
08:04 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
08:42 < andytoshi> that would be possible
08:42 < andytoshi> but irrelevant to this case where the maintainers are insane
08:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
10:54 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
11:35 < elichai2> I'm cirious if I could do something similiar to `fuzztarget` to simulate secp so we can use `miri` on our lib
11:37 < elichai2> (to remove ffi, basically make some wide conditions so that all the tests will pass and then miri will report on unsafe bad stuff)
11:58 < andytoshi> i think that would have ~0 value
11:58 < andytoshi> all of the unsafety in rust-secp is ffi related
12:13 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has joined #rust-bitcoin
12:14 < elichai2> I'm not sure about 0 value, but actually you're right it probably isn't worth the effort
12:21 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
12:22 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:23 -!- reallll [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds]
12:28 -!- titanbiscuit [~tbisk@91.203.70.191] has quit [Read error: Connection reset by peer]
12:44 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has quit [Remote host closed the connection]
12:45 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has joined #rust-bitcoin
12:47 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has quit [Remote host closed the connection]
12:47 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has joined #rust-bitcoin
12:50 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
12:52 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e84d:9fde:8781:261c] has quit [Ping timeout: 252 seconds]
13:42 -!- titanbiscuit [~tbisk@91.203.70.189] has joined #rust-bitcoin
13:51 < stevenroose> andytoshi: I fixed that possible panic in the is_witness_program check and I also added a fuzzer for from_script
13:55 < stevenroose> Hmm, I'm not really good with running the fuzzing stuff, I think it has a bug and always fails. Let me try debug that..
13:57 < stevenroose> I'm getting this output: https://0bin.net/paste/qLwI6yHgy8i7NEmn#Cnb+4N9pVIArRbJztjXB5PfTObg4vUUFe459tDPOgzH
13:58 < stevenroose> What do I do with that? Where is the actual failed case? The file it produced there is empty.
13:58 < stevenroose> BlueMatt: any chance you can help ^?
14:02 < andytoshi> did you try testing that `from_script` handles the empty string?
14:10 < stevenroose> Yeah the file was a single 0x00 byte (empty script). Fixed that, running fuzzer now, let's see.
14:11 < stevenroose> andytoshi: I am wondering about how the fuzzer works. The do_test method actually doesn't give any feedback on whether something was a valid script or not. So how does the fuzzer progress other can just brute forcing randomness?
14:11 < stevenroose> I thought it was smarter than that.
14:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
14:26 < stevenroose> Ok I rephrased that is_witness_program logic to something much more readable. Tests pass, fuzzer seems happy until now. Just force pushed
14:53 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
14:58 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Ping timeout: 252 seconds]
15:04 < andytoshi> stevenroose: the fuzzer just tries to hit all the execution paths
15:16 < andytoshi> dongcarl: are you around? can you review https://github.com/rust-bitcoin/rust-bitcoin/pull/255 today?
15:16 < andytoshi> how about https://github.com/rust-bitcoin/rust-bitcoin/pull/289 ?
15:16 < andytoshi> if we can merge these we can release 0.19 and 0.20
15:17 < dongcarl> andytoshi: I'll do as much as I can now, and will definitely get to them tomorrow
15:19 < andytoshi> dope
15:19 < andytoshi> 289 is pretty small
15:19 < andytoshi> 255 has a lot of commits but they're well-contained
15:22 < dongcarl> Yeah, I've looked at them before, but gunna go thru 255's commits again
16:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
16:41 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
16:47 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Remote host closed the connection]
16:48 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
16:50 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Read error: Connection reset by peer]
16:50 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
16:56 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Remote host closed the connection]
16:56 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
17:05 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Remote host closed the connection]
17:06 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
17:11 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Remote host closed the connection]
17:11 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
17:13 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Remote host closed the connection]
17:14 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
17:36 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Remote host closed the connection]
17:44 < elichai2> https://doc.rust-lang.org/nightly/cargo/commands/cargo-vendor.html
17:44 < elichai2> That's cool
18:35 < andytoshi> yeah, it's nice that it's built in now
18:36 < andytoshi> we've been using it at blockstream for a couple years
18:47 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
19:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
19:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
20:04 < elichai2> Oh nice, yeah it's cool that it's built in
20:10 < elichai2> andytoshi: and with the new anonymous consts we can write: https://play.rust-lang.org/?version=beta&mode=debug&edition=2018&gist=7ccf6c5f6c2f97cb2bd49f67eafed649
23:07 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-chkqjvgluvzddzsc] has quit [Quit: Connection closed for inactivity]
--- Log closed Fri Aug 16 00:00:42 2019