--- Log opened Fri Aug 16 00:00:42 2019
01:16 -!- Aleru [~ryan@c-73-102-128-238.hsd1.in.comcast.net] has quit [Quit: Leaving]
03:32 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Quit: WeeChat 2.3]
03:34 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined #rust-bitcoin
04:07 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
05:30 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Remote host closed the connection]
05:34 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
05:39 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Ping timeout: 250 seconds]
05:55 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has joined #rust-bitcoin
05:55 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:e543:71aa:beb9:3642] has quit [Read error: Connection reset by peer]
06:18 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-gwpzuvjzenerifyu] has joined #rust-bitcoin
07:10 < stevenroose> dongcarl: changed those two bitcoin_hashes mentions in the docs
07:10 < dongcarl> stevenroose: K nice
07:10 < dongcarl> I'll approve in a bit, deep in your Address refactor right now
07:11 < stevenroose> Oh nice. Would be really nice to get 0.19 out finally :)
07:13 < dongcarl> :-)
07:23 < dongcarl> stevenroose: merged address refactor
07:23 < dongcarl> stevenroose: I think the export PR needs rebase cuz of that
07:23 < dongcarl> but that PR is easier to rebase than the Address I'd assume :-)
07:48 < stevenroose> dongcarl: k, rebasing one sec
07:53 < stevenroose> dongcarl: rebased
08:00 < stevenroose> andytoshi: v0.19 at last? :)
08:01 < BlueMatt> yayyyyy
08:03 < dongcarl> stevenroose: Approved, perhaps someone else can also approve
08:05 < stevenroose> andytoshi did, but it might have expired because of the rebase, BlueMatt? it's a really trivial PR: https://github.com/rust-bitcoin/rust-bitcoin/pull/289
08:06 < BlueMatt> done
08:09 < stevenroose> Nice. I guess Andrew does the releasing? I could PR a changelog already perhaps to speed things up.
08:19 < dongcarl> stevenroose: Yeah changelog would be nice
08:26 < stevenroose> I feel like it's a good time to change the `authors` field in Cargo spec as it says Andrew Poelstra :D
08:27 < stevenroose> Not sure if it makes sense to start listing people, though. I'd just fill in `The rust-bitcoin team` or something.
08:27 < stevenroose> I'll leave it for now as it's a hard to come up with something.
08:35 < stevenroose> andytoshi, dongcarl, BlueMatt: changelog and Cargo spec bump:https://github.com/rust-bitcoin/rust-bitcoin/pull/314
08:37 < dongcarl> stevenroose: Let's not do the formatting change in Cargo.toml, no benefit and I like editing individual lines better
08:38 < stevenroose> Hmm, I feel like the individual dependency sections make it harder to distinct dependencies and dev-dependencies and make it harder to get an quick grasp of which dependencies there actually are.
08:39 < stevenroose> I can revert it though. I just thought it was better this way.
08:39 < dongcarl> stevenroose: Yeah, we can have that discussion in another PR, let's keep this one to just release
08:40 < stevenroose> Cool.
08:40 < stevenroose> updated
08:49 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
08:58 < elichai2> Could we have #298 be included in the new release?
09:00 < dongcarl> elichai2: I think andytoshi was saving that for 0.20
09:00 < elichai2> stevenroose: I like the single line dependencies, because then if you change a feature of a dep you can see in the commit the dependency you edited (because it's one line)
09:00 < elichai2> dongcarl: oh. any specific reason?
09:01 < dongcarl> I would guess so that people can use the features destined for 0.19 without upgrading the dependencies? I'm probably wrong and we should wait till andytoshi is online
09:09 < stevenroose> elichai2, dongcarl: it's because it's impossible to depend on two crates that use a different rust-secp version.
09:10 < stevenroose> So we want to relase 0.19 to give all the new features for people that want the current secp version and then update only the secp dependency in 0.20 for the people that want to upgrade secp
09:10 < stevenroose> I think the same counts for consensus.
09:12 < elichai2> ok
10:26 < andytoshi> good morning all
10:27 < andytoshi> yes, secp updates need to happen in individual major releases
10:27 < andytoshi> because they require users update everything all at once
10:27 < andytoshi> because you can't have multiple different major secp versions at once
10:30 < andytoshi> reviewing #314
10:30 < andytoshi> https://github.com/rust-bitcoin/rust-secp256k1/issues/150 :(
10:41 < andytoshi> stevenroose: can you add a point to #314 indicating the major version bumps of all deps?
10:41 < andytoshi> bitcoin_hashes and rand i think
10:41 < andytoshi> but i'm not certain
10:49 < elichai2> andytoshi: the dev-dependencies bug is so annoying
10:49 < elichai2> what the hell
10:53 < andytoshi> yep
11:01 < andytoshi> can we quickly ack https://github.com/rust-bitcoin/rust-bitcoin/pull/315 and get it in before 0.19?
11:04 < stevenroose> ACKd
11:05 < stevenroose> merged too
11:05 < andytoshi> need one more review of https://github.com/rust-bitcoin/rust-bitcoin/pull/314
11:05 < stevenroose> yolo first time I merge something in rust-bitcoin. Usually leave that to you
11:07 < elichai2> FYI I checked and Tony is right. so not all is bad lol
11:09 < andytoshi> nice :)
11:09 < andytoshi> i just pattern-matched to that cargo issue because i remember it causing me a lot of trouble with dev-deps
11:19 -!- windsok [~windsok@rarepepe.cash] has quit [Quit: No Ping reply in 180 seconds.]
11:19 -!- windsok [~windsok@rarepepe.cash] has joined #rust-bitcoin
11:19 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host]
11:19 -!- windsok [~windsok@unaffiliated/windsok] has joined #rust-bitcoin
11:29 < andytoshi> guyyyyyyys we need another ack on 314
11:29 < andytoshi> dongcarl BlueMatt
11:29 < andytoshi> dpc? not sure if you have approval rights
11:30 < dongcarl> k looking
11:57 < dongcarl> stevenroose: how r u isloating post-0.18 commits/PRs?
11:58 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
12:19 < stevenroose> dongcarl: uhm.. git log and /0.18.0 and then scroll up :D
12:20 < stevenroose> Not gonna say it's impossible I missed something, but if commits appear pre-0.18 at least their merge commits appear after and I didn't see any merge commits without their respecitve member commits. I can always have missed something, though..
12:20 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
12:22 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
12:23 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:24 < dongcarl> Ship it
12:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds]
12:24 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
12:24 < stevenroose> whohoooow
12:29 < andytoshi> merged
12:30 < andytoshi> tag pushed
12:30 < andytoshi> published
12:31 < andytoshi> lol now https://github.com/rust-bitcoin/rust-bitcoin/pull/298 needs a rebase
12:43 < andytoshi> oh, damn, i thought we re-exported bech32
12:45 < elichai2> no it was only hashes and secp iirc
12:47 < andytoshi> if someone is so inclined as to export bech32, that'd be cool..
12:47 < andytoshi> and bump to 0.19.1
12:49 < elichai2> We have a bigger problem
12:49 < elichai2> "Minimum supported rustc version is 1.31"
12:49 < andytoshi> where's that?
12:49 < elichai2> https://github.com/alexcrichton/proc-macro2/commit/5fd7e8d3c2a4fe88865c2d54abae4a21cbd8640e
12:49 < elichai2> serde-derive
12:50 < elichai2> they published 4 hours ago https://crates.io/crates/proc-macro2
12:50 < andytoshi> in a minor version?
12:50 < andytoshi> what the actual fuck?
12:52 < elichai2> that is really weird. the only place in the readme where they talk about compiler versions is in the nightly section
12:53 < andytoshi> what's also weird is that the change between 1.0.0 and 1.0.1 doesn't do much beyond adding a warning
12:53 < andytoshi> and the commit suggests that this never worked
12:54 < elichai2> ok. apperantly it's serde-derive fault
12:54 < elichai2> he published a new minor version while bumping a major proc-macro2
12:54 < elichai2> https://github.com/serde-rs/serde/blob/v1.0.98/serde_derive/Cargo.toml
12:54 < elichai2> https://github.com/serde-rs/serde/blob/v1.0.99/serde_derive/Cargo.toml
13:01 < andytoshi> patch version even
13:02 < andytoshi> w/e we can just pi
13:02 < dongcarl> :man-facepalming:
13:02 < andytoshi> but wtf
13:04 < elichai2> yep
13:04 < elichai2> we'll see what dtolnay will say but I can probably guess.... https://github.com/serde-rs/serde/issues/1602
13:06 < elichai2> i'll open a PR pinning, exporting and bump to 0.19.1. wanna yank 0.19.0?
13:07 < andytoshi> all old versions are affected
13:07 < andytoshi> thanx for being polite in the issue
13:08 < elichai2> yeah this discussion is exhausting
13:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
13:20 < elichai2> andytoshi: didn't you say only a week ago that serde never broke our code? 😜
13:22 < stevenroose> andytoshi: Ah damn yeah the bech32::Error type is used. Sorry.
13:24 < andytoshi> elichai2: yeah. its like they did it to spite me
13:26 < stevenroose> Pff, there *REALLY* should be a field in Cargo for the compiler version you're supposed to support so that it can't accidentally be broken.
13:26 < stevenroose> Because these people don't seem to care about CI for some reason.
13:29 < stevenroose> dpc: how is that software vetting tool going that you were working on?
13:32 < elichai2> stevenroose: https://internals.rust-lang.org/t/adding-compiler-version-to-dependency-resolution/10795
13:43 < stevenroose> elichai2: cool, the practical limitation though is that cargo can't know which version some code is compatible with.
13:43 < stevenroose> What could be possible is that all crates have a minimum version and then it could error if a dependent crate has a higher one.
13:43 < stevenroose> But that'd be blindly trusting the value in the Cargo.toml file, which is not ideal.
14:02 -!- reallll is now known as belcher
14:13 < andytoshi> what does elichai2's link say? it's completely blank for me, just like all internals threads now
14:17 < elichai2> Yeah their forum is filled with js
14:18 < elichai2> Suggestion to add minimum compiler version to cargo.toml with support by the dependency resolver
14:18 < elichai2> stevenroose: the same is true for the semver rules we need to kind of trust lib developers
14:20 < stevenroose> elichai2: how so? ah whether they are breaking or not. true dat
14:23 < andytoshi> it will probably cut down on the number of people claiming "it's not a breaking change if it totally breaks compilation"
15:51 < andytoshi> man, the lack of a generic Vec<T> Encodable impl is really annoying for rust-elements
16:10 < andytoshi> curiously, you can see at https://travis-ci.org/serde-rs/serde/builds/572886513 that they tested this on a zillion rustc versions
16:10 < andytoshi> but the CI tests were insufficient
17:09 < dpc> <stevenroose "dpc: how is that software vettin"> It's quite featureful and convenient to use already. I got some people interested in it, and helping. Someone is working on a npm port https://www.npmjs.com/package/crev , etc. Last few weeks there wasn't much progress though because I was on vacation, and generally I got a bit burned-out of open source work. I have too much things going on right now, and I need to get some
17:09 < dpc> rest. I'll get back to improving it when I recover. Though it is usable and feeback is always appreciated.
17:44 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
17:58 -!- cypherpunk2140 [~cypherpun@gateway/tor-sasl/cypherpunk2140] has joined #rust-bitcoin
18:06 -!- cypherpunk2140 [~cypherpun@gateway/tor-sasl/cypherpunk2140] has quit [Remote host closed the connection]
18:07 -!- cypherpunk2140 [~cypherpun@gateway/tor-sasl/cypherpunk2140] has joined #rust-bitcoin
18:07 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-gwpzuvjzenerifyu] has quit [Quit: Connection closed for inactivity]
18:10 -!- cypherpunk2140 [~cypherpun@gateway/tor-sasl/cypherpunk2140] has quit [Client Quit]
19:46 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
19:56 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection]
19:57 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #rust-bitcoin
--- Log closed Sat Aug 17 00:00:48 2019