--- Log opened Fri Aug 23 00:00:51 2019
06:24 -!- neonknight64 [~neonknigh@195.159.29.126] has joined #rust-bitcoin
07:31 < dongcarl> Hi all, what needs review?
07:32 < dongcarl> kallewoof: I'll review your Signet support today
07:47 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-vohqmufybdifcwge] has quit []
07:47 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-xuurqbzdynbubgql] has joined #rust-bitcoin
07:56 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-xuurqbzdynbubgql] has quit [Changing host]
07:56 -!- schmidty_ [sid297174@unaffiliated/schmidty] has joined #rust-bitcoin
07:56 -!- schmidty_ [sid297174@unaffiliated/schmidty] has quit [Changing host]
07:56 -!- schmidty_ [sid297174@gateway/web/irccloud.com/x-xuurqbzdynbubgql] has joined #rust-bitcoin
07:56 -!- schmidty_ is now known as schmidty
08:17 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
08:17 < dongcarl> kallewoof: reviewed and added links to relevant code in your Core PR, hopefully that's not too annoying
09:58 < TamasBlummer> if nothing else needs to go to 0.19, then https://github.com/rust-bitcoin/rust-bitcoin/pull/298
09:58 < TamasBlummer> dongcarl: ^
10:00 < dongcarl> TamasBlummer: 0.20 you mean :-)
10:01 < TamasBlummer> I mean that PR bumps the cargo version to 0.20, so it should be merged only after nothing else needs to go to 0.19
10:02 < dongcarl> TamasBlummer: Ah true.
10:02 < dongcarl> stevenroose ? andytoshi ?
10:50 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-syqpnvnyavzdefpc] has joined #rust-bitcoin
10:51 < elichai2> Starting to look good :) https://github.com/rust-lang/rust/issues/34902#issuecomment-524391998
11:15 < BlueMatt> noice
11:16 < andytoshi> dongcarl: i believe we are good to go for 0.20
11:16 < andytoshi> elichai2: very interesting
11:16 < andytoshi> i wonder what he means by "with gcc 8". i guess he measn the LLVM component?
11:17 < andytoshi> I think that once rustc can be built reproducibly, and mrustc can built something close to whatever the reproducable version is, and debian is shipping that version, it may make sense to do a rust-bitcoin-wide bump to that version
11:17 < andytoshi> even if it's fairly new
11:17 < dongcarl> Merging 298 now
11:17 < andytoshi> sounds good
11:18 < andytoshi> uh actually
11:18 < andytoshi> give me 2 minutes to check it over
11:18 < andytoshi> lol too late
11:18 < dongcarl> Lol
11:18 < andytoshi> anyway i looked at it a couple days ago, i'm sure it's fine
11:18 < dongcarl> Uh...
11:18 < dongcarl> I mean we didn't publish
11:18 < BlueMatt> here's to getting rust into bitcoin core :)
11:18 < andytoshi> mainly i wanted to make sure that the secp256k1 `rand` feature thing was fixed, but it is
11:18 < dongcarl> So yeah take a look
11:19 < andytoshi> ok, yeah, and i'm not thrilled with `use secp256k1::rand::prelude::*;` but i'm not gonna hold anything up over that :)
11:19 < dongcarl> Yeah, we can tidy that up later
11:19 < andytoshi> tag pushed. publishing..
11:21 < andytoshi> sanket1729: i guess we need to bump rust-miniscript to the new version (which should be a no-op change). i'd like to get my other analysis PRs in first though (am boarding a plane in an hour, maybe i can write the code there..)
11:21 < andytoshi> stevenroose: ditto for rust-elements, though i don't think there's anything holding that up
12:14 < elichai2> andytoshi: I think he talks about the compiler bullitins, some of them are still written in C
13:26 < TamasBlummer> BlueMatt: I heard you are a testnet whale. Would you please send me some coins to 2NDZR2H1FURPN31dhUWrJ1HUQxVDJK4cWwx
13:26 < TamasBlummer> thanks a lot
13:46 < BlueMatt> matt@testnet-seednode:~$ ~/bitcoin-cli sendtoaddress 2NDZR2H1FURPN31dhUWrJ1HUQxVDJK4cWwx 100
13:46 < BlueMatt> 1b7e7ca7d56f07c34a7458d40620189bb81726ce8e584894bad6c965f0e24f32
13:46 < BlueMatt> dont spend it all in one place, now :p
13:47 < elichai2> real_or_random: I wrote an example for what we've been talking about, and the concurrency problem is a bit of a problem with testing this feature :/
13:47 < elichai2> because rust's tests are concurrent
14:12 < TamasBlummer> BlueMatt: thanks a lot. You also run an address seed node for the bitcoin network. I consider setting up something similar for a related network (side memory as I discribed on the dev list). Would yuo please point me to the source code of that crawler and if there is some doc how it is set up?
14:15 < BlueMatt> TamasBlummer: there are several crawlers, there's sipa's at https://github.com/sipa/bitcoin-seeder which is free-standing and has docs, and mine at https://github.com/TheBlueMatt/dnsseed-rust/ which generates zonefiles and is somewhat specific to my setup and has no docs :p
14:16 < TamasBlummer> thank you. I see you really have a nice stash of tBTC. satoshi was less greedy
14:17 < BlueMatt> lol, well I stole all those coins from someone else
14:17 < BlueMatt> who had a big wallet and was too lazy to fix the wallet
14:18 < BlueMatt> so I fixed it and stole all the coins :)
14:52 < elichai2> real_or_random: I gave what we talked about a try, would love your feedback :) https://github.com/rust-bitcoin/rust-secp256k1/pull/154
15:13 < BlueMatt> andytoshi: actually, I'd really prefer *not* to bump the required rustc version
15:13 < BlueMatt> andytoshi: I want to move towards using rust-bitcoin in bitcoin core sooner or later
15:13 < BlueMatt> and that is gonna require we not bump the required rustc version, even if we can build a later version with mrustc
16:28 < elichai2> BlueMatt: ariard, how do I create a `LocalFeatures` instance? it seemingly has no functions
17:33 < andytoshi> BlueMatt: sgtm
17:44 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
17:47 -!- TamasBlummer1 [~Thunderbi@p200300DD67126409DCB9023D048E1FB1.dip0.t-ipconnect.de] has joined #rust-bitcoin
17:49 -!- TamasBlummer [~Thunderbi@p200300DD671264878C7302FDBC80AE47.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
17:49 -!- TamasBlummer1 is now known as TamasBlummer
17:58 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
20:30 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-syqpnvnyavzdefpc] has quit [Quit: Connection closed for inactivity]
20:40 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-joxtcxnuaoqsficw] has joined #rust-bitcoin
21:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
21:22 < ariard> elichai2: grep 'set_initial_routing_sync', you should see an example in peer_handler
21:22 < ariard> or you want to create your own custom local features ? If yes you need to add setters
--- Log closed Sat Aug 24 00:00:50 2019