--- Log opened Wed Sep 04 00:00:00 2019 00:41 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 00:45 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 01:15 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 01:16 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 02:01 -!- Blackwolfsa [~Blackwolf@195.159.29.126] has quit [Quit: Leaving] 02:01 -!- stanimal [~stanimal@195.159.29.126] has quit [Quit: Leaving] 02:01 -!- CjS77 [~caylemeis@195.159.29.126] has quit [Quit: Leaving] 02:01 -!- simian_za [~simian_za@195.159.29.126] has quit [Quit: Leaving] 02:01 -!- neonknight644 [~neonknigh@195.159.29.126] has quit [Quit: Leaving] 02:03 -!- neonknight644 [~neonknigh@195.159.29.126] has joined #rust-bitcoin 02:04 -!- CjS77 [~caylemeis@195.159.29.126] has joined #rust-bitcoin 02:04 -!- Blackwolfsa [~Blackwolf@195.159.29.126] has joined #rust-bitcoin 02:04 -!- stanimal [~stanimal@195.159.29.126] has joined #rust-bitcoin 02:35 < Relaed> BlueMatt: https://circleci.com/gh/YaaMe/rust-lightning-bitcoinrpc/179 02:35 < Relaed> integration test passed for the first time on circleci, but there are still many problems to solve. 02:37 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 02:45 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 03:06 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 05:07 -!- stanimal [~stanimal@195.159.29.126] has quit [Quit: Leaving] 05:07 -!- Blackwolfsa [~Blackwolf@195.159.29.126] has quit [Quit: Leaving] 05:07 -!- neonknight644 [~neonknigh@195.159.29.126] has quit [Quit: Leaving] 05:07 -!- CjS77 [~caylemeis@195.159.29.126] has quit [Quit: Leaving] 05:08 -!- neonknight644 [~neonknigh@195.159.29.126] has joined #rust-bitcoin 05:08 -!- simian_za [~simian_za@195.159.29.126] has joined #rust-bitcoin 05:08 -!- stanimal [~stanimal@195.159.29.126] has joined #rust-bitcoin 05:08 -!- Blackwolfsa [~Blackwolf@195.159.29.126] has joined #rust-bitcoin 05:08 -!- CjS77 [~caylemeis@195.159.29.126] has joined #rust-bitcoin 05:22 -!- neonknight644 is now known as neonknight64 06:29 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 06:32 -!- ccdle12_ [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 06:32 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Read error: Connection reset by peer] 08:03 < BlueMatt> Relaed: cool! I assume this is just its own integration tests, not the lightning cross-implementation integration test stuff (you should ping jtimon about that, btw) 09:57 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ufvkznlaonkupsdy] has joined #rust-bitcoin 10:21 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Ping timeout: 276 seconds] 11:22 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 245 seconds] 12:00 < andytoshi> stevenroose: what do you think of https://github.com/rust-bitcoin/rust-bitcoin/pull/325 ? 12:00 < andytoshi> BlueMatt: do you have any opposition in principle to using the semver trick to expose some 0.19 types in 0.18? 12:01 < BlueMatt> what do you mean "expose some 0.19 types in 0.18?"? 12:01 < BlueMatt> in principle no? 12:01 < BlueMatt> oh I see the cargo.toml thing 12:02 < andytoshi> BlueMatt: i mean have 0.18.1 depend on 0.19 and re-export some types that didn't change 12:02 < BlueMatt> lol thats....weird 12:02 < andytoshi> yeah 12:02 < BlueMatt> yea, I mean in principle I have no objection 12:03 < BlueMatt> feels gross but we have a good enough grasp on who our users are to know that its actually useful for people and there probably isnt anyone stuck on 18 who is gonna be sad by the (I presume) bigger binary size 12:03 < andytoshi> ok, awesome. i was careful not to break anything (and i got away with barely removing any tests, which was fortunate because sometimes they depend on private fields) 12:03 < andytoshi> yeah, it is gross, but it makes the upgrade path a little smoother 12:03 < BlueMatt> right 12:04 < andytoshi> in particular i -think- this will let liquid update its miniscript dependency (which is a big messy thing) without first updating its bitcoin dependency (which is a separate messy thing) 12:05 < BlueMatt> right, I figured you had some more specific use 12:05 < BlueMatt> fine with me if you have one 12:05 < BlueMatt> upgrade isnt really gonna be painful for any of my shit 12:06 < elichai2> cool trick, but maybe maintain it in a different branch? (i.e. how should they live together in the git?) 12:06 < andytoshi> elichai2: there'll be a 0.18.1 tag that'll point to it 12:07 < elichai2> this still requires downstream to update cargo.lock's, right? 12:07 < andytoshi> yes 12:07 < andytoshi> but it will be a minor version bump so `cargo update` will do it 12:07 < BlueMatt> you can always depend on exactly 0.18 12:14 < stevenroose> andytoshi: shouldn't your semver trick PR be made in a separate 0.18 branch? 12:15 < stevenroose> Otherwise we lose track of the 0.19 branch (current master), right? 12:15 < andytoshi> this has nothing to do with 0.19 12:15 < andytoshi> and it is not a PR, i just made a PR because github does not let you comment on branches otherwise 12:15 < stevenroose> ah it's not a PR, k 12:16 < stevenroose> you could PR it to a branch we maintain for 0.18.x releases, is what I'm saying 12:16 < andytoshi> sure, i could do that 12:16 < andytoshi> i was planning to just leave it as a dangling tag 12:16 < stevenroose> so that at least there is a public branch on the rust-bitcoin repo for every release 12:16 < andytoshi> there is a tag for every release 12:16 < stevenroose> oh you can make a tag in a repo pointing to a commit on a remote repo? 12:17 < andytoshi> ? 12:17 < andytoshi> you can make a tag pointing to whatever you want 12:18 < stevenroose> ah you're planning to git push the branch to rust-bitcoin and that will push the required commits as well? 12:18 < stevenroose> hmm, never done that, but that should work 12:18 < andytoshi> anyway i changed to PR to a branch 12:18 < andytoshi> if you push tags it will also push the commits, yes 12:18 < stevenroose> I guess in this situation we can assume we won't need to do a similar trick for another later version, so we won't need to be messing around with building on top of that tag later 12:19 < stevenroose> so yeah sure if there is a dangling tag in rust-bitcoin that's fine 12:20 < andytoshi> i changed it to push to a branh 12:20 < andytoshi> to avoid any confusion 12:20 < stevenroose> andytoshi: did you check for post-0.18 bugfixes to potentially include? 12:21 < andytoshi> i did not 12:22 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 12:22 < stevenroose> can't remember any, though 12:22 < stevenroose> I guess if there were, they should have been backported already anyway :) 12:22 < andytoshi> should have been :) 12:22 < andytoshi> but actually i don't think we've backported anything ever 12:23 < andytoshi> we really should. but things are moving really fast still 12:25 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 12:26 < andytoshi> ok, i'm gonna merge this 12:26 -!- reallll is now known as belcher 12:29 < andytoshi> dammit, i broke the API, may have to revert 12:30 < andytoshi> PublicKey::from_slice returns a Result<_, consensus::encode::Error> 12:30 < andytoshi> so apparently you need the new encoding changes just to update the PublicKey type :( 12:35 < andytoshi> and we modified that error type in 0.19 so i can't just re-export it 12:39 < andytoshi> stevenroose: can you ack https://github.com/rust-bitcoin/rust-bitcoin/pull/326 ? this undoes the re-export 12:40 < andytoshi> what a mess 13:32 -!- justinmoon [~manjaro-i@072-182-058-035.res.spectrum.com] has joined #rust-bitcoin 14:15 -!- justinmoon [~manjaro-i@072-182-058-035.res.spectrum.com] has quit [Ping timeout: 245 seconds] 14:20 -!- justinmoon [~manjaro-i@23.228.172.124] has joined #rust-bitcoin 14:20 < justinmoon> ##hwi 14:22 < stevenroose> justinmoon: second time I had your nickname confused with justmoon (IRC handle of Stephan Thomas) 14:24 -!- ccdle12_ [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 245 seconds] 14:30 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 14:56 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 14:58 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #rust-bitcoin 15:05 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 258 seconds] 15:33 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 15:39 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 15:48 < justinmoon> lol 15:48 < justinmoon> (excuse me while i learn how irc works) 15:56 -!- justinmoon [~manjaro-i@23.228.172.124] has quit [Ping timeout: 268 seconds] 16:36 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 16:41 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 245 seconds] 16:54 -!- ircEX1352 [~ircex@2001:240:2416:501b:c5d4:8f67:fd08:eed7] has joined #rust-bitcoin 16:58 -!- ircEX1352 [~ircex@2001:240:2416:501b:c5d4:8f67:fd08:eed7] has quit [Ping timeout: 250 seconds] 17:30 -!- TamasBlummer1 [~Thunderbi@p200300DD6712647058DD267A87CD9F8E.dip0.t-ipconnect.de] has joined #rust-bitcoin 17:32 -!- TamasBlummer [~Thunderbi@p200300DD6712645885AB2A14082737EB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 17:32 -!- TamasBlummer1 is now known as TamasBlummer 17:48 < Relaed> BlueMatt: I see. We modified some of your code in rust-lightning-bitcoin-rpc. Upgraded Futures to std::futures, and put it into a server. The tests running on circleci, is basically the happy route scenario where invoices gets generated between two lightning nodes with 3 Bitcoind in regtest mode. 18:01 -!- justinmoon [~manjaro-i@2605:6000:1018:46a::d30] has joined #rust-bitcoin 18:38 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 19:11 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 246 seconds] 20:47 < ariard> Relaed: I was thinking of splitting rust-lightning-bitcoin-rpc in some PoC multiple daemons, like p2pd, channel_managerd, watchtowerd, routerd, do you think that would be compatible with your current re-design ? 20:47 < Relaed> ariard: we are trying to put this into Substrate, so probably. 20:47 < ariard> it should be easy to share a routerd between different channel_managerd or plug multiple watchtowerd 20:48 < Relaed> You can use any runtime (though currently only tokio is available) you like. 20:49 < Relaed> ariard: let me think about splitting rust-lightning-bitcoin-rpc into more PoC daemons for a while. 20:49 < ariard> hmm dunno about Substrate, what's best doc to use any runtime 20:50 < ariard> Relaed: don't worry not stress on this one, just would be an awesome showcase 20:51 < Relaed> ariard: k, currently we are writing docs and readme for what we did. 20:53 < ariard> Relaed: ok interested, I've tried to run rustbolt last night but blocked on the lack of settings format doc 21:07 < Relaed> We are working on it. https://github.com/YaaMe/rust-lightning-bitcoinrpc/blob/futures-17/test/integration/main.py 21:08 < Relaed> Link above is the testing script. 21:09 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 21:41 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 245 seconds] 22:50 < elichai2> apparently some of the rust team met with google,facebook and some other companies and talked about what's missing in rust and they talked also about bootstraping :) 22:50 < elichai2> https://gist.github.com/rylev/0e3c3895dcb40b6a1c1cf8c427c01b5e?fbclid=IwAR0nGqahzJvuOtig39tlS1BXmxlg0IRAC3ib9dnM-ouQYOPwN46tWB8O5CM 22:50 < elichai2> (seems that google also bootstraps from mrustc) 23:01 < Relaed> "cargo vendor tends to be a bit overagressive", lol 23:07 < elichai2> mostly seems like they really don't like cargo haha 23:09 < Relaed> it's like they built yarn for nodejs 23:09 < Relaed> now they want to do the same. 23:10 < elichai2> real_or_random: they're complaining about the fact that they have a testing feature and "sometimes testing gets turned on semi-randomly (???)", "but you can also accidentally use "testing" in a normal tree" 23:10 < elichai2> ahem #154 23:38 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin --- Log closed Thu Sep 05 00:00:01 2019