--- Log opened Fri Nov 29 00:00:22 2019
01:48 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has joined #rust-bitcoin
01:59 -!- dr-orlovsky [~dr-orlovs@2a02:1205:500f:2e90:d08:949d:9420:76eb] has joined #rust-bitcoin
02:01 -!- jonatack__ [~jon@37.170.46.209] has joined #rust-bitcoin
02:04 -!- jonatack_ [~jon@37.170.165.151] has quit [Ping timeout: 250 seconds]
02:52 -!- dr-orlovsky [~dr-orlovs@2a02:1205:500f:2e90:d08:949d:9420:76eb] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
03:03 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has quit [Read error: Connection reset by peer]
03:03 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has joined #rust-bitcoin
05:27 -!- jonatack__ [~jon@37.170.46.209] has quit [Read error: Connection reset by peer]
05:27 -!- dr-orlovsky [~dr-orlovs@169.204.90.212.static.wline.lns.sme.cust.swisscom.ch] has joined #rust-bitcoin
06:33 -!- jonatack__ [~jon@37.170.46.209] has joined #rust-bitcoin
06:37 -!- jonatack__ [~jon@37.170.46.209] has quit [Client Quit]
06:37 -!- jonatack [~jon@37.170.46.209] has joined #rust-bitcoin
08:10 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin
08:10 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
08:10 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
08:33 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:4917:e290:2dcb:bde1] has joined #rust-bitcoin
08:34 < dr-orlovsky> Hi all, some time ago we have discussed implementation of the new hash types (like Txid, Wtxid etc) and now I do have a good progress on this matter: https://github.com/rust-bitcoin/rust-bitcoin/pull/349. However, in order to complete the job, it is required to accept two PRs fixing hash_newtype in bitcoin_hashes: first https://github.com/rust-bitcoin/bitcoin_hashes/pull/64 (fixing compiler errors) and
08:34 < dr-orlovsky>  second https://github.com/rust-bitcoin/bitcoin_hashes/pull/63 fixing the macro itself. Can you help with the review of these PRs?
09:01 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:4917:e290:2dcb:bde1] has quit []
09:08 -!- dr-orlovsky [~dr-orlovs@169.204.90.212.static.wline.lns.sme.cust.swisscom.ch] has quit [Ping timeout: 245 seconds]
09:10 -!- dr-orlovsky [~dr-orlovs@128-124-89-64.mobile.vf-ua.net] has joined #rust-bitcoin
09:20 -!- dr-orlovsky [~dr-orlovs@128-124-89-64.mobile.vf-ua.net] has quit [Read error: Connection reset by peer]
09:37 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:4917:e290:2dcb:bde1] has joined #rust-bitcoin
09:37 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:4917:e290:2dcb:bde1] has quit [Read error: Connection reset by peer]
09:39 -!- dr-orlovsky [~dr-orlovs@128-124-89-64.mobile.vf-ua.net] has joined #rust-bitcoin
09:41 -!- dr-orlovsky [~dr-orlovs@128-124-89-64.mobile.vf-ua.net] has quit [Read error: Connection reset by peer]
10:58 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has quit [Ping timeout: 276 seconds]
11:11 -!- dr-orlovsky [~dr-orlovs@2a02:1205:500f:2e90:4ce9:9687:b6b3:dc52] has joined #rust-bitcoin
12:20 < andytoshi> yeah i'll review them
12:20 < andytoshi> and also merge the byteorder PRs i told matt i'd merge a week ago..
12:25 < dr-orlovsky> thanks!
13:21 < andytoshi> 64 in
13:21 < andytoshi> 63 needs to be rebased then?
13:27 < andytoshi> BlueMatt: thoughts on making elichai2 a rust-bitcoin maintainer so his acks count?
13:31 < andytoshi> stevenroose: you are blorkisc welce og https://github.com/rust-bitcoin/rust-bitcoin/pull/337
13:31 < dr-orlovsky> andytoshi: done
13:34 < andytoshi> ok, ack pending CI
14:01 -!- jonatack_ [~jon@37.173.18.95] has joined #rust-bitcoin
14:03 -!- jonatack_ [~jon@37.173.18.95] has quit [Read error: Connection reset by peer]
14:04 < dr-orlovsky> andytoshi: strange, it fails now b/c of the last merge in the master:use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
14:04 -!- jonatack [~jon@37.170.46.209] has quit [Ping timeout: 268 seconds]
14:04 < dr-orlovsky> it's about byteorder
14:05 < dr-orlovsky> it also fails on the master: https://travis-ci.org/rust-bitcoin/bitcoin_hashes
14:08 < andytoshi> o.O
14:09 < andytoshi> lemme see, i think this is a merge failure
14:09 < andytoshi> `extern crate byteorder` without a Cargo.toml entry
14:09 < dr-orlovsky> seems so
14:09 < andytoshi> want to add a fixing commit to your PR? or should i PR?
14:09 < dr-orlovsky> I can add it now
14:10 < andytoshi> hmmm i don't see it in master actually
14:11 < dr-orlovsky> very strange, maybe Travis puts me directly on my PR, which is strange...
14:11 < dr-orlovsky> I see it here: https://travis-ci.org/rust-bitcoin/bitcoin_hashes
14:12 < andytoshi> hmm
14:12 < andytoshi> not here https://github.com/rust-bitcoin/bitcoin_hashes/blob/master/src/lib.rs
14:12 < andytoshi> i'm gonna clear caches and restart travis
14:12 < dr-orlovsky> strange, master builds for me locally
14:13 < andytoshi> yeah, ditto, the offending line seems to just not exist
14:13 < andytoshi> cleared caches and restarted the travis run. we'll see
14:13 < dr-orlovsky> maybe Travis got crazy
14:13 < dr-orlovsky> thanks
14:15 < dr-orlovsky> still the same (I do see it in the log already): use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
14:16 < andytoshi> god why is this project such a chore
14:16 < andytoshi> investigating
14:16 < dr-orlovsky> me too
14:19 < dr-orlovsky> it could be the problem of my merge
14:19 < dr-orlovsky> I have kept the byteorder crate while doing the merge
14:19 < andytoshi> oh yep i see it on your merge commit
14:20 < andytoshi> ok cool. pls fix :)
14:20 < dr-orlovsky> fixed and force-pushed
14:20 < andytoshi> dope
14:23 -!- TamasBlummer1 [~Thunderbi@p200300DD67126434E996A8988D3F40FA.dip0.t-ipconnect.de] has joined #rust-bitcoin
14:24 < dr-orlovsky> sorry, the original pr was created before the byteorder was introduced and I have not paid attention that the BlueMatt's PR actually have removed it; and when have seen in the diff decided that it is something added, not removed
14:24 < andytoshi> yeah sorry, i merged a buch of stuff all at once
14:25 < andytoshi> i don't usually get a US quasi-holiday on which nobody is phoning me so i try to take advantage :P
14:25 -!- TamasBlummer [~Thunderbi@p200300DD671264329D69360EED605E75.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
14:25 -!- TamasBlummer1 is now known as TamasBlummer
14:47 < dr-orlovsky> andytoshi: don't worry, we missed you, but you have clearly deserved a time out of the phone calls and chats. Btw I hate phone calls may be even more than you :)
14:47 < dr-orlovsky> the CI is done, now it's working
14:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
14:54 < andytoshi> ok merged
14:54 < andytoshi> do you remember offhand if we need a major or minor version bump?
14:55 < dr-orlovsky> For bitcoin_hashes? Don't know, but taking into the account the amount of merged PRs it seems to be a major....
14:55 < andytoshi> yeah pretty sure
14:55 < andytoshi> ok i'll go over it and make a release pr
14:57 -!- jonatack [~jon@37.173.18.95] has joined #rust-bitcoin
15:04 < andytoshi> actually all we have are 62 64 65 and 66 since 0.7.1
15:04 < andytoshi> 62 is nonbreaking
15:04 < andytoshi> 66 is travis only (so nonbreaking)
15:05 < dr-orlovsky> May be a working version of the hash_newtype macro by itself deserves the major version :D :D
15:05 < andytoshi> 64 is your doccomment fixes (nonbreaking)
15:05 < andytoshi> lol possibly
15:05 < andytoshi> 65 drops byteorder, i'm pretty sure it had no API changes, so nonbreaking
15:05 < dr-orlovsky> I mean before it it was just SHA256, RIPEMD160, their combination and HMAC's on top. But now, the whole Universe of the derived types had appeared, LOL
15:06 < andytoshi> which leaves only 63
15:06 < andytoshi> right , but if all we did was add types, that's nonbreaking :P
15:06 < andytoshi> even if we tripled the size of the lib
15:06 < dr-orlovsky> agree, softfork :)
15:06 < dr-orlovsky> i.e. minor version
15:07 < andytoshi> so, when you say it "wasn't working" before you mean there was no way to make it compile?
15:07 < andytoshi> it'd always try to use non-exported macros and fail?
15:07 < dr-orlovsky> well, there were no compiling implementation for the use of the macro. When I tried to do one and embedd into rust-bitcoin it was not compile b/c of complex macro export problems and crate uses
15:09 < dr-orlovsky> actually it have take a while for me to figure that all out and find a way to bring it so something in rust-bitcoin which is compiling with the use of the new hash types - and it had required some significant changes to the original macro code
15:15 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 252 seconds]
15:44 -!- jonatack [~jon@37.173.18.95] has quit [Quit: jonatack]
15:53 -!- jonatack [~jon@37.173.18.95] has joined #rust-bitcoin
16:33 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has joined #rust-bitcoin
17:03 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
17:23 -!- nijynot [~nijynot@h-177-96.A785.priv.bahnhof.se] has quit [Ping timeout: 276 seconds]
19:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer]
19:21 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Read error: Connection reset by peer]
19:21 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Read error: Connection reset by peer]
19:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
19:23 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
20:03 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
23:42 -!- jonatack [~jon@37.173.18.95] has quit [Read error: Connection reset by peer]
--- Log closed Sat Nov 30 00:00:23 2019