--- Log opened Sun Dec 22 00:00:47 2019 02:29 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 03:09 -!- jonatack [~jon@213.152.161.149] has joined #rust-bitcoin 03:24 -!- jonatack [~jon@213.152.161.149] has quit [Ping timeout: 265 seconds] 03:26 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #rust-bitcoin 03:35 -!- Kiminuo [~mix@141.98.103.100] has joined #rust-bitcoin 03:35 -!- Kiminuo [~mix@141.98.103.100] has quit [Read error: Connection reset by peer] 03:36 -!- Kiminuo [~mix@141.98.103.100] has joined #rust-bitcoin 03:45 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 03:47 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 04:03 < elichai2> argghh I didn't mean to just megre https://github.com/rust-bitcoin/rust-bitcoin/pull/367. I'm almost 100% sure it's correct but wanted to leave it for another review for someone who's more familiar with the p2p @BlueMatt 04:04 < elichai2> (I did test it locally, compare against the BIP, and against the PR in core) 05:01 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Excess Flood] 05:01 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #rust-bitcoin 05:10 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 268 seconds] 05:12 -!- jonatack [~jon@37.170.160.25] has joined #rust-bitcoin 05:42 -!- jonatack [~jon@37.170.160.25] has quit [Read error: Connection reset by peer] 07:22 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 08:25 -!- dr-orlovsky [~dr-orlovs@91.240.140.128] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 08:48 < andytoshi> it's probably fine 08:49 < andytoshi> similar story with https://github.com/rust-bitcoin/rust-bitcoin/pull/368 ... for things that are basically just adding constants that need to match core it's probably better to get them in so the people who need them can use them 08:49 < andytoshi> and if tehy're wrong that will be very visible 08:49 < andytoshi> and easy to fix 08:49 < andytoshi> i mean, we should definitely still review them 08:49 < andytoshi> but steven's review is probably sufficient 08:52 < elichai2> +1 still getting used to the responsibility ? pretty scary things hehe 08:54 < andytoshi> yeah, i feel you 09:08 -!- dr-orlovsky [~dr-orlovs@46-133-190-155.mobile.vf-ua.net] has joined #rust-bitcoin 09:13 -!- dr-orlovsky [~dr-orlovs@46-133-190-155.mobile.vf-ua.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] --- Log closed Sun Dec 22 09:34:29 2019 --- Log opened Sun Dec 22 09:34:29 2019 --- Log closed Sun Dec 22 09:44:03 2019 --- Log opened Sun Dec 22 09:44:03 2019 10:13 -!- dr-orlovsky [~dr-orlovs@91.240.140.128] has joined #rust-bitcoin 10:36 -!- dr-orlovsky [~dr-orlovs@91.240.140.128] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 10:40 -!- dr-orlovsky [~dr-orlovs@91.240.140.128] has joined #rust-bitcoin 11:45 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Quit: ZNC 1.6.3+deb1+xenial0 - http://znc.in] 11:49 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #rust-bitcoin 11:52 -!- wraithm [~wraithm@unaffiliated/wraithm] has quit [Client Quit] 11:57 -!- wraithm [~wraithm@unaffiliated/wraithm] has joined #rust-bitcoin 14:08 -!- rjected [~rjected@natp-128-119-202-34.wireless.umass.edu] has joined #rust-bitcoin 15:13 -!- Kiminuo [~mix@141.98.103.100] has quit [Ping timeout: 268 seconds] 15:26 < BlueMatt> elichai2: I have no idea about any of that stuff..... 15:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 16:00 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 16:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:51 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #rust-bitcoin 20:54 -!- Kiminuo [~mix@141.98.103.100] has joined #rust-bitcoin --- Log closed Mon Dec 23 00:00:46 2019