--- Log opened Tue Dec 24 00:00:46 2019 01:08 < stevenroose> dr-orlovsky: so what was the conclusion for the merkle types? 01:09 < dr-orlovsky> stevenroose: leave it as is (single MerkleNode type) and rebase. However there are multiple issues after rebase due to new tests that have not adopted new hash types and which I need to modify, which is doing now 01:13 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 260 seconds] 02:55 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds] 04:20 -!- jonatack [~jon@213.152.162.94] has joined #rust-bitcoin 05:34 -!- jonatack [~jon@213.152.162.94] has quit [Ping timeout: 258 seconds] 05:37 -!- jonatack [~jon@213.152.161.69] has joined #rust-bitcoin 05:48 -!- jonatack [~jon@213.152.161.69] has quit [Ping timeout: 265 seconds] 06:27 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 06:47 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 06:48 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 08:20 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin 08:20 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host] 08:20 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin 08:38 < BlueMatt> stevenroose: but, yes, non-minimal varints in core will fail the deserialization (and we absolutely should do that!) 10:21 -!- Hattie8Auer [~Hattie8Au@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 11:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:04 < elichai2> andytoshi: hi, may I ask what's the importance of having all commits pass unit tests? 12:16 < BlueMatt> elichai2: in general it means git bisect is more reliable 12:17 < BlueMatt> eg if there's some regression and you add a unit test for it and then try to git bisect to figure out where the new unit test was broken, if you have random commits that fail for other reasons, your bisect is gonna be somewhat painful. 12:56 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:7de5:b7e3:c61b:f49e] has joined #rust-bitcoin 14:45 < andytoshi> usually bisections are completely useless in projects that don't enforce this 14:45 < andytoshi> also it makes review very hard when none of the code you're looking at compiles 18:05 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:7de5:b7e3:c61b:f49e] has quit [Remote host closed the connection] 19:33 -!- dongcarl [~dongcarl@pool-108-21-84-253.nycmny.fios.verizon.net] has quit [Quit: The Lounge - https://thelounge.chat] 19:50 -!- dongcarl [~dongcarl@pool-108-21-84-253.nycmny.fios.verizon.net] has joined #rust-bitcoin 19:51 -!- dongcarl [~dongcarl@pool-108-21-84-253.nycmny.fios.verizon.net] has quit [Client Quit] 19:53 -!- dongcarl [~dongcarl@pool-108-21-84-253.nycmny.fios.verizon.net] has joined #rust-bitcoin --- Log closed Wed Dec 25 00:00:47 2019