--- Log opened Sun Jan 05 00:00:46 2020 --- Day changed Sun Jan 05 2020 00:00 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 00:03 -!- Kiminuo [~mix@141.98.103.220] has joined #rust-bitcoin 00:57 -!- Kiminuo [~mix@141.98.103.220] has quit [Ping timeout: 265 seconds] 00:58 -!- httt [6db7076a@109.183.7.106] has joined #rust-bitcoin 00:58 -!- httt [6db7076a@109.183.7.106] has quit [Remote host closed the connection] 02:18 < elichai2> I hate seeing rust's rough edges, it makes you make performance tradeoffs for no reason :/ 03:04 -!- Mireille69Mraz [~Mireille6@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 04:43 < elichai2> anything I should review? 06:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 06:39 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:48 -!- Mireille69Mraz [~Mireille6@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds] 08:09 -!- titanbiscuit [~tbisk@38.132.112.106] has quit [Ping timeout: 268 seconds] 08:11 -!- titanbiscuit [~tbisk@104.200.131.8] has joined #rust-bitcoin 08:34 -!- Kiminuo [~mix@141.98.103.220] has joined #rust-bitcoin 09:36 < Kiminuo> elichai2, https://www.diffchecker.com/qV4nkaxw#left-2 wdyt? 09:58 < elichai2> Kiminuo: looking now 10:02 < elichai2> why are we not keeping the addresses as `std::net::IpAddr`? 10:04 < elichai2> Kiminuo: looks good. I would prefer if it printed the address like a normal IP address, but for that we need to diffrenciate ipv4 with ipv6. 10:06 < elichai2> I see `socket_addr()` already does that. maybe use that logic to construct a `std::net::IpAddr` and then print it with Display? that should do the job 10:07 < Kiminuo> elichai2, "/// Network byte-order ipv6 address, or ipv4-mapped ipv6 address" - address is always ipv6 (ipv6 or ipv4-mapped ipv6 address) 10:07 < Kiminuo> ah, I didn't want to change the code too much 10:18 < Kiminuo> https://www.diffchecker.com/L9ioc0KR#right-2 10:20 < Kiminuo> but this fails for ONION i think 10:41 < Kiminuo> https://www.diffchecker.com/J5EP8eCQ#right-2 10:43 < Kiminuo> elichai2, what about this way? 14:15 -!- titanbiscuit [~tbisk@104.200.131.8] has quit [Ping timeout: 268 seconds] 14:16 -!- titanbiscuit [~tbisk@5.253.207.86] has joined #rust-bitcoin 14:46 -!- Kiminuo [~mix@141.98.103.220] has quit [Ping timeout: 260 seconds] 17:19 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 20:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 21:33 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 23:15 -!- Kiminuo [~mix@141.98.103.220] has joined #rust-bitcoin 23:28 -!- simian_za [~simian_za@195.159.29.126] has joined #rust-bitcoin --- Log closed Mon Jan 06 00:00:58 2020