--- Log opened Mon Jan 13 00:00:05 2020
00:26 -!- jone_oofe [~jone_oofe@109.197.204.160] has joined #rust-bitcoin
00:41 -!- jone_oofe [~jone_oofe@109.197.204.160] has quit [Quit: Quit]
01:52 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
02:05 < elichai2> why the heck all sites that have embedded latex style equations in them require JS to render that :/
02:49 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #rust-bitcoin
02:54 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 268 seconds]
02:55 -!- jonatack [~jon@213.152.161.138] has joined #rust-bitcoin
03:00 < stevenroose> elichai2: yeah I also notice that :D
03:02 -!- Norbert44Buckrid [~Norbert44@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection]
03:04 -!- Isadore41Osinski [~Isadore41@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
03:50 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
05:48 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 240 seconds]
06:00 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin
06:00 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
06:00 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
06:58 < stevenroose> andytoshi: can you look at https://github.com/rust-bitcoin/bitcoin_hashes/pull/71#pullrequestreview-341476907
07:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
07:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
07:19 < stevenroose> elichai2: I made a comment on your macro-removing PR :) I somehow feel that just having those trivial methods on itself gives us any significant technical debt that we should avoid.
07:19 < stevenroose> I think they (1) make documentation/API way more intuitive and easy to use for newer Rust users and (2) it makes code more readable.
07:20 < elichai2> I'll put some of those back as you asked. I'm a bit drowning in stuff right now heh
07:37 < stevenroose> elichai2: yeah that's why I suggested in just a simple PR removing the unnecessary impls. That one we can get merged without any discussion and then you can go on being productive with real work :D
07:38 < stevenroose> elichai2: could you make this ACK explicit with a GitHub approve? https://github.com/rust-bitcoin/rust-bitcoin/pull/385#pullrequestreview-341833266
07:38 < elichai2> sure
07:43 < elichai2> ok. fuck travis. travis windows doesn't support python3
07:46 < stevenroose> Btw, I merged the breaking change into master. I think it's the easiest way instead of keeping PRs open pending.
07:46 < stevenroose> I can take on the work of maintaining a version branch in case we want to push minor versions out earlier.
07:49 < elichai2> we should tag branches for every major release
07:49 < elichai2> *branches*
07:57 -!- jonatack [~jon@213.152.161.138] has quit [Ping timeout: 240 seconds]
08:01 < stevenroose> elichai2: why would we do it before the first need of such a branch? ah just to keep track where we left off?
08:01 < stevenroose> Andrew makes tags. So we would be able to start a branch at the tag when we need it
08:02 < elichai2> yeah, and then you can backport commits or release more minors without worrying about it
08:02 < elichai2> so you never merge a breaking change into a major branch. only into a tagged version
08:04 < stevenroose> elichai2: ah you mean not having master at all?
08:04 < elichai2> I mean master represents the future major release. if anyone needs a new minor one we can backport to a branch and release
08:04 < elichai2> similiar to how bitcoin core works
08:06 < stevenroose> But in Bitcoin core they need regular backports.
08:06 < stevenroose> Since we don't need them frquently, isn't it ok that when we need one for 0.23 f.e. we can do `gco v0.23.0 && gcb 0.23.x` and then backport stuff
08:15 < elichai2> gco?
08:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
08:32 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
08:32 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
08:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
08:32 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
08:32 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
08:37 < elichai2> how do people feel about replacing `bip143` with `segwitV0` in #390?
09:05 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
09:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
09:09 < stevenroose> elichai2: As the module name? Or the method names?
09:10 < stevenroose> I suggested moving that functionality to the module. Even though it's a bit harder for users to notice, I think it belongs there.
09:12 < elichai2> Mostly method
09:56 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
10:50 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
10:53 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
11:15 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
11:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
11:45 < instagibbs> I like referring to BIPs when possible, but in practice it'll probably be equivalent since taproot is changing all this again, including sha256d -> sha256
11:49 < instagibbs> oh also since it's moved under bip143.rs, I dropped the name anyways, it's implicit :)
13:38 -!- real_or_random [~real_or_r@173.249.7.254] has quit [Ping timeout: 265 seconds]
13:44 -!- real_or_random [~real_or_r@173.249.7.254] has joined #rust-bitcoin
15:22 -!- titanbiscuit [~tbisk@5.253.207.86] has quit [Ping timeout: 268 seconds]
15:22 -!- titanbiscuit [~tbisk@45.12.223.214] has joined #rust-bitcoin
17:39 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
18:49 -!- Isadore41Osinski [~Isadore41@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]
--- Log closed Tue Jan 14 00:00:06 2020