--- Log opened Mon Jan 27 00:00:23 2020 00:26 -!- simian_za [~simian_za@195.159.29.126] has quit [Quit: Leaving] 00:26 -!- CjS77 [~caylemeis@195.159.29.126] has quit [Quit: Leaving] 00:26 -!- Blackwolfsa4 [~Blackwolf@195.159.29.126] has quit [Quit: Leaving] 00:26 -!- neonknight64 [~neonknigh@195.159.29.126] has quit [Quit: Leaving] 00:26 -!- stanimal [~stanimal@195.159.29.126] has quit [Quit: Leaving] 00:27 -!- CjS77 [~caylemeis@195.159.29.126] has joined #rust-bitcoin 00:27 -!- simian_za [~simian_za@195.159.29.126] has joined #rust-bitcoin 00:27 -!- neonknight64 [~neonknigh@195.159.29.126] has joined #rust-bitcoin 00:27 -!- stanimal [~stanimal@195.159.29.126] has joined #rust-bitcoin 00:27 -!- Blackwolfsa4 [~Blackwolf@195.159.29.126] has joined #rust-bitcoin 00:35 -!- orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin 00:36 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 240 seconds] 00:45 -!- orlovsky [~dr-orlovs@194.230.147.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 00:51 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin 01:30 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 02:00 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 02:12 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #rust-bitcoin 02:26 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #rust-bitcoin 02:29 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Ping timeout: 260 seconds] 02:54 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 02:56 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #rust-bitcoin 03:02 -!- Terrance33Gorcza [~Terrance3@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 03:06 -!- Gregg83Blanda [~Gregg83Bl@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 03:09 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 03:35 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #rust-bitcoin 03:40 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 268 seconds] 03:40 -!- jonatack [~jon@213.152.162.154] has joined #rust-bitcoin 06:08 -!- jonatack [~jon@213.152.162.154] has quit [Ping timeout: 265 seconds] 06:55 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 07:04 < elichai2> andytoshi: I see that bitcoin_hashes::siphash24 is a copy from libstd siphash impl. have you vetted it? 07:04 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 07:05 < elichai2> ah ha! https://github.com/rust-bitcoin/bitcoin_hashes/pull/46 07:06 < elichai2> stevenroose: wait. it says that you wrote it? 07:44 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has joined #rust-bitcoin 07:46 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has quit [Client Quit] 07:55 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has joined #rust-bitcoin 07:59 <@andytoshi> elichai2: steven assured me that it worked with compact blocks :P 07:59 <@andytoshi> it's not quite a copy from libstd, iirc libstd removed a round 08:00 < elichai2> Yeah the default version that hashmap implements is siphash1-3 but libstd also exposes sipash2-4 (legacy) 08:00 < elichai2> And my benchmarks shows it's one of the fastest impl around so I'm kinda copying it to core now lol 08:00 <@andytoshi> anyway, the short answer is no i did not vet it 08:00 <@andytoshi> well, let's be careful about copyright here 08:00 < elichai2> (core was the slowest on my benchmarks) 08:01 <@andytoshi> is it actually a copy of libstd code? that is MIT licensed to us and we are CC0, so that's no go.. 08:01 < elichai2> There's some weird comment about that 08:01 < elichai2> Look at the head of the file (hard to link from my phone) 08:10 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has quit [Quit: notmandatory] 08:21 < stevenroose> elichai2: about the vetting, I didn't. the crate it was in had quite a high usage and I tested it with test vectors for compact blocks taken from Core. But yeah that might only have tested a part of the full functionality, tbh 08:22 < elichai2> thanks. just wanted to know if I can add a comment about it if and when my PR to core will be ready and worthy 08:22 < stevenroose> About the relicensing, I, uh, rewrote the code.. I mean the code is not identical, the structure and the API are different for sure, one could say I drew a lot of inspiration from the siphasher crate.. Perhaps I should just not have made that mention at the top. 08:24 -!- Gregg83Blanda [~Gregg83Bl@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 08:25 < elichai2> not that I'm a lawyer but I realized they're the same *before* I read that comment :P 08:27 < elichai2> arghh I hate this. in the middle of re-implementing siphash in c++ I think I found an optimization to the impl (memory wise) Now I need to decide if I should do it or first finish what i've started even though it will affect it 08:27 * elichai2 facepalm 08:33 < elichai2> 4 times faster :D 08:37 < elichai2> https://gist.github.com/elichai/abdebeeaee7e581bc74c75cb9487b3af :) 08:57 < stevenroose> Cool :D 08:57 < stevenroose> Btw, I notice that the hash newtypes don't have FromStr implemented while hashes have. I'll try add 08:57 < stevenroose> Must have been an oversight. 09:07 < stevenroose> https://github.com/rust-bitcoin/bitcoin_hashes/pull/76 09:59 <@andytoshi> re licensing, it's fine 10:00 <@andytoshi> the rust people are friendly, if they have a problem they'll ask us to change stuff and we can (but i think it's a reasonable argument that if we have a different API and it's a public algorithm that there's actually no copyrigth overlap) 10:40 -!- jonatack [~jon@88.124.242.136] has joined #rust-bitcoin 10:44 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds] 10:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 12:23 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:c9b3:b4ff:e7cb:7728] has joined #rust-bitcoin 12:36 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:c9b3:b4ff:e7cb:7728] has quit [] 16:34 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 16:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 16:39 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin 17:13 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Quit: tyler] 17:14 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin 17:15 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Remote host closed the connection] 17:16 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin 17:16 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Remote host closed the connection] 17:17 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin 17:17 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Remote host closed the connection] 17:18 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin 17:18 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Remote host closed the connection] 17:41 -!- tyler [~tyler@72-46-56-225.lnk.ne.static.allophone.net] has joined #rust-bitcoin 17:43 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:23 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has joined #rust-bitcoin 18:23 -!- tyler [~tyler@72-46-56-225.lnk.ne.static.allophone.net] has quit [Quit: tyler] 18:24 -!- tyler [~tyler@72.46.56.225] has joined #rust-bitcoin 18:25 -!- tyler [~tyler@72.46.56.225] has quit [Remote host closed the connection] 18:36 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has quit [Quit: notmandatory] 18:39 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has joined #rust-bitcoin 18:46 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 18:47 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #rust-bitcoin 18:57 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin 18:58 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Client Quit] 18:58 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has quit [Quit: notmandatory] 19:18 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has joined #rust-bitcoin 19:26 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has joined #rust-bitcoin 19:40 -!- tyler [~tyler@cpe-108-167-11-88.neb.res.rr.com] has quit [Quit: tyler] 19:55 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has quit [Quit: notmandatory] 20:54 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has joined #rust-bitcoin 22:25 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 22:27 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 22:41 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 260 seconds] 22:42 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin 23:27 -!- notmandatory [~textual@cpe-76-169-37-102.socal.res.rr.com] has quit [Quit: notmandatory] --- Log closed Tue Jan 28 00:00:22 2020