--- Log opened Tue Mar 03 00:00:12 2020 00:48 -!- vindard [~vindard@190.83.165.233] has quit [Quit: No Ping reply in 180 seconds.] 00:50 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin 01:46 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 256 seconds] 02:06 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 256 seconds] 02:08 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin 02:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 02:56 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-ycceevqwgjpqzktv] has quit [Quit: killed] 02:56 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-xoqrncfpwvhgtnlw] has quit [Quit: killed] 03:06 -!- Norene65Huel [~Norene65H@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 03:20 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-tddfnpspzdunrbtw] has joined #rust-bitcoin 03:44 -!- Norene65Huel [~Norene65H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 03:49 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-ohgqiwzgrnjsekqd] has joined #rust-bitcoin 06:06 -!- rjected [~rjected@natp-128-119-202-45.wireless.umass.edu] has joined #rust-bitcoin 06:07 -!- rjected_ [uid425487@gateway/web/irccloud.com/x-mppvphzwrpvbacnm] has joined #rust-bitcoin 06:10 < elichai2> https://en.bitcoinwiki.org/wiki/Pay-to-Pubkey_Hash seems to say that p2pkh scriptpubkey is `OP_DUP OP_HASH160 OP_EQUAL OP_CHECKSIG` but when I print it with rust-bitcoin I see `OP_DUP OP_HASH160 OP_PUSHBYTES_20 162c5ea71c0b23f5b9022ef047c4a86470a5b070 OP_EQUALVERIFY OP_CHECKSIG` 06:12 < elichai2> what's up with the `OP_PUSHBYTES_20`? 06:13 -!- rjected [~rjected@natp-128-119-202-45.wireless.umass.edu] has quit [Ping timeout: 260 seconds] 06:13 -!- rjected_ is now known as rjected 06:13 < harding> elichai2: that's how you get 20 arbitrary bytes onto the stack. 06:14 < harding> The push-bytes opcodes are often omitted from text descriptions but they're always there. 06:14 < elichai2> harding: so why I can't see it anywhere else? when I grep bitcoin core for `OP_DUP OP_HASH160` I don't see it 06:14 < elichai2> ohh 06:14 < elichai2> you're saying bitcoin core just omits it when printing 06:15 < harding> Yeah, it's implicit in the length of the data element. 06:16 < harding> (I personally think it's better to include the push opcodes in descriptions to avoid exactly this confusion. :-) 06:16 < elichai2> but it's not a VarInt. so how is it implicit? 06:16 < harding> It's implicit in the description. It's explicit in the actual script. 06:17 < harding> E.g. when someone says "", they're implying RIPEMD160 = 20 bytes of arbitrary data. 06:18 < harding> Which will need to be pushed onto the stack using either PUSH1 to PUSH73 or PUSHDATA1, PUSHDATA2, or PUSHDATA4 06:18 < elichai2> like in core I see `*script << OP_DUP << OP_HASH160 << ToByteVector(keyID) << OP_EQUALVERIFY << OP_CHECKSIG;` and `ToByteVector` returns a `std::vector` so while serializing it inserts that opcode? 06:19 < elichai2> found it :) 06:19 < elichai2> it comes from here: https://github.com/bitcoin/bitcoin/blob/master/src/script/script.h#L461 06:19 < elichai2> harding: Thank you! 06:19 < harding> Dunno the specifics of Core's implementation, but if you tax the hex and parse it out by hand, you'll find 0x14 in there. 06:20 < elichai2> it checks here the length of the vector and inserts the correct OP_PUSH, and it just ignores it when printing 06:35 -!- rjected_ [~rjected@natp-128-119-202-10.wireless.umass.edu] has joined #rust-bitcoin 06:40 -!- Kiminuo [~mix@141.98.103.108] has quit [Ping timeout: 258 seconds] 07:01 -!- rjected_ [~rjected@natp-128-119-202-10.wireless.umass.edu] has quit [Quit: WeeChat 2.7.1] 07:02 -!- rjected_ [~rjected@natp-128-119-202-10.wireless.umass.edu] has joined #rust-bitcoin 07:02 -!- rjected_ [~rjected@natp-128-119-202-10.wireless.umass.edu] has quit [Client Quit] 07:02 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 07:04 -!- jonatack [~jon@37.171.106.95] has joined #rust-bitcoin 07:22 -!- rjected_ [~rjected@natp-128-119-202-10.wireless.umass.edu] has joined #rust-bitcoin 07:22 -!- rjected_ [~rjected@natp-128-119-202-10.wireless.umass.edu] has quit [Client Quit] 08:41 < willcl_ark> Is anyone sucessfully compiling rust-secp256k1 for aarch64-linux-android? I saw some historical issues, but it look like android stuff got removed from build.rs at some point... 08:45 < elichai2> willcl_ark: do you have a specific error? 09:05 < ariard> BlueMatt: honggfuzz build failed on last #462 push, "invalid serialized PackageId for key `package.dependencies`", something wrong? 09:21 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 09:35 -!- jonatack [~jon@37.171.106.95] has quit [Read error: Connection reset by peer] 09:36 < willcl_ark> elichai2: I am actually trying to compile rust-lighting-bitcoinrpc, but it's falling over on bitcoin, lightning, lightning-invoice who all dep on secp256k1 15.0, here is a full log: https://bpaste.net/27HA 09:36 < willcl_ark> to make it more fun, I'm on OSX Catalina (where they moved C headers from /usr/include, annoyingly) and using `cargo ndk` for the android glue magic 09:38 < willcl_ark> I notice in old versions of rust-secp256 there were android references in build.rs, but these are no longer there. 09:40 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 09:48 < elichai2> There shouldn't be any need for Android references 09:49 < elichai2> It looks like the android glue magic is failing, when I'll be next to my laptop I'll install the ndk to test... 10:10 < willcl_ark> Thanks elichai2! 10:14 -!- Kiminuo [~mix@141.98.103.180] has joined #rust-bitcoin 10:16 <@andytoshi> sgeisler: are you around? 10:16 <@andytoshi> elichai2: yeah, re "op_pushbytes_20", i think we should overhaul our script-printing to fix it 10:16 <@andytoshi> these thingcs also show up on blockstream.info and imho they look dumb 10:17 <@andytoshi> and we should also remove the `OP_` prefixes 10:17 <@andytoshi> but i think we *should* prefix all data with 0x so it's clear that it's hex 10:17 < sgeisler> andytoshi: Yeah! 10:24 < elichai2> andytoshi: I actually would've prefer core would also show the push opcode, the thing is I manually calculate p2pkh to be 25 byte script just to realize it was 26 because I missed an opcode :/ 10:28 <@andytoshi> heh yeah i've done that 10:28 <@andytoshi> that's fair 10:34 < elichai2> willcl_ark: seems to work for me: https://pastebin.com/raw/JLTMm5V1 10:37 < willcl_ark> Hmmm. Well that’s good news I’ll take. I have to investigate tomorrow now; thanks for testing! 10:39 < elichai2> willcl_ark: also just installed `cargo-ndk` and tested `cargo ndk --platform 29 --target x86_64-linux-android build` and it works 10:40 < elichai2> with `ANDROID_NDK_HOME=/home/elichai2/Android/Sdk/ndk/21.0.6113669` 12:07 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds] 12:29 < Kiminuo> https://github.com/apoelstra/rust-miniscript/pull/79 anyone? 12:34 <@andytoshi> yeah i'll take a look 12:39 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:43 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 13:18 <@andytoshi> merged. thank you! 14:39 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 14:55 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 15:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 15:32 < willcl_ark> Damn elichai2, I get the same error still just, building rust-secp256 now :( I guess my issue is OSX related then... 17:18 -!- vindard [~vindard@190.83.165.233] has quit [Quit: No Ping reply in 180 seconds.] 17:18 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin 19:37 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 19:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:04 -!- titanbiscuit [~tbisk@titan.pathogen.is] has quit [Quit: ZNC 1.7.4 - https://znc.in] 20:06 -!- titanbiscuit [~tbisk@titan.pathogen.is] has joined #rust-bitcoin 20:08 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 21:01 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 22:40 -!- Kiminuo [~mix@141.98.103.180] has quit [Ping timeout: 256 seconds] 23:34 -!- Kiminuo [~mix@141.98.103.172] has joined #rust-bitcoin --- Log closed Wed Mar 04 00:00:12 2020