--- Log opened Sun Mar 15 00:00:22 2020
04:06 -!- Fritz19Swaniawsk [~Fritz19Sw@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
05:57 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
07:20 -!- varioust [~varioust@rrcs-76-79-17-10.west.biz.rr.com] has joined #rust-bitcoin
07:35 -!- varioust [~varioust@rrcs-76-79-17-10.west.biz.rr.com] has quit [Quit: varioust]
10:33 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
11:27 < stevenroose> Good old corona time, I build an integration test for bitcoincore-rpc and tested it against 0.18 and 0.19
11:27 < stevenroose> Here are the many issues I found: https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/94
11:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:33 < stevenroose> Next I'm gonna make an MR adding the test with integration in Travis
11:52 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
12:36 -!- Netsplit *.net <-> *.split quits: kanzure
12:36 -!- kanzure_ [~kanzure@unaffiliated/kanzure] has joined #rust-bitcoin
12:38 -!- Fritz19Swaniawsk [~Fritz19Sw@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]
13:03 -!- Arvilla72Hayes [~Arvilla72@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
13:10 -!- willcl_ark__ [~quassel@95.211.225.220] has quit [Ping timeout: 256 seconds]
13:18 < elichai2> BlueMatt: if you could comment your opinion it would be appreciated :) https://github.com/rust-bitcoin/rust-secp256k1/pull/204
13:18 < elichai2> dongcarl: same :)
13:27 -!- willcl_ark_ [~quassel@95.211.225.220] has joined #rust-bitcoin
13:30 -!- Netsplit *.net <-> *.split quits: harding, midnight, raj_, nothingmuch
13:30 -!- harding_ [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #rust-bitcoin
13:30 -!- Netsplit over, joins: nothingmuch
13:30 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has joined #rust-bitcoin
13:57 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin
14:23 < BlueMatt> elichai2: wait, I'm confsed, the current patch there doesn't release the pin, though?
14:23 < BlueMatt> it just fixes it to 1.0.28?
14:24 < elichai2> Yeah, cc="1.0.28" is equivilant to 1.0.*
14:24 < elichai2> It breaks MSRV
14:24 < elichai2> But it still allows for a user that *wants* to run with 1.22.0 to be able to
14:24 < elichai2> By pinning the cc version at the binary level
14:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
14:48 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
14:56 < BlueMatt> wut. thats....so confusing
14:56 < BlueMatt> =ver turns into a regex?!
14:56 < BlueMatt> why does cargo suck ass
14:56 < BlueMatt> can we move all our crates to Makefile + rustc?
14:57 < BlueMatt> I mean the other thing we can do is....just leave it? Why do we really want newer cc anyway?
14:58 < BlueMatt> like, its not exactly the end of the world to require an old cc and make people download 2 ccs
14:58 < BlueMatt> (or, any time there is an issue, go submit patches upstream to make it work with 1.22, then get them to cut a release, and require that version)
14:59 < BlueMatt> of course, that said, if its an issue only for <1.34, I don't care toooo deeply
15:09 -!- ariard [~ariard@167.99.46.220] has joined #rust-bitcoin
15:52 < elichai2> Lol. It's just weird semver rules https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html
15:53 < elichai2> BlueMatt: the main big change here is are we OK with making the Msrv "off by default" while now it's required by default
15:53 < elichai2> But if you have strong feelings for 1.34 maybe we can require that by default and 1.22.0 optional (but enforced by the CI obviously)
15:54 -!- devcarrot_ is now known as devcarrot
15:56 < elichai2> About why. There are 2 reasons. 1. wumpus needs a newer one for riscv stuff and you can't have 2 conflicting versions. 2. Complex binaries with a lot of dependencies can easily refuse to compile if either another dependency pins cc or another dependency uses a feature from a newer cc version. And the end user can't fix it without forking either cc(and patch the dependency resolver, resulting in a crate they can't
15:56 < elichai2> publish) or rust-secp
16:05 < BlueMatt> wait, you cant? why cant you have two versions? we have two versions of deps all the time?
16:05 < BlueMatt> I guess its just a development-dep thing?
16:07 < BlueMatt> yea, I think thats fine. obviously making things not build by default on 1.34 really, really sucks, cause that means existing distros cant build
16:20 < BlueMatt> but making it not build on 1.22 by default isn't the end of the world
16:34 < stevenroose> elichai2: you need `cc = "=1.0.28"`
16:34 < elichai2> Yep.
16:35 < elichai2> BlueMatt: you can't have two minor versions of the same crate in the same dependency tree probably related to symbols and linking
16:36 < BlueMatt> thats obnoxious
16:36 < elichai2> Well that's the same even with c/c++
16:37 < elichai2> Altough I'd hoped it can be fixed in rust by passing hashes into the symbol mangling function. Will need to ask the compiler team about this
16:38 < elichai2> I think I posted in the rfcs repo about something similar a year ago
16:40 < BlueMatt> its even more awkward that its a dev-dependency - its not linked in ever.
16:43 < elichai2> Yeah build dependency should have different rules here. This is a known open bug for a long time
16:44 < elichai2> There's no good reason to unity build dependencies
16:44 < elichai2> *unify
16:44 < BlueMatt> right
16:45 < elichai2> Hmm maybe it's solved on nightly already. Will play with it tomorrow https://github.com/rust-lang/cargo/issues/7915
16:45 < elichai2> Not sure if it's exactly the same source so mayeb it's completely unrelated
16:56 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
17:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
17:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
17:49 -!- kanzure_ is now known as kanzure
18:56 -!- Arvilla72Hayes [~Arvilla72@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds]
19:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
20:31 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has joined #rust-bitcoin
20:38 -!- varioust [~varioust@cpe-108-167-2-254.neb.res.rr.com] has quit [Quit: varioust]
--- Log closed Mon Mar 16 00:00:24 2020