--- Log opened Thu Mar 19 00:00:28 2020 00:14 -!- Kiminuo [~mix@141.98.103.204] has joined #rust-bitcoin 01:08 -!- jamesob [sid180710@gateway/web/irccloud.com/x-kivzeuyrfxxomyrs] has quit [Ping timeout: 256 seconds] 01:08 -!- jamesob [sid180710@gateway/web/irccloud.com/x-uvqrlcgalmsqcvxz] has joined #rust-bitcoin 01:09 -!- valwal [sid334773@gateway/web/irccloud.com/x-fjwyjmifqhyhulwf] has quit [Ping timeout: 256 seconds] 01:09 -!- moneyball [sid299869@gateway/web/irccloud.com/x-kitjiyfjwciyakhd] has quit [Ping timeout: 240 seconds] 01:09 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-fuiwsenctjdhivkq] has quit [Ping timeout: 240 seconds] 01:10 -!- moneyball [sid299869@gateway/web/irccloud.com/x-hwebhygvbidfhaig] has joined #rust-bitcoin 01:11 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-nkypemjtktybfqgj] has joined #rust-bitcoin 01:12 -!- valwal [sid334773@gateway/web/irccloud.com/x-lmqbxbemsoouyiil] has joined #rust-bitcoin 03:42 -!- fiatjaf1 [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has quit [Quit: WeeChat 2.6] 04:06 -!- Lucie79Luettgen [~Lucie79Lu@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 05:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 07:13 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer] 07:34 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:3105:3e60:51ab:b6a3] has joined #rust-bitcoin 07:39 -!- Kiminuo [~mix@141.98.103.204] has quit [Ping timeout: 256 seconds] 07:49 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 07:52 -!- Kiminuo [~mix@141.98.103.220] has joined #rust-bitcoin 08:34 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:3105:3e60:51ab:b6a3] has quit [] 09:46 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 09:47 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 12:05 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 12:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 12:17 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 12:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 12:30 < ariard> BlueMatt: okay let's get started, reviewing #551, then rebasing #540, reviewing #441 (MPP), reviewing #539 12:30 < BlueMatt> ha! sounds good. I'm most of the way through 552, mostly just "ehh, name is bad" kinda stuff so far 12:34 -!- Lucie79Luettgen [~Lucie79Lu@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 258 seconds] 13:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 13:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 14:23 < ariard> BlueMatt: on #553, that's quite subtle, post-anchor-outputs, we should only be responsible for rebroadcasting as thanks to dynamic fees we can reach confirmation with best-effort? 14:24 < ariard> I just want to avoid some dumb implementations rebroadcasting every tx at every block 14:25 < ariard> But in fact, that dependent of the tx type, justice tx are well-rebroadcast with fee bumped, but for local commitment transaction you still have the edge-case of a dry CPFP utxo pool 14:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 14:26 < BlueMatt> ariard: right. until we have package relay we kinda need the client to rebroadcast 14:26 < ariard> maybe we should even more responsible for withholding HTLC-timeout until finalization, that way an implementation just have to call sendrawtransaction 14:26 < BlueMatt> ariard: fwiw, the sample client does exactly that - on every block it just calls sendrawtransaction for every transaction it thinks it should broadcast 14:26 < ariard> meeeh that's good for privacy 14:26 < ariard> *not* 14:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 14:26 < BlueMatt> well, *sample* client for a reason :p 14:26 < BlueMatt> but, yea, I definitely wouldn't mind having our own broadcasting pool 14:27 < BlueMatt> especially since we're moving to onchaintx.rs being the only thing that ever broadcasts transactions 14:27 < BlueMatt> at least after 551 14:27 < ariard> okay I'll modify #553 with indicating we are fully responsible for rebroadcasting with a TODO to add broadcasting pool after anchor outputs ? 14:28 < BlueMatt> well then we probably shouldn't take 553 until thats done, no? 14:28 < ariard> okay I'm fine witholding for now, will resume discussin on PR 15:53 < ariard> BlueMatt: bbl, but lmk if #552 new others fixes, just re-ACK #551 15:53 < ariard> *need 15:56 < BlueMatt> ariard: cool. will take a look, thanks! 16:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 16:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 17:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 17:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 17:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 17:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 17:04 < BlueMatt> ariard: one comment (there was one other addition of hash160-per-output-in-a-block), then ack 19:32 < ariard> BlueMatt: rebased with comment addressed, all took opportutnity to change commit messages with new names 19:33 < ariard> starting to rebase #540 on top of #552+master 19:36 < ariard> BlueMatt: why not panic! in #554 ? Is there any reason to keep operating a ChannelManager with an unsync ChannelMonitor? 19:50 -!- fiatjaf [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin 22:08 -!- Kiminuo [~mix@141.98.103.220] has quit [Ping timeout: 265 seconds] --- Log closed Fri Mar 20 00:00:28 2020