--- Log opened Fri Mar 20 00:00:28 2020
00:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
00:12 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:14 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 246 seconds]
00:42 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #rust-bitcoin
03:02 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8f6:feac:725:f1] has joined #rust-bitcoin
04:06 -!- Allene64Cummings [~Allene64C@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
05:00 -!- Kiminuo [~mix@141.98.103.196] has joined #rust-bitcoin
05:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
05:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
05:28 -!- Kiminuo [~mix@141.98.103.196] has quit [Ping timeout: 250 seconds]
05:48 -!- Allene64Cummings [~Allene64C@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 250 seconds]
06:16 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #rust-bitcoin
06:23 -!- Kiminuo [~mix@141.98.103.134] has joined #rust-bitcoin
07:36 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8f6:feac:725:f1] has quit []
08:09 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
08:10 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 265 seconds]
08:10 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
08:10 -!- vindard [~vindard@200.7.90.128] has joined #rust-bitcoin
09:05 -!- vindard [~vindard@200.7.90.128] has quit [Read error: Connection reset by peer]
09:08 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin
10:05 < BlueMatt> ariard: why panic!()? We wont run if we return Invalid - they cant deserialize the ChannelManager
10:05 < BlueMatt> sure it indicates user error, but might as well return an error if we can instead of panic()ing
10:14 < BlueMatt> ariard: note travis failed on 552
10:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
11:02 < ariard> BlueMatt: should be good now, forgot new test requirement during rebase
11:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
11:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
11:27 < BlueMatt> ariard: oops, one more rebase error - gotta use the new macro for fetching local commitment txn from channels
11:34 < BlueMatt> ariard: let me know when you get 540 rebased and I'll review it again.
11:35 < ariard> BlueMatt: okay #552 should be good
11:35 < ariard> just git didn't spott this kind of rebase error :p
11:35 < BlueMatt> right....damn git rebase
11:35 < ariard> on 540, I'm trying to dryup a bit more LocalTx, going to make it more beefy but better
11:35 < BlueMatt> anyway, looks good. will merge once travis lets me
11:36 < ariard> yeah I'm pinging you when 540 is ready (~1h)
11:36 < BlueMatt> hmm, alright. lmk when there's something i should look at
11:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
11:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
12:09 < BlueMatt> ariard: cool, 552 merged! rebase on master now :)
12:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:13 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
12:20 < ariard> BlueMatt: already done, still squeezing ChannelMonitor::Storage
12:20 < BlueMatt> well, i meant you can rebase on master *with* 552 :)
12:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds]
12:42 < ariard> BlueMatt: aaaah, likely I'll have to deal with get_latest_local_commitment_txn new TODO..
12:43 < ariard> because yeah signing twice means != wtxid in test framework
12:46 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
12:55 < BlueMatt> ariard: wait huh? signing should *absolutely* be deterministic
12:55 < BlueMatt> ariard: that sounds like a *different* bug
12:55 < BlueMatt> no?
12:56 < ariard> BlueMatt: that's likely signatures order, but nevermind unifying it to avoid any further bug
12:56 < ariard> at least txid are equal
12:58 < BlueMatt> that sounds like something thats worth looking into further, ariard
12:58 < BlueMatt> the tx should not change at all if you sign it 20 times
13:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
13:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
13:33 < ariard> BlueMatt: okay I found the issue, I was using the p2wsh instead of redeemscript, and not detected by typing ofc
13:33 < ariard> the anti-temporary duplicata logic was masking me than new txn generation was defectuous
13:34 < ariard> and funding_info.1 doesn't seem to be used
14:11 < ariard> BlueMatt: see #555, I'm starting to split #540, to avoid a monster
14:18 < BlueMatt> ariard: oh nice!
14:18 < BlueMatt> ariard: thanks
14:27 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8f6:feac:725:f1] has joined #rust-bitcoin
15:10 < ariard> BlueMatt: quick API consultation, what's your opinon on storing remote signed local commitment transaction in OnchainTxHandler?
15:10 < ariard> because if we do so that means get_latest_local_commitment is just a dumb wrapper calling OnchainTxHandler
15:11 < ariard> I'm wondering if we shouldn't assume than signer store half signed local commitment transaction and valid htlc output
15:12 < ariard> that way doesn't matter if signer is called by ChannelMonitor or OnchainTxHandler
15:12 < ariard> see https://github.com/ariard/rust-lightning/commit/1a443175c58f8344ffcc4ac4cf417d2bce51bcca
15:13 < BlueMatt> ariard: imo it should be in onchain
15:13 < BlueMatt> ariard: it doesnt make sense imo to make the client/user store it in the signer
15:15 < BlueMatt> ariard: that commit looks good-ish, but it needs less LocalCommitmentTransaction-specific logic in it
15:15 < BlueMatt> (cause, like, the fact that we store partially-signed crap in specific places in the witness is definitely not sensical for a public api
15:16 < BlueMatt> ariard: imo the api should stay the same-ish, but we should pass the &mut LocalCommitmentTransaction to the signer interface
15:16 < ariard> BlueMatt: passing LocalCommitmentTransaction means we have to make a pub
15:17 < ariard> BlueMatt:  hmmm half-signed tx should already be considered as toxic material and stores out-of-memory
15:18 < ariard> (we can store it right now in onchain and brood on this latter)
15:35 < BlueMatt> ariard: half-signed isnt toxic?
15:36 < BlueMatt> you'd still need the private key to *do* anything with it
15:36 < BlueMatt> ariard: hey, gonna have to review stuff tomorrow. family thing came up so gonna be mia for most of this afternoon. may get to it tonight. sorry about that
15:37 < ariard> BlueMatt: no worries, take time, it's just going to be more stuff to review tmrw :p
16:24 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-vpbnsrodnoqsjuqc] has joined #rust-bitcoin
16:24 -!- dpc1 [dpcmatrixo@gateway/shell/matrix.org/x-wdefhnqhovbvrmjd] has joined #rust-bitcoin
16:25 -!- valwal [sid334773@gateway/web/irccloud.com/x-lmqbxbemsoouyiil] has quit [Ping timeout: 246 seconds]
16:25 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-gnrcyozrihwiiogl] has quit [Ping timeout: 246 seconds]
16:25 -!- fiatjaf [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 246 seconds]
16:25 -!- fiatjaf [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
16:34 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
16:34 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
16:37 -!- fiatjaf [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 246 seconds]
16:37 -!- fiatjaf [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
16:56 < BlueMatt> ariard: why copy Storage to OnChainTxHandler?
16:57 < ariard> BlueMatt: to remove ChannelMonitor key access in future commit
16:57 < BlueMatt> ariard: its all accessible via ChannelKeys - just use that?
16:57 < BlueMatt> we can remove it later, but for now, Storage has two copies of all the private keys
16:57 < BlueMatt> both ChannelKeys' copy, and Storage's copy
16:58 < BlueMatt> (the private keys as well, but thats OK, we can remove *those* later)
17:00 < ariard> BlueMatt: if it's accessible via ChannelKeys why do we store them in ChannelMonitor?
17:00 < BlueMatt> ariard: legacy
17:00 < BlueMatt> they should be removed from both
17:00 < BlueMatt> but, really, we shouldnt access either
17:00 < BlueMatt> so I havent done it yet
17:00 < ariard> okay will modify commit to do so, and just give key acess to OnchainTxHandler
17:01 < ariard> have a call, bbl
17:02 < BlueMatt> see ya!
17:32 < BlueMatt> ariard: aside from that, concept ack on everything in 556. I'll take a look tomorrow. probably done for the day.
17:32  * BlueMatt -> family stuff
19:28 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
19:30 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
19:37 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8f6:feac:725:f1] has quit []
20:04 < ariard> lueMatt: hmmmm https://github.com/rust-bitcoin/rust-lightning/compare/master...ariard:2020-03-move-local-commitment
20:05 < ariard> BlueMatt: ^^ this is a reworked version of #540 with a signer API for local tx and API cleanup for LocalCommitmentTx
20:05 < ariard> I can make it cleaner by drying up broadcast_local_state to scope it to pure detection
20:06 < ariard> just need to a) move per-local-commitment keys in Onchain (mostly stuff inside LocalSignedTx) b) move htlc signature+construction in signer API
20:08 < ariard> c) make ChannelMonitor access HTLC transaction signed through Onchain API
20:09 < ariard> no that much stuff, if you want to go forward I can stop refactoring at 2020-03-move-local-commitment
20:09 < ariard> Anyway, will do #555 first with your suggestion tmrw morning
23:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
23:19 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
23:19 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds]
23:20 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin
23:32 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
--- Log closed Sat Mar 21 00:00:29 2020