--- Log opened Sun Mar 22 00:00:30 2020
04:06 -!- Cassie3Hilpert [~Cassie3Hi@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
04:36 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:5421:50c2:d94a:eb] has joined #rust-bitcoin
10:15 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin
10:36 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:48 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin
11:09 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:10 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
11:11 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:25 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
11:27 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:27 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:5421:50c2:d94a:eb] has quit []
11:31 < BlueMatt> ariard: ehh, as long as its just waiting for other stuff I dont mind it much
12:05 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
12:07 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #rust-bitcoin
12:08 < BlueMatt> ariard: also, re the branch you'd linked previously (I thought I'd commented but apparently not): its kinda hard to read given the diff contains all the moving around from 555, but it looks good at a high level. the one real concern I had with 540 previously was the lack of DRY in signing, which is fixed now. I do think we need to just, for now, make LocalCommitmentTransaction pub and pass a mut ref to the ChannelKeys trait. we can clean
12:08 < BlueMatt> up and doument exactly how it works later, but in its current state it is completely not ok to make the underlying transaction public (cause its internal storage is nonsense)
12:10 < BlueMatt> (in general, I dont mind merging stuff that leaves internal interfaces in an intermediate state, as long as they are moving in the right direction, but I *hate* merging stuff that leaves public interfaces in a nonsensical state.
12:10 < BlueMatt> )
14:58 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
15:01 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
15:01 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
15:10 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
16:53 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
19:10 -!- Cassie3Hilpert [~Cassie3Hi@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds]
19:34 -!- fiatjaf [~fiatjaf@2804:7f2:2981:26c1:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 246 seconds]
19:36 -!- fiatjaf [~fiatjaf@2804:7f2:2a82:7a59:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
23:10 < ariard> BlueMatt: okay branch 2020-03-move-local-commitment finally updated implementing your suggestion of not passing a bunch of keys through InputMaterial
23:11 < ariard> with a lot of quirks around, because had to move a lot of stuff in OnchainTxHandler, but that also should simplify a lot broadcast_by_local_state
23:12 < ariard> have to take your suggestion of making LocalCommitmentTransaction a pub, reoder a bit commit to make sense, document better but then will open PR
23:13 < ariard> BlueMatt: yeah was expecting to get over today but some other setup stuff took longer than expected :/
--- Log closed Mon Mar 23 00:00:30 2020