--- Log opened Fri Mar 27 00:00:35 2020 00:02 -!- Kiminuo [~mix@141.98.103.228] has joined #rust-bitcoin 02:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 02:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 03:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 03:31 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ed93:1afc:1e0c:84c9] has joined #rust-bitcoin 03:31 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ed93:1afc:1e0c:84c9] has quit [Read error: Connection reset by peer] 03:31 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ed93:1afc:1e0c:84c9] has joined #rust-bitcoin 04:06 -!- Tobin75Simonis [~Tobin75Si@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 04:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 04:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 05:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 05:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 06:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 06:10 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 07:41 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Quit: The Lounge - https://thelounge.chat] 08:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 08:18 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #rust-bitcoin 08:21 -!- Kiminuo [~mix@141.98.103.228] has quit [Ping timeout: 240 seconds] 08:28 < andytoshi> am i crazy or have i lost the ability to restart CI jobs for rust-bitcoin in travis 08:31 < andytoshi> think i should close https://github.com/rust-bitcoin/rust-bitcoin/pull/401 ? i could go either way on this 08:33 -!- Kiminuo [~mix@141.98.103.110] has joined #rust-bitcoin 08:49 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 08:57 < instagibbs> travis is having issues, try logging out and back in 08:57 < instagibbs> or close-reopen PR 09:50 < BlueMatt> ariard: no idea. that would be obnoxious, but you can ask rusty. 10:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 10:12 -!- Tobin75Simonis [~Tobin75Si@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 10:24 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection] 10:24 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 10:28 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 10:46 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 11:58 < jonatack> andytoshi: you're not alone, people in bitcoin-core-dev have been reporting the same 11:58 < andytoshi> ok thanks 12:32 < ariard> BlueMatt: here? Just addressed your first comments on 559, but if you have further suggestions for chan_utils API, I'm listening :) 12:43 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 12:44 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 240 seconds] 12:44 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 12:44 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 12:45 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has quit [Ping timeout: 265 seconds] 12:45 -!- jtimon [~quassel@206.160.134.37.dynamic.jazztel.es] has quit [Quit: No Ping reply in 180 seconds.] 12:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 12:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 12:46 -!- jtimon [~quassel@206.160.134.37.dynamic.jazztel.es] has joined #rust-bitcoin 12:46 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has joined #rust-bitcoin 12:54 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:57 < BlueMatt> andytoshi: travis had an outage and stopped reporting status to github 12:57 < BlueMatt> andytoshi: for some reason it wasnt resolved until I disabled travis and turned it back on on the r-lightning repo 12:57 < BlueMatt> ariard: let me take a look, sec 12:58 < andytoshi> BlueMatt: ok, thanks, good to know 12:59 < BlueMatt> (though they claim it was resolved a while back) 12:59 < andytoshi> i have a multi-week backlog of github notifications i'm burning through .. if i see more travis issues i'll disable/reenable (or maybe you need to? i hope not) 12:59 < andytoshi> otherwise i'll do it tomorrow maybe 13:03 < BlueMatt> ariard: wait, I dont see anything thats enforcing that sig only gets added once? Or maybe I didnt quite communicate clearly - my goal is that, once we get a local commtiment tx signed, we panic on any further channel updates - that means update_monitor() needs to panic!() 13:05 < ariard> BlueMatt: okay it's 2 things a) enforcing that sig only gets added once (but we should allow multiple signature calls due to block-rescan) 13:05 < ariard> b) panic!()ing when we try to update ChannelMonitor after local commitment signature 13:06 < ariard> we weren't in sync on b), will modify to panic! after either local or HTLC signatures 13:07 < BlueMatt> right, b was my main point here - a is true, but it should be true as a side-effect of b and good data structures, not otherwise. 13:08 < BlueMatt> not that I know if thats possible, but it should def be the goal 13:12 < ariard> BlueMatt: instead of panic!() shouldn't we return a PermanentFailure ? You don't want to crash ChannelMonitor if it's still working to commit onchain a local commitment 13:15 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer] 13:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 13:16 < BlueMatt> ariard: I dunno. I kind prefer panic since its a clear "programmer error - unsafe condition and we may lose funds if we were to continue normally" 13:17 < BlueMatt> *but* that would mean we need to make ChannelMonitor::get_latest_local_commitment_txn() not work until channelmanager has closed the channel 13:18 < BlueMatt> (and we've received said update - which we now do cause its ChannelForceClosed) 13:26 < BlueMatt> ohhey, now travis is fully down 13:26 < BlueMatt> ffs 14:33 < ariard> BlueMatt: let's say we're at local commitment N, ChannelMonitor detects HTLC-timeout at block H, ChannelMonitor locks its state and broadcast local commitment + HTLC-timeout 14:33 < ariard> Channel receives a commitment_signed for N+1, tries to update ChannelMonitor, gets a MonitorUpdateError, we're still safe because revocation_secret for N shouldn't be delivered 14:34 < ariard> whereas panic!() is unsafe, because we may need to bump local commitment to make its way onchain 14:35 < ariard> so once we get any local commitment broadcast trigger (either HTLC-timeout or force-closure) we should forbid any write on local commitment 14:35 < ariard> but we should still allow update for remote commitment, Channel may send an update for remote commitment while ChannelMonitor timeout a HTLC onchain 14:38 < BlueMatt> ariard: ohh, no, thats, like, a bug in the current design :/ 14:39 < BlueMatt> oh, wait, no 14:39 < BlueMatt> right, yea, so we should be allowed to receive new remote commitments, but local commitment updates are never allowed 14:40 < BlueMatt> indeeds, its more subtle 15:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 15:46 < ariard> BlueMatt: right, implementing aformentionned logic obviously break all our functional tests with intentional revocation, any opinion on how to *cleanly* circumvent this for testing ? 15:48 < ariard> like a test-only clone-then-sign unsafe_get_latest_local_commitment_txn ? 17:53 < BlueMatt> ariard: right, we can have a #[cfg(test)] unsafe version 17:53 < BlueMatt> I think thats the right approach 18:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds] 19:23 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ed93:1afc:1e0c:84c9] has quit [Remote host closed the connection] 19:24 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8ab:c195:3051:6360] has joined #rust-bitcoin 19:29 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:b8ab:c195:3051:6360] has quit [Ping timeout: 272 seconds] 19:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:57 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 20:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:20 < ariard> BlueMatt: updated #559 with it, let me know for MPP, seems to me pretty mature after last review, would be cool if we move forward by merging substantial stuff :) 20:21 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 21:57 -!- jtimon [~quassel@206.160.134.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] --- Log closed Sat Mar 28 00:00:35 2020