--- Log opened Fri Apr 10 00:00:48 2020 00:25 -!- jonatack_ [~jon@37.166.238.163] has joined #rust-bitcoin 00:29 -!- jonatack [~jon@37.164.104.82] has quit [Ping timeout: 250 seconds] 00:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 00:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 01:14 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 01:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 02:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 02:04 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 03:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 03:06 -!- Anabelle88Murazi [~Anabelle8@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 03:26 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 256 seconds] 03:29 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin 04:03 < elichai2> real_or_random: should we show how to bypass the Message checks? There's a bunch of different ways to do it... 04:47 -!- Anabelle88Murazi [~Anabelle8@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 04:50 < real_or_random> elichai2: how? 04:50 < real_or_random> my adversarial mind wasn't creative enough here apparently :D 04:51 < elichai2> You can create some message and use `as_mut_ptr()` +`len()` to write zeros into it 04:52 < elichai2> you can copy the impl of `verify` and just replace the message part. everything needed from all the other types is public https://docs.rs/secp256k1/0.17.2/src/secp256k1/lib.rs.html#674-682 04:53 < elichai2> transmuting a `[0u8; 32]` into Message is UB because it's repr(Rust) so that's a no 04:53 < elichai2> you could also do the group order trick ;) 04:54 < elichai2> or the `ThirtyTwoByteHash` trait (just implement it on a struct with public array type) 05:11 -!- jonatack_ [~jon@37.166.238.163] has quit [Ping timeout: 258 seconds] 05:59 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 06:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 06:16 -!- jonatack [~jon@82.102.27.195] has joined #rust-bitcoin 06:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 06:30 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 06:40 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:414a:758a:af0a:6a0b] has joined #rust-bitcoin 06:46 < real_or_random> well sure you can play rust tricks but then you violate the contract with our API 06:47 < real_or_random> and you can't expect guarantees from our API 06:47 < real_or_random> i'd argue you can expect our API to behave if you use the group order 06:50 < elichai2> well in Rust you should only be able to violate an API contract with unsafe AFAIU, so both the order and `ThirtyTwoByteHash` are safe ways. I think we should either allow zeroed hash or don't allow it. but maybe I'm being too formal here idk 06:54 < real_or_random> I think that's a misconception. The thing with unsafe is that a rust program without unsafe shouldn't have language-level UB 06:55 < real_or_random> but that doesn't imply that APIs can't have other restrictions 06:56 < real_or_random> if you have a function that makes only sense for even ints and where the docs says nothing about what happens if you pass odd values, there's nothing wrong with that per se 06:57 < real_or_random> of course you make a rule for yourself to avoid this (and that's properly fine) but I don't think that's a "general" convention in rust 07:04 < elichai2> hmmm that's a good topic for wider rust conversation, but one example I know is controversial because of this is rusts str UTF-8 requirement. technically this isn't really a language UB, but the stdlib docs says it is UB. I think having library related UB is also a thing 07:10 < elichai2> it's a great question, you're saying that the `set` function here shouldn't be unsafe https://play.rust-lang.org/?edition=2018&gist=04a65599a5fe5df5ed56264384015fe6 07:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 07:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 07:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 07:29 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:414a:758a:af0a:6a0b] has quit [Read error: Connection reset by peer] 07:33 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 07:49 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:414a:758a:af0a:6a0b] has joined #rust-bitcoin 08:25 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:414a:758a:af0a:6a0b] has quit [Remote host closed the connection] 08:27 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:414a:758a:af0a:6a0b] has joined #rust-bitcoin 08:30 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:414a:758a:af0a:6a0b] has quit [Remote host closed the connection] 08:50 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has joined #rust-bitcoin 08:56 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has quit [] 09:31 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has joined #rust-bitcoin 10:37 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 250 seconds] 10:40 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin 10:59 -!- Netsplit *.net <-> *.split quits: stevenroose, BlueMatt 11:03 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has quit [Read error: Connection reset by peer] 11:03 -!- Netsplit over, joins: stevenroose, BlueMatt 11:04 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has joined #rust-bitcoin 11:04 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has quit [Read error: Connection reset by peer] 11:59 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 12:01 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 12:01 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has joined #rust-bitcoin 12:04 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 12:13 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:fdd0:9d8c:d74d:864c] has joined #rust-bitcoin 12:13 -!- michaelfolkson [~textual@2a00:23c5:be01:b201:fdd0:9d8c:d74d:864c] has quit [Client Quit] 12:15 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 12:59 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has quit [Remote host closed the connection] 13:50 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has joined #rust-bitcoin 14:48 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 14:54 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 14:58 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Ping timeout: 260 seconds] 15:44 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:712e:945c:72a9:6455] has quit [] 17:03 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 250 seconds] 17:04 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #rust-bitcoin 17:12 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:12 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 19:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 19:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 20:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 20:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 23:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 23:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 23:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin --- Log closed Sat Apr 11 00:00:49 2020