--- Log opened Fri Apr 17 00:00:54 2020
01:50 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e8fe:b743:522f:594d] has joined #rust-bitcoin
01:53 < ariard> BlueMatt: I solve this tmrw at first, was catching up with some core stuff today
02:29 -!- icota [~igor@cm-2242.cable.globalnet.hr] has joined #rust-bitcoin
02:43 -!- icota [~igor@cm-2242.cable.globalnet.hr] has quit [Quit: Konversation terminated!]
03:06 -!- Cielo34Rath [~Cielo34Ra@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
03:47 -!- icota [~igor@cm-2242.cable.globalnet.hr] has joined #rust-bitcoin
05:55 -!- icota [~igor@cm-2242.cable.globalnet.hr] has quit [Quit: Konversation terminated!]
07:35 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
07:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:51 -!- Cielo34Rath [~Cielo34Ra@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 258 seconds]
10:57 -!- Kiminuo [~mix@141.98.103.150] has quit [Remote host closed the connection]
10:58 -!- Kiminuo [~mix@141.98.103.150] has joined #rust-bitcoin
11:28 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:e8fe:b743:522f:594d] has quit [Ping timeout: 265 seconds]
14:55 -!- Kiminuo [~mix@141.98.103.150] has quit [Read error: Connection reset by peer]
15:28 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:48c6:58e7:fb60:7f0a] has joined #rust-bitcoin
15:44 < ariard> BlueMatt: fix minors on 559 where it makes sense
16:41 < BlueMatt> ariard: cool. I'm just gonna take it
16:41 < BlueMatt> I'll have a number of follow-up commits later today hopefully for it
16:42 < BlueMatt> wait, no
16:43 < BlueMatt> ariard: can you fix this? https://github.com/rust-bitcoin/rust-lightning/pull/559#discussion_r401281197
16:43 < BlueMatt> look at the final version, not the diff - you have lines on there twice
16:54 < ariard> BlueMatt: looking on the tip, it's differeent you ChannelManager and ChannelMonitor
16:54 < ariard> looking at commit 95830ed
17:00 < BlueMatt> looking at the tip
17:00 < BlueMatt> I see this:
17:00 < BlueMatt> 		// ChannelMonitor: justice tx revoked offered htlc, justice tx revoked received htlc, justice tx revoked to_local (3)
17:00 < BlueMatt> 		// ChannelManager: local commmitment + local HTLC-timeout (2)
17:00 < BlueMatt> 		// ChannelMonitor: bumped justice tx, after one increase, bumps on HTLC aren't generated not being substantial anymore, bump on revoked to_local isn't generated due to more room for expiration (2)
17:00 < BlueMatt> 		// ChannelMonitor: local commitment + local HTLC-timeout (2)
17:01 < BlueMatt> that totals....way more than 9
17:03 < ariard> you have justice tx revoked offered htlc, justice rtx revoked received htlc, justice tx revoked to_local
17:04 < ariard> local commitment + local HTLC-timeout
17:04 < ariard> bumped justice for revoked offered htlc and justice tx revoked received htlc
17:04 < ariard> local commitment + local HTLC-timeout (ChannelMonitor's)
17:04 < BlueMatt> ah I'm reading the numbers wrong - in other places the (N) thing means N of the type of transaction just listed
17:04 < ariard> I agree intermediary comment isn't that clear
17:04 < BlueMatt> not N for the whole line
17:05 < BlueMatt> alright, I'm gonna merge this, it needs followup anyway, but we need to make progress.
17:05 < ariard> yes, I think I'm not having been consistent every time on notation
17:05 < ariard> part of the The Great Test Framework Cleanup I guess..
17:05 < ariard> going to rebase next ones
17:05 < BlueMatt> lol, right...
18:07 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:48c6:58e7:fb60:7f0a] has quit [Remote host closed the connection]
18:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
20:05 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
--- Log closed Sat Apr 18 00:00:55 2020