--- Log opened Mon Apr 20 00:00:57 2020
01:52 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Quit: ZNC 1.7.5 - https://znc.in]
01:53 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #rust-bitcoin
02:35 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
02:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
03:06 -!- Simeon57Hintz [~Simeon57H@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
07:26 -!- Kiminuo [~mix@141.98.103.180] has quit [Ping timeout: 265 seconds]
07:38 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #rust-bitcoin
07:39 -!- rjected_ [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 260 seconds]
07:43 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has quit [Ping timeout: 260 seconds]
07:49 -!- rjected [~dan@pool-71-184-77-198.bstnma.fios.verizon.net] has joined #rust-bitcoin
08:29 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds]
08:31 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin
08:33 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
08:36 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
08:54 -!- Kiminuo [~mix@141.98.103.212] has joined #rust-bitcoin
09:06 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has joined #rust-bitcoin
09:11 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has quit [Ping timeout: 265 seconds]
09:34 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
09:36 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
09:50 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has joined #rust-bitcoin
09:55 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has quit [Remote host closed the connection]
10:21 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has joined #rust-bitcoin
10:26 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has quit [Read error: Connection reset by peer]
10:27 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has joined #rust-bitcoin
10:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 265 seconds]
10:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
12:08 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-unzvjwvvprhrbggb] has quit [Ping timeout: 265 seconds]
12:09 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-rkpekprofqdxmmcv] has joined #rust-bitcoin
12:14 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
12:43 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Remote host closed the connection]
12:44 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #rust-bitcoin
13:10 -!- dmkathayat [~quassel@ec2-13-233-97-253.ap-south-1.compute.amazonaws.com] has quit [Ping timeout: 245 seconds]
13:10 -!- dmkathayat [~quassel@ec2-13-233-97-253.ap-south-1.compute.amazonaws.com] has joined #rust-bitcoin
14:08 < ariard> BlueMatt: okay reviewing 597 rn, let's make it move forward
14:08 < BlueMatt> ariard: see-also 598 :p
14:10 -!- Simeon57Hintz [~Simeon57H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds]
16:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
17:08 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has quit [Remote host closed the connection]
17:09 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has joined #rust-bitcoin
17:40 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:4c69:7b2b:232d:9ecc] has quit [Remote host closed the connection]
18:38 < ariard> BlueMatt: okay I agree by moving back LocalCommitmentTransaction to ChannelMonitor, and pass transaction data in InputMaterial
18:38 < ariard> we should rename InputMaterial like TxTemplate
18:38 < ariard> and that's a design which make sense also for pre-signed justice tx for watchtower, a) you detect in ChannelMonitor b) you send pre-signed to Onchain
18:39 < ariard> c) Onchain based on signature capability may RBF or CPFP
18:39 < BlueMatt> right, thats kinda what i was thinking previously - OnChainTxHandler should be able to generate transactions "pretty dumbly" only tracking rbf info. it could also be simply passed some transaction info and it would go create a bunch of future-broadcastable transactions for the watchtower
18:40 < BlueMatt> you'll note that I didnt do the move in 598 yet
18:40 < BlueMatt> only cleaned up the api
18:40 < ariard> yes I concept reviewed 598, it's good for me
18:40 < BlueMatt> well you're confusing three things: a) transaction reading, detection, and figuring out what info we need to claim it, b) generating said claim transaction, c) broadcasting it/monitoring for confirmation/rbf
18:40 < ariard> if you want to do the move back, and then I'll painfully rebase my keys PRs
18:40 < BlueMatt> currently channelmonitor is clearly (a), onchain is (b) and (c)
18:41 < BlueMatt> for watchtowers we need (b) split from (c), and maybe (a) to be smart enough to figure out all possible future things it will want braodcasted
18:41 < BlueMatt> I dont really have a strong desire to now
18:41 < BlueMatt> i mean i want to eventually
18:41 < BlueMatt> but, like, the public api that is exposed in 598 is much better, and we can clean up internals as we go.
18:41 < BlueMatt> so no need to do a ton of rebase on *that*, but rebasing on 598 shoudl be doable
18:41 < ariard> b) doesn't suit that much case of local+HTLCs where
18:42 < ariard> okay let's redefine b) as finalizing transaction, which may be delegated to signer
18:47 < ariard> for watchtowers wih (b) split from (c) is kinda doable, just have a enum InputMaterial::Revoked { LocalJustice, WatchtowerJustice } returned by a CommitmentCache interface?
18:47 < ariard> like if you're a watchtower, ChannelMonitor shouldn't have access to LocalCommitment
18:48 < BlueMatt> i mean channelmonitor can and should have access to its data, it currently has a copy of it essentially
18:48 < BlueMatt> just not the local sig
18:48 < BlueMatt> 598 makes LocalCommitmentTransaction const after creation - no more stupid adding signatures inside it
18:48 < ariard> there is not reason for a private watchtower to have access to commitment state if you never need it
18:48 < ariard> *public watchtower which is privacy-preserving
18:50 < ariard> I agree let's move forward with 598, we don't have to do everything rn
21:18 -!- fiatjaf [~fiatjaf@2804:7f2:2981:d3e0:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 256 seconds]
21:20 -!- fiatjaf [~fiatjaf@2804:7f2:2a84:199d:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin
23:06 -!- Kiminuo [~mix@141.98.103.212] has quit [Ping timeout: 256 seconds]
23:14 -!- Kiminuo [~mix@141.98.103.78] has joined #rust-bitcoin
23:29 -!- guest534543 [~mix@141.98.103.110] has joined #rust-bitcoin
23:30 -!- Kiminuo [~mix@141.98.103.78] has quit [Ping timeout: 240 seconds]
--- Log closed Tue Apr 21 00:00:58 2020