--- Log opened Fri Apr 24 00:00:04 2020
01:24 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
01:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
01:52 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
01:57 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
03:06 -!- Litzy40Larkin [~Litzy40La@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
05:08 -!- Litzy40Larkin [~Litzy40La@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection]
06:12 -!- jonatack_ [~jon@37.167.243.115] has joined #rust-bitcoin
06:15 -!- jonatack [~jon@37.173.164.180] has quit [Ping timeout: 265 seconds]
07:00 -!- jonatack_ [~jon@37.167.243.115] has quit [Ping timeout: 260 seconds]
07:02 -!- jonatack_ [~jon@213.152.162.94] has joined #rust-bitcoin
07:18 -!- jonatack_ [~jon@213.152.162.94] has quit [Quit: jonatack_]
07:18 -!- jonatack [~jon@213.152.162.94] has joined #rust-bitcoin
07:36 -!- Kiminuo [~mix@141.98.103.78] has quit [Ping timeout: 265 seconds]
08:45 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
09:49 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:2876:e83c:cef1:e3fa] has quit [Ping timeout: 272 seconds]
09:50 -!- mauz555 [~mauz555@88.125.182.66] has joined #rust-bitcoin
09:56 -!- mauz555 [~mauz555@88.125.182.66] has quit [Ping timeout: 256 seconds]
09:57 -!- mauz555 [~mauz555@88.125.182.66] has joined #rust-bitcoin
10:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:19 -!- Kiminuo [~mix@141.98.103.190] has joined #rust-bitcoin
12:12 -!- mauz555 [~mauz555@88.125.182.66] has quit [Read error: Connection reset by peer]
12:26 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Quit: Ping timeout (120 seconds)]
12:26 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #rust-bitcoin
12:49 -!- mauz555 [~mauz555@88.125.182.66] has joined #rust-bitcoin
12:54 -!- mauz555 [~mauz555@88.125.182.66] has quit [Ping timeout: 256 seconds]
13:08 < BlueMatt> ariard: see comments after https://github.com/rust-bitcoin/rust-lightning/pull/579#pullrequestreview-400152044 sorry, i think its fine after the comments get tweaked and it gets rebased.
13:30 < ariard> BlueMatt: done and rebased :)
13:33 < BlueMatt> ariard: this doc is still nonsense https://github.com/rust-bitcoin/rust-lightning/pull/579#discussion_r414754839
13:33 < BlueMatt> LATENCY_GRACE_PERIOD_BLOCKS isnt public
13:33 < BlueMatt> nor do I think we should be publicly committing to how long you have before auto-failure will happen
13:34 < BlueMatt> oh, note that we now auto-fail, so there isn't a strict limit
13:34 < BlueMatt> i mean generally the user should be able to either fulfill or fail within 1ms, or however long it takes to read from disk :p
13:35 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has joined #rust-bitcoin
13:39 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has quit [Ping timeout: 272 seconds]
14:30 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has joined #rust-bitcoin
14:32 -!- Cordelia38Willms [~Cordelia3@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin
14:45 < ariard> BlueMatt: yeah updated explaining you should cancel before HTLC timing out by counterparty
14:45 < ariard> without giving exact block delay but saying remote is likely to go onchain before exact height expiration
14:46 < ariard> to confirm its commitment smoothly
14:48 < BlueMatt> ariard: note that we now do auto-cancellation
14:48 < BlueMatt> ariard: so you dont *need* to, just should :p
14:49 < ariard> so MAY?
14:49 < BlueMatt> i mean tbh i think just leave the comment as it was?
14:49 -!- Cordelia38Willms [~Cordelia3@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds]
14:49 < BlueMatt> I'm not really sure what new info you're trying to add?
14:49 < ariard> yeah I think that's confusing now
14:49 < ariard> comment was making sense before I did the modification :p
15:10 < BlueMatt> ariard: hmmm, see https://github.com/rust-bitcoin/rust-lightning/pull/579#discussion_r414890182 I'm open to merging as is, but this actually brings up an interesting question
15:10 < BlueMatt> are there any known attacks that waiting for timeout blocks?
15:19 < ariard> BlueMatt: ofc congestion attacks, I'm sending you a payment for an unknown hash?
15:19 < ariard> but like you said, lower bound is a privacy attack, if you fail too fast, you're likely final hop ?
15:20 < ariard> let's track this in our general privacy&security recomendation and merging at it is?
15:20 < BlueMatt> right, but the obvious on-path privacy attack things the attacker knows you're the last hop in the thing they sent you
15:20 < BlueMatt> so failing back late doesn't change anything
15:20 < BlueMatt> well its not obvious to me that there are any attacks that failing back late prevents
15:20 < ariard> no for the privacy, that's any one on the payment path?
15:20 < BlueMatt> and its better to fail back earlier if you can, just from a network-health pov
15:21 < ariard> anyway, that's better for network-health for sure, but failing too fast, previous hop may assume your last one?
15:23 < BlueMatt> right, i mean the previous hop likely learns you're the last hop, but, like, does that matter is my question, i guess
15:24 < ariard> hmmm, depend network topology, but if you're link one is public yes
15:25 < BlueMatt> right, but its only an issue for failure
15:25 < ariard> "If you're aiming for privacy-preserving payment receivement, delay HTLC cancellation a bit before to avoid previous hop learn you're intented recipient"?
15:25 < BlueMatt> not receipt
15:25 < BlueMatt> so, like, you learn that a payment that didnt succeed was destined for us?
15:25 < BlueMatt> which seems somewhat useless given it wasnt accepted/ours anyway
15:26 < ariard> Hmm you may have more exotic settlement, like preimage in the onion, or out-of-band exchange, cancellable HTLCs?
15:26 < ariard> like payment is destined for you, but you don't know yet the preimage, something out-of-band screws up and you cna't finalzie it?
15:27 < BlueMatt> i think we're getting into more esoteric things....
15:27 < BlueMatt> there's already a todo to batch-fulfill/-fail-back HTLCs with our regular batch-forwarding stuff
15:27 < BlueMatt> which we should do
15:28 < BlueMatt> and hopefully thats ~enough, given it means a delay of a few hundred ms, maybe 500ms (I'd like to increase the batch latency if it makes sense)
15:28 < ariard> okay, will just add comment say you SHOULD cancel back HTLC
15:29 < BlueMatt> fair enough, or just leave the text like it was :p
15:29 < BlueMatt> but, yea, ok, i mean it is should (though I dont think we generally use rfc words/all caps in our documentation :p)
15:31 < ariard> that's a "should", not a "SHOULD", how you should interpret that it's up to you ;) ?
15:31 < ariard> updated
15:31 < BlueMatt> fair enough
15:33 < BlueMatt> in other news, just turned off having to wait for travis for merges! now just github actions, which seems to finish faster
15:35 < ariard> so no more travis?
15:35 < ariard> ah no, it's still there
15:36 < BlueMatt> its still there, but dont have to wait for it to finish anymore
15:36 < BlueMatt> I'll leave them both on for now, maybe in a month we'll see which is more stable and switch to only that one
16:47 < BlueMatt> ariard: can I squash https://github.com/rust-bitcoin/rust-lightning/pull/598 and/or do you have more comments?
17:51 < ariard> BlueMatt: yep sure, code is correct, mine get_fully_signed_htlc didn't have the txid check, guess it wass the source of my confusion
17:53 -!- mauz555 [~mauz555@2a01:e0a:56d:9090:ec47:4cfe:fdff:656c] has quit [Remote host closed the connection]
17:53 < ariard> "My only concern by batch-siginng HTLC is to make it harder to use SIGHASH_SINGLE for them in the future" wasn't serious unless you want anchor_output as _today_ :p
18:15 -!- jonatack [~jon@213.152.162.94] has quit [Ping timeout: 264 seconds]
18:16 -!- jonatack [~jon@37.165.157.247] has joined #rust-bitcoin
18:23 < BlueMatt> ha, fair enough!
18:24 < BlueMatt> ariard: can you ack it on github?
18:24 < BlueMatt> I squashed the fixup commits down.
21:44 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:44 < ariard> BlueMatt: back, 0.0.11 can go :)
--- Log closed Sat Apr 25 00:00:05 2020