--- Log opened Tue May 12 00:00:18 2020 00:07 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 00:08 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 01:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 01:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 02:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 02:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 02:42 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 02:44 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 03:11 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin 04:02 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 10:45 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 12:54 < BlueMatt> ariard: left three comments on the new changes. when they get fixed I'll go review the whole thing top to bottom 14:21 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:22 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 14:24 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 14:24 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin 14:41 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 14:42 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin 14:44 < ariard> BlueMatt: thanks for naming suggestions and all, made the changes! 14:46 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 258 seconds] 16:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 16:27 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin 16:31 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 16:48 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 17:32 < BlueMatt> elichai2: when's the last time you tested the rust-secp vendor script against upstream secp? 17:33 < BlueMatt> got someone in ldk slack asking about it cause they want to run it against a branch with adaptor sigs but cant get it to run against upstream/master 17:33 < BlueMatt> or stevenroose maybe 17:34 < BlueMatt> this is what they said: https://0bin.net/paste/r+2Wrw6c5qmWy2Ks#ZKInZeO5-rDlgOSgUOC9yHsR7nPwryMnVtbYCpLa/Xv 17:34 < stevenroose> bitcoin::PublicKey's serde::Deserialize implementation sets the `compressed` flag if the byte size == 66. That seems like it should be <= 66 or so. (Because compressed is 33 and uncompressed 67. 17:34 < stevenroose> 65* 17:34 < BlueMatt> apparently this broke it upstream: commit dcb2e3b3fff0b287d576842aabe5c79f2fe4df30 (HEAD, refs/bisect/bad) 17:34 < stevenroose> Hmm then I don't understand the 66. 17:35 < stevenroose> Ah 66 is 2*33 because it's hex. Ok that makes sense. 17:37 < BlueMatt> https://github.com/rust-bitcoin/rust-secp256k1/issues/214 17:41 -!- nkohen [~nkohen@63-152-39-201.cdrr.qwest.net] has joined #rust-bitcoin 17:46 -!- nkohen [~nkohen@63-152-39-201.cdrr.qwest.net] has quit [Ping timeout: 240 seconds] 17:46 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin 18:12 < stevenroose> Hmm, curious. That upstream commit is quite hard to understand to me. 18:17 < stevenroose> This might be the culprit: // Autotools creates libsecp256k1-config.h, of which ECMULT_GEN_PREC_BITS is needed. 18:18 < stevenroose> Since we replace all symbols of secp256k1_ with another one, we might miss symbols from that file. 18:19 < stevenroose> Ah no that file is not new. 18:34 < stevenroose> Fwiw, it seems that secp256k1-sys was version-bumped without the links being version-bumped. That should probably not have happened. 18:34 < stevenroose> But it's not causing the issue, of course. 18:44 < stevenroose> I didn't find anything at first sight and I'm going to bed right now. 20:25 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 20:32 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin 20:37 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds] 21:23 -!- fiatjaf [~fiatjaf@2804:7f2:2a81:6c39:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 240 seconds] 21:23 -!- fiatjaf [~fiatjaf@2804:7f2:2a81:6c39:ea40:f2ff:fe85:d2dc] has joined #rust-bitcoin 22:42 -!- hami [~hami@39.46.58.91] has joined #rust-bitcoin 22:44 -!- hami [~hami@39.46.58.91] has quit [Quit: hami] 23:16 -!- hami [~hami@39.46.58.91] has joined #rust-bitcoin 23:20 -!- hami [~hami@39.46.58.91] has quit [Client Quit] --- Log closed Wed May 13 00:00:19 2020