--- Log opened Mon May 18 00:00:24 2020
01:31 < ariard> BlueMatt: updated/rebased 610 with new test, it should fail if you tweak the seed
01:31 < ariard> thanks for your comment commits, if people still have a hard time understanding we can write code snippet of the whole derivation
01:34 -!- Trudie63Kassulke [~Trudie63K@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
01:42 < stevenroose> BlueMatt: a real cost to doing what? making it a feature? opt-in or opt-out?
01:50 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
01:52 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
02:13 < elichai2> I agree the option to opt-out would be nice (ie add it as a default feature)
02:16 -!- BelleBonita [c8c3a2f2@gateway/web/cgi-irc/kiwiirc.com/ip.200.195.162.242] has joined #rust-bitcoin
02:19 -!- BelleBonita [c8c3a2f2@gateway/web/cgi-irc/kiwiirc.com/ip.200.195.162.242] has quit [Client Quit]
02:32 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
03:13 -!- Kavon12Langosh [~Kavon12La@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
03:30 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
03:35 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 260 seconds]
03:56 -!- sr_gi_ [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #rust-bitcoin
03:58 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has quit [Ping timeout: 265 seconds]
04:11 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
04:16 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 258 seconds]
04:16 -!- sr_gi_ [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has quit [Read error: Connection reset by peer]
04:16 -!- sr_gi [~sr_gi@183.red-83-34-186.dynamicip.rima-tde.net] has joined #rust-bitcoin
04:18 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
04:19 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
04:48 < stevenroose> elichai2: BlueMatt: updated (also exported the base64 crate, not sure if everyone would agree with that but it seems favorable for the error handling. I'm open to removing that again, though)
04:50 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
04:55 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 272 seconds]
05:01 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
06:04 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds]
06:13 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
06:17 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 265 seconds]
06:18 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
06:23 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 256 seconds]
07:38 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
07:43 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 265 seconds]
07:44 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
07:49 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds]
08:14 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
08:17 -!- Kavon12Langosh [~Kavon12La@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
08:19 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 265 seconds]
08:20 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
08:25 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 258 seconds]
08:35 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
08:39 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds]
09:18 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
09:23 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 264 seconds]
09:40 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has quit [Quit: ZNC 1.7.5 - https://znc.in]
09:41 -!- real_or_random [~real_or_r@173.249.7.254] has joined #rust-bitcoin
11:01 -!- nickler is now known as nix-bitcoin
11:01 -!- nix-bitcoin is now known as nickler
11:03 < BlueMatt> ariard: oh, good point! I forgot we can do sample code in there. we probably should, but, ye, doesn't need to happen rn
11:13 < BlueMatt> stevenroose: why not opt-in? By default rust doesn't do lto or cross-crate optimization last I checked, and this def seems like one of those things that not everyone is gonna use.
11:14 < BlueMatt> though, really, I think it'd be kinda cool to add a bunch of features in rust-bitcoin like the way tokio does it
11:14 < BlueMatt> essentially only expose the basic block/tx/etc structs unless you turn on things like network messages/etc
11:14 < stevenroose> Hmm. Yeah sure I could make it opt-in.
11:15  * BlueMatt also often judges crates based on default-config dependencies when running cargo build
11:15 < BlueMatt> but I'm probably crazy
11:19 < stevenroose> BlueMatt: added it opt-out. also added the base64 feature to Travis
11:19 < BlueMatt> nice, thanks!
11:19 < stevenroose> Yeah I'm a bit double on that front. I think small deps like base64 can be default.
11:19 < stevenroose> Larger things probably not. But yeah, "draw the line" etc etc
11:20 < BlueMatt> well i meant this also not in the context of deps
11:20 < BlueMatt> like, i think its often cool, especially for a library with several largely-unrelated parts, to be broken down by features
11:52 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
11:52 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:38 < elichai2> BlueMatt: fwiw, usually after i'm post early dev stage I add `default-features=false` to all of my deps and then selectively enable features if my code doesn't compile
12:39 < BlueMatt> hmm, fair
13:52 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
14:38 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
15:40 < ariard> BlueMatt: lol, corrected for 610, first time I did that
15:41 < ariard> luckily the one with the new LN attacks ideas was in another dir :p
15:41 < BlueMatt> lol
18:10 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
18:28 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
18:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
19:46 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
19:47 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
19:49 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
19:49 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
20:13 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
20:16 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has joined #rust-bitcoin
20:20 -!- surja795 [~surja795@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds]
20:20 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
20:41 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
--- Log closed Tue May 19 00:00:25 2020