--- Log opened Mon Jul 20 00:00:25 2020 01:52 < stevenroose> instagibbs: :'D 02:11 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:f56e:fb68:b894:e88d] has joined #rust-bitcoin 02:16 < sgeisler> stevenroose: can you have a look at my murmel CI PR https://github.com/rust-bitcoin/murmel/pull/36 please? It's just adds a very basic travis script, but I think that would make reviewing easier. 02:18 < sgeisler> regarding the key problem: with schnorr there will be 3 "key types" that are all usable in different places afaik 02:18 < sgeisler> so maybe it will make sense to have different types for compressed, uncompressed and schnorr 02:19 < sgeisler> these could implement different traits (e.g. compressed and uncompressed the ECDSA trait) 02:19 < sgeisler> so that we can model where they are usable. 02:20 < stevenroose> sgeisler: can you re-push that pr? I activated travis on murmel so it should run the CI when you push again. (not sure if we need to give travis a few minutes to get used to the idea of having to do extra work) 02:21 < sgeisler> stevenroose: it's building 02:22 < stevenroose> k cool 02:22 < stevenroose> sgeisler: the problem with a trait is that there's many places right now where "any ecdsa key" are allowed and will be deserialized f.e. 02:22 < stevenroose> so then we'd have to have an enum type over (un)compressed ecdsa keys as well 02:23 < sgeisler> yeah, alternatively Box, but yeah, both workarounds suck 02:25 < sgeisler> thinking about it, that enum thing doesn't seem too bad. It would only be necessary when dealing with the blockchain/network and never on an application level (I hope nobody uses uncompressed keys nowadays) 02:26 < sgeisler> So, if you build an explorer/node you'll have to deal with the additional complexity. But if you just want to sign your transactions … I guess you can avoid all that 02:32 < stevenroose> sgeisler: but an enum is arguably not much different than the bitcoin::PublicKey type 02:33 < stevenroose> and indeed if you don't use that stuff, you could use secp256k1::PublicKey, it's just that that one is a bit more annoying currently to use with rust-bitcoin API because it expects bitcoin::PublicKey everywhere. but meh I don't really think it's that big of a deal tbh. I mean I have never really been bothered by the API too much. 02:34 < sgeisler> well, if it encapsulates newtypes for (un-)compressed keys it is: it allows us to check compressedness at compile time where not all types are supported 02:36 < sgeisler> But I'd definitely wait for schnorr before implementing anything like that. I don't fancy having to touch all the key stuff either ^^ 03:03 -!- Brad22Stanton [~Brad22Sta@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 03:09 -!- Netsplit *.net <-> *.split quits: Brad22Stanton, wumpus, belcher_ 03:10 -!- Netsplit over, joins: Brad22Stanton 03:10 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 03:10 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #rust-bitcoin 03:53 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 03:55 -!- reallll is now known as belcher 03:55 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:f56e:fb68:b894:e88d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:56 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 05:21 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 260 seconds] 05:24 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:40e9:2682:c291:8cb6] has joined #rust-bitcoin 05:36 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:40e9:2682:c291:8cb6] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:13 -!- shesek [~shesek@188.120.133.185] has joined #rust-bitcoin 06:31 < belcher> i cant figure out how to compile and use rust-wallet in my code, heres an example with the error message https://pastebin.com/VYzgHTx0 06:41 < elichai2> belcher: sound like `bitcoin_wallet` uses a different bitcoin version then you are 06:55 < belcher> elichai2 what should i do now? (as someone new to rust) 06:55 < belcher> is it my problem or should i open an issue on the github of rust-wallet 06:57 < elichai2> belcher: feel free to open an issue for exposing the bitcoin dep from rust-wallet, for now just use `bitcoin = "0.21"`and it should work(that's what the latest bitcoin-wallet uses) 06:58 < belcher> bitcoin = 0.21 does fix it, ty 06:58 < belcher> i think ill open an issue as well 06:59 < belcher> according to this https://github.com/rust-bitcoin/rust-wallet/blob/master/Cargo.toml bitcoin-wallet actually uses 0.23 too(?) 06:59 < elichai2> belcher: keep in mind that there's no real maintainer to rust-wallet right now since Tamas passed away :/ 06:59 < elichai2> belcher: that's the github, look here bottom right under "Dependencies" https://crates.io/crates/bitcoin 07:00 < elichai2> (that's the published one) 07:02 < belcher> i see 07:02 < belcher> sorry to hear about Tamas 07:03 < elichai2> I think stevenroose wants to pick it up though 07:15 < belcher> hold on, given that the github already says bitcoin = "0.23", that means theres nothing to fix? the next time crates.io updates it should be fixed 07:15 < yancy> stevenroose, sgeisler: re pr 428 using traits or a enum is a large refactor, but wouldn't it be better now than in the future if adding another key type? feels wonky to not do type checking here at compile time. 07:15 < belcher> and people could put the github link into Cargo.tollm instead of getting from crates.io 07:20 < sgeisler> yancy: the proposed API in #428 is neither great nor terrible. So I wouldn't do an all-encompassing refactoring just for that. But we might (idk, maybe not) want to change the key API anyway once we introduce schnorr sigs, and we could fix such minor inconveniences as experienced in #428 too at that point. 07:23 < sgeisler> if you feel like it you can of course propose an API change, but iirc the last time the key/address API was changed was rather annoying because it's quite cross-cutting 07:24 < sgeisler> we might also consider churn, rust-bitcoin has downstream users that don't want to rewrite their code every few months. 07:33 < stevenroose> belcher: yeah Tamas assigned his projects to me before he passed away. So I try to do some basic maintainership. I.e. reviewing and merging PRs and doing crates.io releases when people ask for them. But as for rust-wallet, I've had the intention to actually work on it. 07:35 < stevenroose> Murmel as well. It's just that I had some recent personal events (and lots of work) make me a bit short on time. I think soon the bip39 crate will be released in RC, so that's one of the parts of rust-wallet I wanted to take out there. 07:35 < stevenroose> I also updated rust-wallet to bitcoin v23 like you saw. 07:37 < stevenroose> yancy: tbh I'm kind of in favor of waiting what Schnorr will bring us. How rust-secp256k1 will do Schnorr and what we'll have to do in rust-bitcoin to accomodate Schnorr in our API. 07:40 < stevenroose> belcher: for now, you can chose to use rust-wallet as a git dependency and I think I exported the bitcoin dep, so then you can drop bitcoin from your Cargo.toml and just have `use bitcoin_wallet::bitcoin;`. 07:44 -!- Brad22Stanton [~Brad22Sta@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 07:56 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:a9ba:e7d1:8403:5903] has joined #rust-bitcoin 08:09 < elichai2> belcher: you can still fix the need to check the dep version by re-exporting it 08:14 < yancy> sgeisler, stevenroose: cool. I'm fine with helping add a PR also but if you all want to wait until Schnorr drops I'll just wait. 08:14 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:a9ba:e7d1:8403:5903] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 09:27 < yancy> currently I'm stranded on the beach of the Albanian Riveria so I'm not sure I have much time to code anyway atm 09:31 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:188a:4539:27a:a21e] has joined #rust-bitcoin 09:49 < BlueMatt> andytoshi: whats our thinking on msrv? I think its probably time we bumped to 1.29 09:50 < BlueMatt> I dont think any of the arguments in the rust-bitcoin issue are all that relevant anymore 09:51 < BlueMatt> specifically, basically all distros are on 1.34+, and it seems like mrustc is more interested in 1.29 anyway 11:04 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:188a:4539:27a:a21e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:15 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:188a:4539:27a:a21e] has joined #rust-bitcoin 12:13 -!- dr-orlovsky [~dr-orlovs@2001:171b:c9ab:8170:188a:4539:27a:a21e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:16 -!- shesek [~shesek@188.120.133.185] has quit [Ping timeout: 258 seconds] 12:55 < BlueMatt> i can haz ack? https://github.com/rust-bitcoin/rust-secp256k1/pull/219 13:02 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 13:07 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 264 seconds] 13:09 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 13:13 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 240 seconds] 13:17 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 13:21 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 264 seconds] 13:25 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 13:30 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 258 seconds] 13:32 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 13:37 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 246 seconds] 13:39 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 13:44 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 265 seconds] 13:46 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 13:51 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 256 seconds] 13:55 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 14:00 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 256 seconds] 14:01 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 14:05 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 260 seconds] 14:09 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 14:13 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 258 seconds] 14:18 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 14:22 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 240 seconds] 14:23 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 14:28 -!- shesek [~shesek@5.22.128.126] has quit [Ping timeout: 240 seconds] 14:31 -!- shesek [~shesek@5.22.128.126] has joined #rust-bitcoin 19:28 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Tue Jul 21 00:00:26 2020