--- Log opened Tue Aug 25 00:00:59 2020 00:08 -!- jonatack [~jon@37.166.120.102] has quit [Ping timeout: 240 seconds] 00:12 -!- jonatack [~jon@37.166.120.102] has joined #rust-bitcoin 00:16 -!- jonatack [~jon@37.166.120.102] has quit [Ping timeout: 246 seconds] 00:19 < elichai2> andytoshi: the ECDH is pretty safe already, my current complain is with the error/illegal callbacks https://github.com/rust-bitcoin/rust-secp256k1/issues/228 00:22 < elichai2> wow, what you sent is VERY interesting, and contradicts a lot of docs 00:22 < elichai2> "Functions with an ABI that differs from "Rust" do not support unwinding in the exact same way that Rust does. Therefore, unwinding past the end of functions with such ABIs causes the process to abort." 00:22 < elichai2> https://github.com/rust-lang/reference/blob/master/src/items/functions.md#extern-function-qualifier 00:23 -!- jonatack [~jon@37.166.201.6] has joined #rust-bitcoin 00:23 -!- jonatack [~jon@37.166.201.6] has quit [Client Quit] 00:23 -!- jonatack [~jon@37.166.120.102] has joined #rust-bitcoin 00:25 < elichai2> I tagged a few of rust core devs to see what they think, will update 00:25 < elichai2> andytoshi: it's too late but I already summarized the release docs lol https://github.com/rust-bitcoin/rust-bitcoin/issues/338#issue-518527461 00:28 -!- jonatack [~jon@37.166.120.102] has quit [Ping timeout: 256 seconds] 01:09 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 01:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 01:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 01:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin 01:40 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 01:40 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 03:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:05 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 03:15 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-wpdtkxyyinilwsfr] has quit [Read error: Connection reset by peer] 03:15 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-wezdtzfnojtzpvay] has joined #rust-bitcoin 03:50 -!- felixweis [sid154231@gateway/web/irccloud.com/x-tjakxxqoraoowpeh] has quit [Ping timeout: 244 seconds] 03:50 -!- wallet42_ [sid154231@gateway/web/irccloud.com/x-bvcnlkqxwieqjhxb] has quit [Ping timeout: 260 seconds] 03:50 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-tvwaejwbstchkagt] has quit [Ping timeout: 260 seconds] 04:00 -!- felixweis [sid154231@gateway/web/irccloud.com/x-jlmbxhhtbxlzhkla] has joined #rust-bitcoin 04:00 -!- wallet42_ [sid154231@gateway/web/irccloud.com/x-rowyyzgiybpygdar] has joined #rust-bitcoin 04:00 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-ktcafifpocehctxo] has joined #rust-bitcoin 04:18 -!- Pamela49West [~Pamela49W@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin 04:48 < cloudhead> dpc: thanks, makes sense 04:51 < cloudhead> 1.31 gives you const fns which I think area really nice.. bitcoin has a lot of parameters exposed as functions (e.g Params::new(network)) and it's nice to be able to use these inside constants 04:51 < cloudhead> I've run into this several times already 05:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 07:43 < BlueMatt> cloudhead: sadly, mrustc only supports 1.29 08:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 08:11 < andytoshi> it's tempting to go to 1.31 08:11 < andytoshi> that's only two bootstraps from 1.29 08:11 < andytoshi> and it would let us use 2018-style modules etc 08:53 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 244 seconds] 08:54 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin 08:58 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 244 seconds] 09:05 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin 09:11 < elichai2> OoO 09:13 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 272 seconds] 09:13 < andytoshi> thinking of doing a new release in the next day or two 09:13 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin 09:13 < andytoshi> before this 09:13 < andytoshi> sanket1729: BlueMatt: stevenroose: elichai2: what stuff needs to get in before that? 09:15 < elichai2> IIRC rust-secp needs a major, don't remember about rust-bitcoin 09:15 < andytoshi> oh heh kk 09:15 < andytoshi> i'll look at rust-secp then 09:16 < elichai2> This should be nice for serde users #218 09:30 < BlueMatt> andytoshi: i dont have anything i care about getting in, IIRC, just stuff thats already merged. 09:30 < BlueMatt> andytoshi: fwiw, I'm ok with 1.31 as well...not a huge fan, but if someone wants to argue strongly for nll/2018, thats ok with me 10:30 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 10:33 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds] 10:39 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 10:47 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 10:59 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:31 -!- neonknight64 [~neonknigh@195.159.29.126] has quit [Quit: Ping timeout (120 seconds)] 11:32 -!- neonknight64 [~neonknigh@195.159.29.126] has joined #rust-bitcoin 11:50 -!- wallet42_ [sid154231@gateway/web/irccloud.com/x-rowyyzgiybpygdar] has quit [Ping timeout: 272 seconds] 11:53 -!- wallet42_ [sid154231@gateway/web/irccloud.com/x-hwhlmefxzyxrngtu] has joined #rust-bitcoin 12:39 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin 12:39 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 12:39 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin 12:59 -!- reallll is now known as belcher 13:00 < BlueMatt> andytoshi: are you planning on doing minor releases then major with the msrv bump, or are you just gonna do a major release with msrv bump 13:00 < BlueMatt> (not that I think it matters too much, just curious) 13:08 < andytoshi> BlueMatt: i'm gonna release before the msrv bump 13:08 < andytoshi> if that's only a minor release, awesome 13:08 < BlueMatt> ah, ok, cool. 13:08 < andytoshi> but i assumed (haven't looked at the diff yet) it'll have to be a major release 13:08 < andytoshi> so we'll just have two major releases in quick succession 13:09 < andytoshi> also i think rust-secp needs a major release 13:10 < BlueMatt> thats what elichai2 said, tho i also didnt look at the diff 13:10 < andytoshi> me neither. have a couple calls today, not sure if i'll get to it 13:12 < BlueMatt> ah, ok 13:50 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:04 -!- evalr [~evalr@malta1854.startdedicated.net] has quit [Remote host closed the connection] 14:05 -!- evalr [~evalr@malta1854.startdedicated.net] has joined #rust-bitcoin 15:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 15:21 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 15:21 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 16:26 -!- titanbiscuit [~tbisk@45.9.251.164] has quit [Ping timeout: 256 seconds] 16:29 -!- titanbiscuit [~tbisk@66.115.154.150] has joined #rust-bitcoin 16:39 < BlueMatt> re: SigHashCache replacing SighashComponents...its def way nicer, but also because it requires you hold the tx ref the whole time, it breaks uses like { let sh = SigHashCache::new(&tx); for (inp, i) in tx.inputs.iter_mut().enumerate() { inp.witness = sh.sign(i); } } 16:39 < BlueMatt> so I think we should un-deprecate SighashComponents, sadly :( 16:40 < BlueMatt> or maybe a way to do it without holding the ref. 16:42 < BlueMatt> or maybe the easiest is to let SigHashCache hold a mut-ref and then provide access to the witnesses 16:42 -!- Pamela49West [~Pamela49W@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 16:43 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 16:51 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 17:07 < BlueMatt> nvm, fixed it 18:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 18:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin --- Log closed Wed Aug 26 00:00:59 2020