--- Log opened Tue Sep 08 00:00:13 2020
00:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
00:28 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
00:31 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
01:52 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:53 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
01:55 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:56 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
01:59 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #rust-bitcoin
02:05 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 246 seconds]
02:05 -!- jonatack [~jon@37.172.68.103] has joined #rust-bitcoin
02:22 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
02:22 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
02:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
02:52 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
02:53 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
03:56 -!- jonatack [~jon@37.172.68.103] has quit [Ping timeout: 264 seconds]
03:57 -!- jonatack [~jon@213.152.161.211] has joined #rust-bitcoin
04:12 -!- jonatack [~jon@213.152.161.211] has quit [Ping timeout: 240 seconds]
05:31 -!- reallll is now known as belcher
06:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
06:10 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
06:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
06:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]
12:04 -!- vindard [~vindard@190.83.165.233] has quit [Ping timeout: 240 seconds]
12:13 < BlueMatt> ariard: will respond today, sorry
12:13 < BlueMatt> andytoshi: ok, now rust-bitcoin release is my blocker :)
12:27 -!- shesek [~shesek@164.90.217.137] has joined #rust-bitcoin
12:27 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
12:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #rust-bitcoin
12:50 < andytoshi> heh shit ok. will try for today, but tomorrow more likely
12:51 < andytoshi> have one more phone call, in ten minutes, then will be free
12:51 < BlueMatt> i didnt mean to imply it needs to happen today, but this week would be nice
12:51 < BlueMatt> then we can finally merge our C/C++ bindings and have good rust-lightning callability from several languages :)
12:51 < andytoshi> nice!
12:52 < andytoshi> it's been blocking some rust-miniscript stuff too, i'd like to push forward on it
14:16 -!- vindard [~vindard@190.83.165.233] has joined #rust-bitcoin
15:47 < ariard> BlueMatt: updated, thanks :)
16:10 < sanket1729> What do people thing about enforcing rustfmt style code in rust-bitcoin?
16:11 < sanket1729> As a relatively new rust-programmer, I am used to rustfmt style formatting and kindof rely on it indent my code.
16:11 < sanket1729> But currently running rustfmt directly creates a massive diff.
16:12 < sanket1729> One significant drawback is that since it would touch many parts of the codebase, it will affect all open PRs.
16:13 < BlueMatt> a) rustfmt has a few really obnoxious things where it'll make your code about a million lines long and you cant turn it off and b) rustfmt is still kinda variable between rust versions, though less so these days
16:14 < BlueMatt> specifically, iirc, https://github.com/rust-lang/rustfmt/issues/4146
16:14 < BlueMatt> the second a line runs over the predetermined max line length it makes everything massively vertical and has no config option to turn off the insanity
16:15 < BlueMatt> (that issue is the reason we gave up on trying to use it in rust-lightning)
16:23 < sanket1729> Ah, I see that you guys tried a lot to make it work.
16:25 < sanket1729> If vertical fall for fn like attributes is the only concern, we can set attr_fn_like_width to a very high number and rely on manual indenting for function def/calls while still using other features of rustfmt.
16:45 < BlueMatt> i believe it'll "helpfully" reformat you to make your lines of infinite length if you do that?
16:55 < sanket1729> Yes, you are right :)
17:27 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
17:35 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
17:53 < sanket1729> Looks like something broke in the latest nightly
17:55 < sanket1729> something serde related, looking into it.
18:10 < sanket1729> Maybe someone else might be able to fix this more easily. https://github.com/rust-bitcoin/rust-bitcoin/issues/468
20:00 < andytoshi> sanket1729: you can annotate specific things somehow to tell rustfmt to fuck off
20:01 < andytoshi> but having to do this on every single byte array is pretty annoying
20:01 < andytoshi> i would like rust-bitcoin to use rustfmt one day, and had we done this from the start it'd have probably been ok. but it really has been super unstable
20:02 < andytoshi> even in liquid we had it for a while, one like 3 files, and eventually dropped it because it kept changing those 3 ifles
20:30 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
20:30 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:44 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
22:45 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:50 < dpc> Really? I've been using `rustfmt` on my project, and I have fmt on save in my editors and didn't notice problems. But I guess I'm not paying too much attention to this, so I might have missed it.
23:01 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
23:02 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
23:41 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds]
--- Log closed Wed Sep 09 00:00:13 2020