--- Log opened Wed Sep 09 00:00:13 2020
00:16 < dr-orlovsky> with taking util/number/hex stuff out of rust-bitcoin and bitcoin_hashes https://github.com/rust-bitcoin/rust-bitcoin/issues/467 I have also applied rustfmt for that part, so this will also help to move in that direction
00:16 < dr-orlovsky> https://github.com/LNP-BP/bitcoin_num
00:17 < dr-orlovsky> As I said in description, it will be nice to move it into rust-bitcoin github org and update them before other PRs will touch these removed parts of the code
00:18 < dr-orlovsky> For review pls check instructions https://github.com/rust-bitcoin/rust-bitcoin/issues/467#issuecomment-687351839: repo contains three PRs, which will help to review changers stage by stage
00:28 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
00:29 -!- jonatack [~jon@37.171.144.181] has joined #rust-bitcoin
00:31 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
00:34 -!- jonatack [~jon@37.171.144.181] has quit [Ping timeout: 260 seconds]
00:36 -!- jonatack [~jon@109.232.227.138] has joined #rust-bitcoin
02:00 < cloudhead> andytoshi: that must have been a long time ago re:rustfmt .. I've been using it accross a dozen projects in the last year and haven't seen that happen once
02:00 < cloudhead> I think the diff would be fairly easy to review also
03:15 -!- jonatack [~jon@109.232.227.138] has quit [Ping timeout: 264 seconds]
04:18 -!- Lavina58Bauch [~Lavina58B@static.57.1.216.95.clients.your-server.de] has joined #rust-bitcoin
04:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
04:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
05:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
07:13 < andytoshi> cloudhead: it was less than a year ago that we dropped it
07:14 < andytoshi> and the issue is not just review work, it's that it breaks `git blame`, makes rebases hard when there are multiple PRs in flight, makes bisecting harder
07:15 < andytoshi> it forces everybody to update rustfmt at the same time, and to update CI at the same time as everyone
07:15 < andytoshi> dr-orlovsky: cool!
07:54 < andytoshi> BlueMatt: any specific PRs you want me to merge before we release a new version?
07:54 < andytoshi> i am going through the PR list and will merge anything that happens to be ready but i'm not blocked on anything, so my plan is that if it's not good to go, it's not going in
08:01 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
08:04 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
08:05 < elichai2> andytoshi: maybe starting to do rustfmt as a per-file experiment can be interesting, i know that's how rustc integrated it, slowly and file by file
08:06 < andytoshi> elichai2: i'd be in favor of that, certainly
08:06 < andytoshi> but like, the moment we get CI failures because rustfmt changed out from under us, we're ripping it out
08:08 < elichai2> BlueMatt: about the multi-line, yeah I hate that too, which is why I'm using a `.rustfmt.toml` file, so it will preserve my "longer" fn lines and won't put new lines there https://github.com/elichai/log-derive/blob/master/.rustfmt.toml
08:08 < elichai2> andytoshi: sure, why not. then we could also have an actual thing to complain about :P
08:22 < andytoshi> i mean, rustfmt changes have happened to me repeatedly in every project i've tried it with
08:46 < BlueMatt> ariard: can you take a look at https://github.com/rust-bitcoin/rust-lightning/pull/633#discussion_r485174012
08:47 < BlueMatt> andytoshi: https://github.com/rust-bitcoin/rust-bitcoin/pull/461 is rather simple and prevents an api-usability regression for us.
08:48 < BlueMatt> elichai2: see the issue linked - I believe there is no way to use a rustfmt.toml to fix it - you either get mega-long lines or you get super tiny lines that make your code a billion lines long, and there's nothing in between.
08:50 < BlueMatt> andytoshi: aside from that I havent followed rust-bitcoin enough to know, and nothing else came up as a blocker when i upgraded to git master on RL.
08:52 < elichai2> BlueMatt: ha, I guess I usually have 1-4 inputs for a function. (but I commented too there hehe)
08:54 < BlueMatt> yea, somtimes thats just not possible
09:01 < andytoshi> elichai2: can you give me a second ack on https://github.com/rust-bitcoin/rust-bitcoin/pull/397 ?
09:02 < elichai2> looking at it now
09:05 < ariard> BlueMatt: comment is correct, but I confess confusing, will fix it
09:06 < elichai2> andytoshi: done
09:07 < BlueMatt> ariard: right, its just super awkward to say "counterparty-broadcasted" when we mean "locally-broadcasted spending counterparty-broadcasted"
09:07 < BlueMatt> ariard: I think ti would be nice to change the name, too.
09:08 -!- Lavina58Bauch [~Lavina58B@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 258 seconds]
09:10 < andytoshi> thanks elichai2
10:08 < andytoshi> elichai2: also ack on https://github.com/rust-bitcoin/rust-bitcoin/pull/459/files ?
10:13 < elichai2> andytoshi: I want to ask why extend doesn't extend the current one but instead creates a new path, but it looks like `child()` also does the same?
10:14 < elichai2> also, it doesn't build
10:14 < elichai2> it reuses the `path` variable
10:16 < andytoshi> lol i just noticed that
10:16 < andytoshi> sorry should've finished my review before pinging you
10:18 < elichai2> hehe it's fine
14:26 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:27 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
15:50 < ariard> BlueMatt: updated 633 with only a comment change, not variables as in fact broadcaster is correct, keypair belong to him as they're committed in his commitment transaction scriptpubkey
15:51 < ariard> BlueMatt: or say differently to whom belong a key ? The transaction owner where they're committed or the one who have knowledge to spend it ? Even harder as it's a blinded key here
15:52 < BlueMatt> ariard: right, but i think my point is that there isnt an answer - so we should avoid saying it is someone's
15:52 < BlueMatt> other keys its clear, but revocation is....well, just revocation
15:52 < BlueMatt> anyway, did you see my other comments?
15:56 < ariard> BlueMatt: ah sorry, addressing them
15:57 < ariard> BlueMatt: on the merge side, what's is ready and need attention? I'll try to help gleb on the MPP thing to make it more digestible, there is also the BOLT8 refactoring which sounds near to go further
15:57 < ariard> I hope to drop the anchor output end of week
16:02 < BlueMatt> ariard: hmm, i *think* I'm caught up on review, except for MPP.
16:03 < BlueMatt> ariard: the big things are: gossip_queries (but looks like just messages for now? you asked how the op wants to proceed), the val/jeff refactorings, your big rename thing, and mpp
16:03 < BlueMatt> the other prs are of various sizes
16:10 < ariard> BlueMatt: and this https://github.com/arik-so/rust-lightning/pull/2, that's pretty dope work and getting it past the merging line quickly would be great
16:12 < ariard> BlueMatt: for MPP I'm really leaning towards a bit of refactorization, I fear we won't understand this code in the future
17:52 < BlueMatt> ariard: yea, I'm fine with refactoring the router a bunch, but I havent looked into how to do it. I made gleb add comments and clean it up a bit just for reviewability, and I don't want to make gleb refactor the whole thing as a condition for merge, but if you have ideas, go!
20:32 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds]
20:34 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin
22:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
--- Log closed Thu Sep 10 00:00:14 2020